Dep: Silenced build warning in G3D header

(cherry picked from commit 22653c99f874e189bda6670c42be38151b58e52b)
(cherry picked from commit cce7f1adf2b76c59d8a07f080f23d4b125ed8f15)
(cherry picked from commit d2795c98ddf37ab3a74752ecf54ad65af8541c25)
This commit is contained in:
Shauren committed 2015-10-31 17:33:35 +01:00
1 parent 7fb63478bb
commit 119c372dff
3 files changed
+34 -5

No files matched your search

+28
View File
@@ -0,0 +1,28 @@
diff --git a/dep/g3dlite/include/G3D/Quat.h b/dep/g3dlite/include/G3D/Quat.h
index 04e11e0..b26708a 100644
--- a/dep/g3dlite/include/G3D/Quat.h
+++ b/dep/g3dlite/include/G3D/Quat.h
@@ -335,8 +335,8 @@ public:
Note that q.pow(a).pow(b) == q.pow(a + b)
@cite Dam98 pg 21
*/
- inline Quat pow(float x) const {
- return (log() * x).exp();
+ inline Quat pow(float r) const {
+ return (log() * r).exp();
}
/** Make unit length in place */
@@ -349,9 +349,9 @@ public:
the magnitude.
*/
Quat toUnit() const {
- Quat x = *this;
- x.unitize();
- return x;
+ Quat copyOfThis = *this;
+ copyOfThis.unitize();
+ return copyOfThis;
}
/**
+1
View File
@@ -14,3 +14,4 @@ G3D-v9.0 hotfix1.diff - 2014-08-22 - updated to G3D9, reapplied previous patches
G3D-v9.0 hotfix2.diff - 2014-08-23 - fix some -Wconversion warnings G3D-v9.0 hotfix2.diff - 2014-08-23 - fix some -Wconversion warnings
G3D-v9.0 hotfix3.diff - 2015-06-28 - fix some warnings G3D-v9.0 hotfix3.diff - 2015-06-28 - fix some warnings
G3D-v9.0 hotfix4.diff - 2015-07-02 - backport G3D10 fix G3D-v9.0 hotfix4.diff - 2015-07-02 - backport G3D10 fix
G3D-v9.0 hotfix5.diff - 2015-07-31 - fix MSVC 2015 warning: dep/g3dlite/include/G3D/Quat.h(352): warning C4458: declaration of 'x' hides class member
+5 -5
View File
@@ -335,8 +335,8 @@ public:
Note that q.pow(a).pow(b) == q.pow(a + b) Note that q.pow(a).pow(b) == q.pow(a + b)
@cite Dam98 pg 21 @cite Dam98 pg 21
*/ */
inline Quat pow(float x) const { inline Quat pow(float r) const {
return (log() * x).exp(); return (log() * r).exp();
} }
/** Make unit length in place */ /** Make unit length in place */
@@ -349,9 +349,9 @@ public:
the magnitude. the magnitude.
*/ */
Quat toUnit() const { Quat toUnit() const {
Quat x = *this; Quat copyOfThis = *this;
x.unitize(); copyOfThis.unitize();
return x; return copyOfThis;
} }
/** /**