From 18e2a744bb9e7f94418790497190339210fcb1cc Mon Sep 17 00:00:00 2001 From: Ovahlord Date: Sun, 20 Aug 2023 21:11:49 +0200 Subject: [PATCH] Misc: reduce differences in Docker and CircleCI configs between branches --- .circleci/config.yml | 2 +- CMakeLists.txt | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 41177126a5..967ea5d494 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -89,7 +89,7 @@ jobs: docker build --file Dockerfile --force-rm --tag $image_prefix:$CIRCLE_SHA1 --tag $image_prefix:$(echo $CIRCLE_BRANCH | tr '/' '-' | tr '[:upper:]' '[:lower:]') . docker save $image_prefix | gzip > ../../docker.tar.gz if [ "$DOCKERHUB_PUSH_IMAGES" == "TRUE" ]; then - if [ "$CIRCLE_BRANCH" == "master" ]; then + if [ "$CIRCLE_BRANCH" == "4.3.4" ]; then docker login -u $DOCKERHUB_USERNAME -p $DOCKERHUB_PASSWORD echo "Pushing docker image to dockerhub" docker push --all-tags $image_prefix diff --git a/CMakeLists.txt b/CMakeLists.txt index 2f0f0f0f33..f2bee42e63 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -86,4 +86,10 @@ if(BUILD_TESTING) include(Catch) add_subdirectory(tests) + + # Catch cmakefile messes with our settings we explicitly leave up to the user + # restore user preference + if (NOT WITH_SOURCE_TREE STREQUAL "hierarchical-folders") + set_property(GLOBAL PROPERTY USE_FOLDERS OFF) + endif() endif()