From 1a1a33d0f0a2ad23ad8edd913fd8031a8cdafc75 Mon Sep 17 00:00:00 2001 From: Aokromes Date: Tue, 19 Jul 2016 15:58:23 +0200 Subject: [PATCH] Core/PacketIO: Missing changes from 548aa11 that could result in a crash due to double Locking (#17008) Socket will be closed because of ReadDataHandlerResult::Error. --- src/server/game/Server/WorldSocket.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server/game/Server/WorldSocket.cpp b/src/server/game/Server/WorldSocket.cpp index 1a51a84b72..59992824ad 100644 --- a/src/server/game/Server/WorldSocket.cpp +++ b/src/server/game/Server/WorldSocket.cpp @@ -405,11 +405,12 @@ WorldSocket::ReadDataHandlerResult WorldSocket::ReadDataHandler() default: { sessionGuard.lock(); + LogOpcodeText(opcode, sessionGuard); + if (!_worldSession) { TC_LOG_ERROR("network.opcode", "ProcessIncoming: Client not authed opcode = %u", uint32(opcode)); - CloseSocket(); return ReadDataHandlerResult::Error; }