From 2530db5a51b9b10ec6c3c990b2ab3d0c1ed72f2d Mon Sep 17 00:00:00 2001 From: Carbenium Date: Tue, 21 Jul 2015 20:40:21 +0200 Subject: [PATCH] Fix merge --- src/server/game/Accounts/AccountMgr.cpp | 2 +- src/server/game/Conditions/ConditionMgr.cpp | 3 ++- src/server/game/Server/WorldSession.cpp | 8 ++++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/server/game/Accounts/AccountMgr.cpp b/src/server/game/Accounts/AccountMgr.cpp index 1ef794ab61..d3e0550b0c 100644 --- a/src/server/game/Accounts/AccountMgr.cpp +++ b/src/server/game/Accounts/AccountMgr.cpp @@ -446,7 +446,7 @@ void AccountMgr::LoadRBAC() while (result->NextRow()); TC_LOG_DEBUG("rbac", "AccountMgr::LoadRBAC: Loading default permissions"); - result = LoginDatabase.PQuery("SELECT secId, permissionId FROM rbac_default_permissions WHERE (realmId = %u OR realmId = -1) ORDER BY secId ASC", realmID); + result = LoginDatabase.PQuery("SELECT secId, permissionId FROM rbac_default_permissions WHERE (realmId = %u OR realmId = -1) ORDER BY secId ASC", realmHandle.Index); if (!result) { TC_LOG_INFO("server.loading", ">> Loaded 0 default permission definitions. DB table `rbac_default_permissions` is empty."); diff --git a/src/server/game/Conditions/ConditionMgr.cpp b/src/server/game/Conditions/ConditionMgr.cpp index 9332536a30..8d5427f476 100644 --- a/src/server/game/Conditions/ConditionMgr.cpp +++ b/src/server/game/Conditions/ConditionMgr.cpp @@ -2028,6 +2028,8 @@ bool ConditionMgr::isConditionTypeValid(Condition* cond) TC_LOG_ERROR("sql.sql", "%s has non existing world state in value1 (%u), skipped.", cond->ToString(true).c_str(), cond->ConditionValue1); return false; } + break; + } case CONDITION_PHASEID: { if (!sPhaseStore.LookupEntry(cond->ConditionValue1)) @@ -2084,7 +2086,6 @@ bool ConditionMgr::isConditionTypeValid(Condition* cond) } case CONDITION_INSTANCE_INFO: case CONDITION_AREAID: - case CONDITION_PHASEMASK: case CONDITION_ALIVE: break; default: diff --git a/src/server/game/Server/WorldSession.cpp b/src/server/game/Server/WorldSession.cpp index 05ebe14135..7c2b9c2b95 100644 --- a/src/server/game/Server/WorldSession.cpp +++ b/src/server/game/Server/WorldSession.cpp @@ -324,7 +324,7 @@ bool WorldSession::Update(uint32 diff, PacketFilter& updater) while (m_Socket && !_recvQueue.empty() && _recvQueue.peek(true) != firstDelayedPacket && _recvQueue.next(packet, updater)) { - if (packet->GetOpcode() >= NUM_MSG_TYPES) + if (packet->GetOpcode() >= NUM_OPCODE_HANDLERS) { TC_LOG_ERROR("network.opcode", "Received non-existed opcode %s from %s", GetOpcodeNameForLogging(packet->GetOpcode()).c_str() , GetPlayerInfo().c_str()); @@ -332,7 +332,7 @@ bool WorldSession::Update(uint32 diff, PacketFilter& updater) } else { - OpcodeHandler& opHandle = opcodeTable[packet->GetOpcode()]; + OpcodeHandler const* opHandle = opcodeTable[packet->GetOpcode()]; try { switch (opHandle->Status) @@ -359,7 +359,7 @@ bool WorldSession::Update(uint32 diff, PacketFilter& updater) else if (_player->IsInWorld() && AntiDOS.EvaluateOpcode(*packet, currentTime)) { sScriptMgr->OnPacketReceive(this, *packet); - (this->*opHandle.handler)(*packet); + (this->*opHandle->Handler)(*packet); LogUnprocessedTail(packet); } // lag can cause STATUS_LOGGEDIN opcodes to arrive after the player started a transfer @@ -404,7 +404,7 @@ bool WorldSession::Update(uint32 diff, PacketFilter& updater) if (AntiDOS.EvaluateOpcode(*packet, currentTime)) { sScriptMgr->OnPacketReceive(this, *packet); - (this->*opHandle->Handler)(*packet); + (this->*opHandle->Handler)(*packet); LogUnprocessedTail(packet); } break;