From 2e6bee21047860a0931fdc44da919be80ce769c3 Mon Sep 17 00:00:00 2001 From: sevi Date: Tue, 10 Mar 2026 09:31:45 +0100 Subject: [PATCH] Core/Objects: fixed buffer initialization of PackedGuid (#462) * Core/ObjectGuid: Properly initialize PackedGuid buffer * use correct initializer for buffer initialization * correct array initialization in PackedGuid constructors --------- Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com> --- src/server/game/Entities/Object/ObjectGuid.cpp | 1 + src/server/game/Entities/Object/ObjectGuid.h | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/server/game/Entities/Object/ObjectGuid.cpp b/src/server/game/Entities/Object/ObjectGuid.cpp index 847d95264d..74505813bd 100644 --- a/src/server/game/Entities/Object/ObjectGuid.cpp +++ b/src/server/game/Entities/Object/ObjectGuid.cpp @@ -86,6 +86,7 @@ ObjectGuid ObjectGuid::MapSpecific(HighGuid type, uint32 entry, LowType counter) void PackedGuid::Set(ObjectGuid guid) { _packedSize = 1; + _packedGuid = { }; uint64 raw = guid.GetRawValue(); for (uint8 i = 0; i < 8; ++i) { diff --git a/src/server/game/Entities/Object/ObjectGuid.h b/src/server/game/Entities/Object/ObjectGuid.h index 81a4ebae0f..a064edae1f 100644 --- a/src/server/game/Entities/Object/ObjectGuid.h +++ b/src/server/game/Entities/Object/ObjectGuid.h @@ -299,8 +299,8 @@ class TC_GAME_API PackedGuid friend TC_GAME_API ByteBuffer& operator<<(ByteBuffer& buf, PackedGuid const& guid); public: - explicit PackedGuid() : _packedSize(1), _packedGuid() { } - explicit PackedGuid(ObjectGuid guid) { Set(guid); } + explicit PackedGuid() : _packedSize(1), _packedGuid({}) { } + explicit PackedGuid(ObjectGuid guid) : _packedSize(1), _packedGuid({}) { Set(guid); } void Set(ObjectGuid guid);