Core/Game: Fix some issues detected by static analysis.

* Possible inefficient checking for 'list' emptiness.

* Variable '_scheduledScripts' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Variable 'Text' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Possible inefficient checking for 'm_loadedScripts' emptiness.

(cherry picked from commit 9a61049f88835fd6bdb75905f042583d038d0667)

Conflicts:
	src/server/game/Server/Packets/TicketPackets.cpp
This commit is contained in:
Naios authored and Nayd committed 2015-03-18 01:13:47 +00:00
1 parent a38945a3b3
commit 301ec0be56
3 files changed
+4 -5

No files matched your search

+1 -2
View File
@@ -182,9 +182,8 @@ struct TSpellSummary
uint8 Effects; // set of enum SelectEffect
} *SpellSummary;
ScriptMgr::ScriptMgr() : _scriptCount(0)
ScriptMgr::ScriptMgr() : _scriptCount(0), _scheduledScripts(0)
{
_scheduledScripts = 0;
}
ScriptMgr::~ScriptMgr() { }