Core/Game: Fix some issues detected by static analysis.
* Possible inefficient checking for 'list' emptiness. * Variable '_scheduledScripts' is assigned in constructor body. Consider performing initialization in initialization list. * Variable 'Text' is assigned in constructor body. Consider performing initialization in initialization list. * Possible inefficient checking for 'm_loadedScripts' emptiness. (cherry picked from commit 9a61049f88835fd6bdb75905f042583d038d0667) Conflicts: src/server/game/Server/Packets/TicketPackets.cpp
This commit is contained in:
1 parent
a38945a3b3
commit
301ec0be56
3 files changed
+4
-5
No files matched your search
@@ -7140,7 +7140,7 @@ void Spell::CallScriptDestinationTargetSelectHandlers(SpellDestination& target,
|
||||
bool Spell::CheckScriptEffectImplicitTargets(uint32 effIndex, uint32 effIndexToCheck)
|
||||
{
|
||||
// Skip if there are not any script
|
||||
if (!m_loadedScripts.size())
|
||||
if (m_loadedScripts.empty())
|
||||
return true;
|
||||
|
||||
for (std::list<SpellScript*>::iterator itr = m_loadedScripts.begin(); itr != m_loadedScripts.end(); ++itr)
|
||||
|
||||
Reference in new issue
Block a user