Scripts: Fixed uninitialized variables, unreferenced parameters and virtual overrides

--HG--
branch : trunk
This commit is contained in:
Shauren committed 2010-12-14 16:24:59 +01:00
1 parent f4581f67b8
commit 314376e32c
18 files changed
+33 -28

No files matched your search

@@ -323,7 +323,7 @@ public:
nWeaver = 0;
}
void KilledUnit()
void KilledUnit(Unit* /*victim*/)
{
DoScriptText(RAND(SAY_SLAY_1,SAY_SLAY_2), me);
}
@@ -788,7 +788,7 @@ public:
{
}
void JustDied()
void JustDied(Unit* /*killer*/)
{
float x,y,z;
me->GetPosition(x,y,z);
@@ -436,7 +436,7 @@ public:
void SpawnTrigger()
{
uint8 iStart,iEnd;
uint8 iStart = 0, iEnd = 0;
switch (urand(0,1))
{
case 0:
@@ -447,9 +447,11 @@ public:
iStart = 38;
iEnd = 68;
break;
default:
break;
}
for(uint32 i = iStart; i < iEnd; ++i)
me->SummonCreature(CREATURE_TRIGGER,Location[i]);
for (uint32 i = iStart; i < iEnd; ++i)
me->SummonCreature(CREATURE_TRIGGER, Location[i]);
}
};
@@ -232,7 +232,7 @@ public:
}
// called by svala sorrowgrave to set guid of victim
void DoAction(uint32 /*action*/)
void DoAction(const int32 /*action*/)
{
if (pInstance)
if (Unit *pVictim = me->GetUnit(*me, pInstance->GetData64(DATA_SACRIFICED_PLAYER)))
@@ -2418,11 +2418,11 @@ public:
me->RestoreFaction();
}
void DoAction(const int32 iParam)
void DoAction(const int32 /*iParam*/)
{
me->StopMoving();
me->SetUInt32Value(UNIT_NPC_FLAGS,0);
if (Player* pPlayer = me->GetPlayer(*me,uiPlayerGUID))
me->SetUInt32Value(UNIT_NPC_FLAGS, 0);
if (Player* pPlayer = me->GetPlayer(*me, uiPlayerGUID))
{
me->SetInFront(pPlayer);
me->SendMovementFlagUpdate();
@@ -2431,7 +2431,7 @@ public:
uiEventPhase = 1;
}
void SetGUID(const uint64 &uiGuid, int32 iId)
void SetGUID(const uint64 &uiGuid, int32 /*iId*/)
{
uiPlayerGUID = uiGuid;
}
@@ -2546,7 +2546,7 @@ public:
return true;
}
bool OnGossipSelect(Player* pPlayer, Creature* pCreature, uint32 uiSender, uint32 uiAction)
bool OnGossipSelect(Player* pPlayer, Creature* pCreature, uint32 /*uiSender*/, uint32 uiAction)
{
pPlayer->PlayerTalkClass->ClearMenus();
@@ -419,12 +419,12 @@ public:
me->SummonCreature(uiEntry, afSummon[0], afSummon[1], afSummon[2], 0.0f, TEMPSUMMON_TIMED_DESPAWN_OUT_OF_COMBAT, 30*IN_MILLISECONDS);
}
void SummonedCreatureDies(Creature* pSummoned, Unit* pKiller)
void SummonedCreatureDies(Creature* pSummoned, Unit* /*pKiller*/)
{
uint32 uiEntry = 0;
// will eventually reset the event if something goes wrong
switch(pSummoned->GetEntry())
switch (pSummoned->GetEntry())
{
case NPC_FIRJUS: uiEntry = NPC_JLARBORN; break;
case NPC_JLARBORN: uiEntry = NPC_YOROS; break;