Core/Misc: ASSERT() cleanup
Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect.
This commit is contained in:
1 parent
c4342a7756
commit
4a7089b10a
4 files changed
+16
-7
No files matched your search
@@ -152,7 +152,8 @@ bool Group::Create(Player* leader)
|
||||
|
||||
Group::ConvertLeaderInstancesToGroup(leader, this, false);
|
||||
|
||||
ASSERT(AddMember(leader)); // If the leader can't be added to a new group because it appears full, something is clearly wrong.
|
||||
bool addMemberResult = AddMember(leader);
|
||||
ASSERT(addMemberResult); // If the leader can't be added to a new group because it appears full, something is clearly wrong.
|
||||
}
|
||||
else if (!AddMember(leader))
|
||||
return false;
|
||||
|
||||
Reference in new issue
Block a user