Core/Spells: dropped spell_bonus_data table and use the dbc internal data to calculate ap and sp bonus values

* some spells have a special formula in their tooltips, which need manual scripting via the CalcDamage and CalcHealing hooks respectively
This commit is contained in:
Ovahlord committed 2025-06-08 15:16:17 +02:00
1 parent 373dd1b6ac
commit 5c9ecf27e9
15 files changed
+182 -252

No files matched your search

-10
View File
@@ -142,7 +142,6 @@ public:
{ "smart_scripts", rbac::RBAC_PERM_COMMAND_RELOAD_SMART_SCRIPTS, true, &HandleReloadSmartScripts, "" },
{ "spell_required", rbac::RBAC_PERM_COMMAND_RELOAD_SPELL_REQUIRED, true, &HandleReloadSpellRequiredCommand, "" },
{ "spell_area", rbac::RBAC_PERM_COMMAND_RELOAD_SPELL_AREA, true, &HandleReloadSpellAreaCommand, "" },
{ "spell_bonus_data", rbac::RBAC_PERM_COMMAND_RELOAD_SPELL_BONUS_DATA, true, &HandleReloadSpellBonusesCommand, "" },
{ "spell_group", rbac::RBAC_PERM_COMMAND_RELOAD_SPELL_GROUP, true, &HandleReloadSpellGroupsCommand, "" },
{ "spell_learn_spell", rbac::RBAC_PERM_COMMAND_RELOAD_SPELL_LEARN_SPELL, true, &HandleReloadSpellLearnSpellCommand, "" },
{ "spell_loot_template", rbac::RBAC_PERM_COMMAND_RELOAD_SPELL_LOOT_TEMPLATE, true, &HandleReloadLootTemplatesSpellCommand, "" },
@@ -283,7 +282,6 @@ public:
HandleReloadSpellLearnSpellCommand(handler, "a");
HandleReloadSpellLinkedSpellCommand(handler, "a");
HandleReloadSpellProcsCommand(handler, "a");
HandleReloadSpellBonusesCommand(handler, "a");
HandleReloadSpellTargetPositionCommand(handler, "a");
HandleReloadSpellThreatsCommand(handler, "a");
HandleReloadSpellGroupStackRulesCommand(handler, "a");
@@ -854,14 +852,6 @@ public:
return true;
}
static bool HandleReloadSpellBonusesCommand(ChatHandler* handler, char const* /*args*/)
{
TC_LOG_INFO("misc", "Re-Loading Spell Bonus Data...");
sSpellMgr->LoadSpellBonuses();
handler->SendGlobalGMSysMessage("DB table `spell_bonus_data` (spell damage/healing coefficients) reloaded.");
return true;
}
static bool HandleReloadSpellTargetPositionCommand(ChatHandler* handler, char const* /*args*/)
{
TC_LOG_INFO("misc", "Re-Loading Spell target coordinates...");
+16 -1
View File
@@ -1863,6 +1863,20 @@ class spell_dk_strangulate : public SpellScript
OnEffectHitTarget.Register(&spell_dk_strangulate::HandleCreatureInterrupt, EFFECT_0, SPELL_EFFECT_APPLY_AURA);
}
};
// 45477 - Icy Touch
class spell_dk_icy_touch : public SpellScript
{
void CalculateDamage(Unit* /*victim*/, int32& /*damage*/, int32& flatMod, float& /*pctMod*/)
{
flatMod += GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK) * 0.2f;
}
void Register() override
{
CalcDamage.Register(&spell_dk_icy_touch::CalculateDamage);
}
};
}
void AddSC_deathknight_spell_scripts()
@@ -1901,6 +1915,7 @@ void AddSC_deathknight_spell_scripts()
RegisterSpellScript(spell_dk_ghoul_taunt);
RegisterSpellScript(spell_dk_howling_blast);
RegisterSpellScript(spell_dk_icebound_fortitude);
RegisterSpellScript(spell_dk_icy_touch);
RegisterSpellScript(spell_dk_improved_presence);
RegisterSpellScript(spell_dk_killing_machine);
RegisterSpellScript(spell_dk_necrotic_strike);
@@ -1920,4 +1935,4 @@ void AddSC_deathknight_spell_scripts()
RegisterSpellScript(spell_dk_unholy_command);
RegisterSpellScript(spell_dk_vampiric_blood);
RegisterSpellScript(spell_dk_will_of_the_necropolis);
}
}
+4 -8
View File
@@ -5108,18 +5108,14 @@ class spell_gen_wounded : public SpellScript
// 69041 - Rocket Barrage (Racial)
class spell_gen_rocket_barrage : public SpellScript
{
void HandleDamage(SpellEffIndex effIndex)
void CalculateDamage(Unit* /*victim*/, int32& /*damage*/, int32& flatMod, float& /*pctMod*/)
{
Unit* caster = GetCaster();
int32 basePoints = GetEffectValue() + caster->getLevel() * 2;
basePoints += caster->SpellBaseDamageBonusDone(GetSpellInfo()->GetSchoolMask()) * GetSpellInfo()->Effects[effIndex].BonusMultiplier;
basePoints += caster->GetTotalAttackPowerValue(caster->getClass() != CLASS_HUNTER ? BASE_ATTACK : RANGED_ATTACK) * GetSpellInfo()->BonusCoefficient;
SetEffectValue(basePoints);
flatMod += GetCaster()->getLevel() * 2;
}
void Register() override
{
OnEffectLaunchTarget.Register(&spell_gen_rocket_barrage::HandleDamage, EFFECT_0, SPELL_EFFECT_SCHOOL_DAMAGE);
CalcDamage.Register(&spell_gen_rocket_barrage::CalculateDamage);
}
};
@@ -5494,4 +5490,4 @@ void AddSC_generic_spell_scripts()
RegisterSpellScript(spell_gen_vehicle_control_link);
RegisterSpellScript(spell_gen_polymorph_cast_visual);
RegisterSpellScript(spell_gen_prevent_emotes);
}
}
+22 -1
View File
@@ -137,6 +137,20 @@ class spell_hun_ancient_hysteria : public SpellScript
}
};
// 3044 - Arcane Shot
class spell_hun_arcane_shot : public SpellScript
{
void CalculateDamage(Unit* /*victim*/, int32& /*damage*/, int32& flatMod, float& /*pctMod*/)
{
flatMod += GetCaster()->GetTotalAttackPowerValue(RANGED_ATTACK) * 0.0493f;
}
void Register() override
{
CalcDamage.Register(&spell_hun_arcane_shot::CalculateDamage);
}
};
// Universal helper to get the serpent sting aura of all variants of it (original and the procced versions of Serpent Spread)
static Aura* GetSerpentStingAura(Unit* target, ObjectGuid casterGUID)
{
@@ -655,6 +669,11 @@ class spell_hun_steady_shot : public SpellScript
return ValidateSpellInfo({ SPELL_HUNTER_STEADY_SHOT_FOCUS });
}
void CalculateDamage(Unit* /*victim*/, int32& /*damage*/, int32& flatMod, float& /*pctMod*/)
{
flatMod += GetCaster()->GetTotalAttackPowerValue(RANGED_ATTACK) * 0.021f;
}
void HandleLaunch(SpellEffIndex /*effIndex*/)
{
Unit* caster = GetCaster();
@@ -676,6 +695,7 @@ class spell_hun_steady_shot : public SpellScript
void Register() override
{
CalcDamage.Register(&spell_hun_steady_shot::CalculateDamage);
OnEffectLaunch.Register(&spell_hun_steady_shot::HandleLaunch, EFFECT_0, SPELL_EFFECT_NORMALIZED_WEAPON_DMG);
}
};
@@ -1444,6 +1464,7 @@ void AddSC_hunter_spell_scripts()
{
using namespace Spells::Hunter;
RegisterSpellScript(spell_hun_ancient_hysteria);
RegisterSpellScript(spell_hun_arcane_shot);
RegisterSpellScript(spell_hun_camouflage);
RegisterSpellScript(spell_hun_camouflage_duration);
RegisterSpellScript(spell_hun_camouflage_triggered);
@@ -1484,4 +1505,4 @@ void AddSC_hunter_spell_scripts()
RegisterSpellScript(spell_hun_tnt);
RegisterSpellScript(spell_hun_trap_launcher);
RegisterSpellScript(spell_hun_wild_quiver);
}
}
+33 -1
View File
@@ -1286,6 +1286,37 @@ class spell_rog_gouge : public AuraScript
}
};
// 16511 - Hemorrhage
class spell_rog_hemorrhage : public SpellScript
{
bool Load() override
{
return GetCaster()->IsPlayer();
}
void CalculateDamage(Unit* /*victim*/, int32& /*damage*/, int32& /*flatMod*/, float& pctMod)
{
for (WeaponAttackType attType : { BASE_ATTACK, OFF_ATTACK })
{
// Dealing additional 45% damage when a dagger is equipped
if (Item* item = GetCaster()->ToPlayer()->GetWeaponForAttack(attType, true))
{
if (item->GetTemplate()->GetSubClass() == ITEM_SUBCLASS_WEAPON_DAGGER)
{
pctMod *= 1.45f;
return;
}
}
}
}
void Register() override
{
CalcDamage.Register(&spell_rog_hemorrhage::CalculateDamage);
}
};
// -11327 - Vanish
class spell_rog_vanish : public AuraScript
{
@@ -1388,6 +1419,7 @@ void AddSC_rogue_spell_scripts()
RegisterSpellScript(spell_rog_eviscerate);
RegisterSpellScript(spell_rog_glyph_of_hemorrhage);
RegisterSpellScript(spell_rog_gouge);
RegisterSpellScript(spell_rog_hemorrhage);
RegisterSpellScript(spell_rog_improved_expose_armor);
new spell_rog_killing_spree();
RegisterSpellScript(spell_rog_main_gauche);
@@ -1410,4 +1442,4 @@ void AddSC_rogue_spell_scripts()
RegisterSpellScript(spell_rog_honor_among_thieves);
RegisterSpellScript(spell_rog_vanish);
RegisterSpellScript(spell_rogue_venomous_wounds);
}
}
+70 -64
View File
@@ -48,6 +48,7 @@ enum WarriorSpells
SPELL_WARRIOR_DEEP_WOUNDS_PERIODIC = 12721,
SPELL_WARRIOR_EXECUTE = 20647,
SPELL_WARRIOR_GLYPH_OF_EXECUTION = 58367,
SPELL_WARRIOR_IMPENDING_VICTORY = 80128,
SPELL_WARRIOR_INTERCEPT = 20252,
SPELL_WARRIOR_JUGGERNAUT_CRIT_BONUS_BUFF = 65156,
SPELL_WARRIOR_JUGGERNAUT_CRIT_BONUS_TALENT = 64976,
@@ -95,10 +96,9 @@ class spell_warr_bloodthirst : public SpellScript
return ValidateSpellInfo({ SPELL_WARRIOR_BLOODTHIRST });
}
void HandleDamage(SpellEffIndex /*effIndex*/)
void CalculateDamage(Unit* /*victim*/, int32& damage, int32& /*flatMod*/, float& /*pctMod*/)
{
if (Unit* caster = GetCaster())
SetEffectValue(CalculatePct(caster->GetTotalAttackPowerValue(BASE_ATTACK) * GetEffectValue(), 1));
damage = CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), damage);
}
void HandleBloodthirstHealEffect()
@@ -108,7 +108,7 @@ class spell_warr_bloodthirst : public SpellScript
void Register() override
{
OnEffectLaunchTarget.Register(&spell_warr_bloodthirst::HandleDamage, EFFECT_0, SPELL_EFFECT_SCHOOL_DAMAGE);
CalcDamage.Register(&spell_warr_bloodthirst::CalculateDamage);
AfterHit.Register(&spell_warr_bloodthirst::HandleBloodthirstHealEffect);
}
};
@@ -175,16 +175,17 @@ class spell_warr_charge : public SpellScript
};
/// Updated 4.3.4
// 12809 - Concussion Blow
class spell_warr_concussion_blow : public SpellScript
{
void HandleDummy(SpellEffIndex /*effIndex*/)
void CalculateDamage(Unit* victim, int32& damage, int32& flatMod, float& pctMod)
{
SetEffectValue(CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), GetSpellInfo()->Effects[EFFECT_2].CalcValue()));
damage = CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), GetSpellInfo()->Effects[EFFECT_2].CalcValue());
}
void Register() override
{
OnEffectLaunchTarget.Register(&spell_warr_concussion_blow::HandleDummy, EFFECT_1, SPELL_EFFECT_SCHOOL_DAMAGE);
CalcDamage.Register(&spell_warr_concussion_blow::CalculateDamage);
}
};
@@ -237,6 +238,7 @@ class spell_warr_deep_wounds : public AuraScript
};
/// Updated 4.3.4
// 5308 - Execute
class spell_warr_execute : public SpellScript
{
bool Validate(SpellInfo const* /*spellInfo*/) override
@@ -244,36 +246,50 @@ class spell_warr_execute : public SpellScript
return ValidateSpellInfo({ SPELL_WARRIOR_SUDDEN_DEATH });
}
void HandleEffect(SpellEffIndex /*effIndex*/)
// Formula: ${10+$AP*0.437*$m1/100} plus up to $m2 additional rage for up to ${10+$AP*0.437*$m1/100} extra damage
void CalculateDamage(Unit* /*victim*/, int32& damage, int32& /*flatMod*/, float& /*pctMod*/)
{
Unit* caster = GetCaster();
if (!GetHitUnit())
int apPct = GetSpellInfo()->Effects[EFFECT_0].CalcValue(caster);
damage = static_cast<int32>(10 + CalculatePct(caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.437, apPct));
int32 additionalRageCap = GetSpellInfo()->Effects[EFFECT_1].CalcValue(caster) * 10;
if (!additionalRageCap)
return;
// Formula taken from DBC: "${10+$AP*0.437*$m1/100}"
int32 bp = int32(10 + caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.437f * GetEffectValue() / 100.0f);
int32 additionalRage = std::min<int32>(caster->GetPower(POWER_RAGE) - GetSpell()->GetPowerCost(), additionalRageCap);
// Up to 20 additional Rage can be converted into damage
// Formula taken from DBC: "to ${$ap*0.874*$m1/100-1}"
int32 additionalRage = std::min<int32>(caster->GetPower(POWER_RAGE) - GetSpell()->GetPowerCost(), GetSpellInfo()->Effects[EFFECT_1].CalcValue() * 10);
if (additionalRage > 0)
bp += (additionalRage * (caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.874f * GetEffectValue() / 100.0f - 1) / 200);
// Based on the pct of extra rage consumed the damage will be increased
float extraRagePct = additionalRage / additionalRageCap;
int32 bonusDamage = std::max<int32>(0, CalculatePct(caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.874f, apPct) - 1);
SetEffectValue(bp);
damage += bonusDamage * extraRagePct;
_additionalRageConsumed = additionalRage;
}
void ConsumeAdditionalRage()
{
if (_additionalRageConsumed == 0)
return;
int32 preservedRage = 0;
// Sudden Death bonus (keep 5/10 Rage after using Execute)
if (Aura const* aura = caster->GetAuraOfRankedSpell(SPELL_WARRIOR_SUDDEN_DEATH, caster->GetGUID()))
int32 preservedRage = 0;
if (Aura const* aura = GetCaster()->GetAuraOfRankedSpell(SPELL_WARRIOR_SUDDEN_DEATH, GetCaster()->GetGUID()))
if (AuraEffect const* suddenDeath = aura->GetEffect(EFFECT_0))
preservedRage = std::min<int32>(suddenDeath->GetAmount() * 10, GetSpell()->GetPowerCost() + additionalRage);
preservedRage = std::min<int32>(suddenDeath->GetAmount() * 10, GetSpell()->GetPowerCost() + _additionalRageConsumed);
caster->ModifyPower(POWER_RAGE, -(additionalRage - preservedRage));
GetCaster()->ModifyPower(POWER_RAGE, -(_additionalRageConsumed - preservedRage));
}
void Register() override
{
OnEffectLaunchTarget.Register(&spell_warr_execute::HandleEffect, EFFECT_0, SPELL_EFFECT_SCHOOL_DAMAGE);
CalcDamage.Register(&spell_warr_execute::CalculateDamage);
AfterCast.Register(&spell_warr_execute::ConsumeAdditionalRage);
}
private:
int32 _additionalRageConsumed = 0;
};
// 58387 - Glyph of Sunder Armor
@@ -479,6 +495,7 @@ class spell_warr_shattering_throw : public SpellScript
};
/// Updated 4.3.4
// 1464 - Slam
class spell_warr_slam : public SpellScript
{
bool Validate(SpellInfo const* /*spellInfo*/) override
@@ -535,27 +552,21 @@ class spell_warr_slam_triggered : public SpellScript
_affectedByBloodsurge = GetCaster()->GetAuraEffect(SPELL_AURA_ADD_PCT_MODIFIER, SPELLFAMILY_WARRIOR, 0x0, 0x1000000, 0x0, GetCaster()->GetGUID()) != nullptr;
}
void HandleBonusDamage(SpellEffIndex /*effIndex*/)
void CalculateDamage(Unit* /*victim*/, int32& /*damage*/, int32& /*flatMod*/, float& pctMod)
{
Unit* caster = GetCaster();
if (!caster)
// Bloodsurge damage bonus
if (!_affectedByBloodsurge)
return;
int32 basePoints = GetEffectValue();
// Bloodsurge damage bonus
if (_affectedByBloodsurge)
if (Aura const* aura = caster->GetAuraOfRankedSpell(SPELL_WARRIOR_BLOODSURGE_R1))
if (AuraEffect const* effect = aura->GetEffect(EFFECT_0))
AddPct(basePoints, effect->GetAmount());
SetEffectValue(basePoints);
if (Aura const* aura = GetCaster()->GetAuraOfRankedSpell(SPELL_WARRIOR_BLOODSURGE_R1))
if (AuraEffect const* effect = aura->GetEffect(EFFECT_0))
AddPct(pctMod, effect->GetAmount());
}
void Register() override
{
BeforeCast.Register(&spell_warr_slam_triggered::HandleBeforeCast);
OnEffectLaunchTarget.Register(&spell_warr_slam_triggered::HandleBonusDamage, EFFECT_1, SPELL_EFFECT_WEAPON_PERCENT_DAMAGE);
CalcDamage.Register(&spell_warr_slam_triggered::CalculateDamage);
}
private:
bool _affectedByBloodsurge = false;
@@ -688,7 +699,7 @@ private:
// -46951 - Sword and Board
class spell_warr_sword_and_board : public AuraScript
{private:
{
bool Validate(SpellInfo const* /*spellInfo*/) override
{
return ValidateSpellInfo({ SPELL_WARRIOR_SHIELD_SLAM });
@@ -719,39 +730,33 @@ class spell_warr_victory_rush : public SpellScript
});
}
void HandleDamage(SpellEffIndex /*effIndex*/)
// ${$AP*$m1/100}
void CalculateDamage(Unit* /*victim*/, int32& damage, int32& /*flatMod*/, float& /*pctMod*/)
{
SetEffectValue(CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), GetSpellInfo()->Effects[EFFECT_0].CalcValue()));
damage = CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), damage);
}
void HandleImpendingVictoryHeal(SpellEffIndex effIndex)
void CalculateHeal(Unit* /*victim*/, int32& heal, int32& /*flatMod*/, float& /*pctMod*/)
{
if (Unit* caster = GetCaster())
{
// Impending Victory also allows players to cast Victory Rush but with 5% healing effect only
if (caster->HasAura(SPELL_WARRIOR_VICTORIOUS_IMPENDING_VICTORY))
{
int32 damage = 5;
Unit* caster = GetCaster();
// Glyph: Victory Rush
if (Player* modOwner = caster->GetSpellModOwner())
modOwner->ApplySpellMod(GetSpellInfo(), SpellModOp::PointsIndex2, damage);
SetEffectValue(damage);
}
else
SetEffectValue(GetSpellInfo()->Effects[effIndex].CalcValue());
caster->RemoveAurasDueToSpell(SPELL_WARRIOR_VICTORIOUS);
caster->RemoveAurasDueToSpell(SPELL_WARRIOR_VICTORIOUS_IMPENDING_VICTORY);
}
// Impending Victory has a chance to allow casting Victory rush but it only heals for $s1% of our health
if (caster->HasAura(SPELL_WARRIOR_VICTORIOUS_IMPENDING_VICTORY, caster->GetGUID()))
if (AuraEffect const* impendingVictoryEff = caster->GetAuraEffectOfRankedSpell(SPELL_WARRIOR_VICTORIOUS_IMPENDING_VICTORY, EFFECT_0, caster->GetGUID()))
heal = caster->CountPctFromMaxHealth(impendingVictoryEff->GetAmount());
}
void RemoveVictorious()
{
GetCaster()->RemoveAurasDueToSpell(SPELL_WARRIOR_VICTORIOUS);
GetCaster()->RemoveAurasDueToSpell(SPELL_WARRIOR_VICTORIOUS_IMPENDING_VICTORY);
}
void Register() override
{
OnEffectLaunchTarget.Register(&spell_warr_victory_rush::HandleDamage, EFFECT_0, SPELL_EFFECT_SCHOOL_DAMAGE);
OnEffectHitTarget.Register(&spell_warr_victory_rush::HandleImpendingVictoryHeal, EFFECT_2, SPELL_EFFECT_HEAL_PCT);
CalcDamage.Register(&spell_warr_victory_rush::CalculateDamage);
CalcHealing.Register(&spell_warr_victory_rush::CalculateHeal);
AfterCast.Register(&spell_warr_victory_rush::RemoveVictorious);
}
};
@@ -889,7 +894,7 @@ class spell_warr_thunder_clap : public SpellScript
OnEffectHitTarget.Register(&spell_warr_thunder_clap::HandleHit, EFFECT_0, SPELL_EFFECT_SCHOOL_DAMAGE);
}
private:
bool _allowRendSpread;
bool _allowRendSpread = false;
};
class spell_warr_shield_specialization : public AuraScript
@@ -932,17 +937,18 @@ class spell_warr_blood_craze : public AuraScript
// 46968 - Shockwave
class spell_warr_shockwave : public SpellScript
{
void HandleDamage(SpellEffIndex /*effIndex*/)
void CalculateDamage(Unit* /*victim*/, int32& damage, int32& /*flatMod*/, float& /*pctMod*/)
{
SetEffectValue(CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), GetSpellInfo()->Effects[EFFECT_2].CalcValue()));
damage = CalculatePct(GetCaster()->GetTotalAttackPowerValue(BASE_ATTACK), GetSpellInfo()->Effects[EFFECT_2].CalcValue(GetCaster()));
}
void Register() override
{
OnEffectLaunchTarget.Register(&spell_warr_shockwave::HandleDamage, EFFECT_1, SPELL_EFFECT_SCHOOL_DAMAGE);
CalcDamage.Register(&spell_warr_shockwave::CalculateDamage);
}
};
// 20243 - Devastate
class spell_warr_devastate : public SpellScript
{
bool Validate(SpellInfo const* /*spellInfo*/) override
@@ -1133,4 +1139,4 @@ void AddSC_warrior_spell_scripts()
RegisterSpellScript(spell_warr_vigilance);
RegisterSpellScript(spell_warr_vigilance_trigger);
RegisterSpellScript(spell_warr_whirlwind);
}
}