Fix AdventureBot travel recovery, area eligibility and safe build logout

tests/clientless/test_transport.py

@@ -128,7 +128,7 @@ bool Safe(std::string const& key){return !key.empty();}
 namespace Trinity {bool IsValidMapCoord(float,float,float,float=0){return true;}}
 '''
 helpers = '\n'.join(function(source, marker) for marker in [
-    '    float Distance(', '    bool SameService(', '    bool LoadNode(', '    Position WorldPoint(', '    float PathLength('
+    '    char const* PhaseName(', '    float Distance(', '    bool SameService(', '    bool LoadNode(', '    Position WorldPoint(', '    float PathLength('
 ])
 methods = '\n'.join(function(source, marker) for marker in [
     'bool ClientlessTransportMgr::ResumePassenger(', 'bool ClientlessTransportMgr::SelectResumedDock(',
@@ -190,7 +190,7 @@ int main(){
  go.x=50;p.x=51;mgr.Cancel(26);run(mgr,p,abort);assert(abort.Status.Phase==Phase::Riding&&p.transport);
  go.x=5;p.x=6;run(mgr,p,abort);assert(abort.Status.Phase==Phase::Failed&&abort.Status.Cancelled&&!p.transport&&p.x==0);
  // A timeout aboard never removes the passenger over sea/in midair.
- assert(mgr.Start(&p,"A","B",error));auto&timeout=mgr._rides.at(26);run(mgr,p,timeout);assert(p.transport);timeout.Elapsed=1800001;run(mgr,p,timeout,1);assert(timeout.Status.Phase==Phase::Failed&&p.transport);go.base.RemovePassenger(&p);
+ assert(mgr.Start(&p,"A","B",error));auto&timeout=mgr._rides.at(26);run(mgr,p,timeout);assert(p.transport);timeout.Elapsed=1800001;run(mgr,p,timeout,1);assert(timeout.Status.Phase==Phase::Riding&&timeout.Abort&&timeout.RetryDelay==3000&&p.transport);go.base.RemovePassenger(&p);
  // Departure during a boarding transition keeps the Passenger until safe recovery.
  p.x=0;go.x=5;go.state.Stopped=true;assert(mgr.Start(&p,"A","B",error));auto&late=mgr._rides.at(26);
  for(int i=0;i<10&&!p.transport;i++)mgr.UpdateRide(&p,late,100);
@@ -280,6 +280,16 @@ int main(){
  copy1.base.RemovePassenger(&orphan);orphan.map=0;orphan.object=&vessel;vessel.x=100;
  vessel.base.AddPassenger(&orphan);orphan.x=101;orphan.m_movementInfo.transport.pos.x=1;
  run(resumed,orphan,resumed._rides.at(26));assert(!orphan.transport&&orphan.map==0&&orphan.x==104);
+ // Lost attachment during both boarding and disembarkation uses recorded departure rescue.
+ travel.path=false;travel.present=false;
+ for(auto phase:{Phase::Boarding,Phase::Leaving}){
+  Player fallen;fallen.object=&vessel;fallen.x=50;fallen.falling=true;
+  auto ride=adopted;ride.From=stop("A",5,0);ride.To=stop("B",100,104);
+  ride.Status.Phase=phase;ride.Status.Recovering=false;ride.Abort=false;ride.Elapsed=0;ride.RetryDelay=0;
+  ride.Point=phase==Phase::Boarding?3:2;ride.Moving=false;
+  resumed.UpdateRide(&fallen,ride,100);
+  assert(ride.Status.Recovering&&fallen.teleports==1&&fallen.x==0);
+ }
  std::cout<<"Transport dock, frame, recorder, cross-map copy and ride regressions passed\n";
 }
 '''
@@ -287,5 +297,5 @@ with tempfile.TemporaryDirectory(prefix='vcore-transport-test-') as directory:
     path = Path(directory)
     cpp = path / 'transport.cpp'
     cpp.write_text(preamble + position + '\n' + offset + world + header + helpers + stubs + methods + animated + tests)
-    subprocess.run(['g++', '-std=c++17', '-O0', '-g', '-Wall', '-Wextra', '-Wno-unused-parameter', str(cpp), '-o', str(path / 'test')], check=True)
+    subprocess.run(['g++','-include',str(Path(__file__).with_name('telemetry_test_stub.h')), '-std=c++17', '-O0', '-g', '-Wall', '-Wextra', '-Wno-unused-parameter', str(cpp), '-o', str(path / 'test')], check=True)
     subprocess.run([str(path / 'test')], check=True)