Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

Core/Spells: skip unnecessary coefficient scaling lookups when no coefficient is provided

Browse Source
This commit is contained in:
Ovahlord committed 2022-01-05 22:32:05 +01:00
1 parent 66a49b77f6
commit 7dc29ee9c1
1 file changed
+7 -3
Download Patch File Download Diff File Expand all files Collapse all files
src/server/game/Entities/Unit/Unit.cpp
+7 -3
View File
@@ -6717,8 +6717,11 @@ uint32 Unit::SpellDamageBonusDone(Unit* victim, SpellInfo const* spellProto, uin
return uint32(std::max(pdamage * DoneTotalMod, 0.0f));
}
spellPowerCoeff = spellProto->CalculateScaledCoefficient(this, spellPowerCoeff);
attackPowerCoeff = spellProto->CalculateScaledCoefficient(this, attackPowerCoeff);
if (spellPowerCoeff > 0.f)
spellPowerCoeff = spellProto->CalculateScaledCoefficient(this, spellPowerCoeff);
if (attackPowerCoeff > 0.f)
attackPowerCoeff = spellProto->CalculateScaledCoefficient(this, attackPowerCoeff);
if (attackPowerCoeff > 0.f)
{
@@ -7975,7 +7978,8 @@ uint32 Unit::MeleeDamageBonusDone(Unit* victim, uint32 pdamage, WeaponAttackType
if (SpellBonusEntry const* bonus = sSpellMgr->GetSpellBonusData(spellProto->Id))
attackPowerCoeff = bonus->ap_bonus;
attackPowerCoeff = spellProto->CalculateScaledCoefficient(this, attackPowerCoeff);
if (attackPowerCoeff > 0.f)
attackPowerCoeff = spellProto->CalculateScaledCoefficient(this, attackPowerCoeff);
if (attackPowerCoeff > 0.f)
DoneFlatBenefit += attackPowerCoeff * GetTotalAttackPowerValue(attType);