From 8733f6fafaa1fbe2a3f5e2339aff7c8a33de622b Mon Sep 17 00:00:00 2001 From: Shauren Date: Fri, 17 Jun 2022 15:20:55 +0200 Subject: [PATCH] Core/Utils: Added helper function to make creating unique_ptr with custom deleters more convenient # Conflicts: # src/server/game/World/World.cpp --- src/common/Utilities/Memory.h | 49 +++++++++++++++++++ src/server/game/World/World.cpp | 3 +- .../{Memory.h => DetourMemoryFunctions.h} | 6 +-- 3 files changed, 53 insertions(+), 5 deletions(-) create mode 100644 src/common/Utilities/Memory.h rename src/server/shared/{Memory.h => DetourMemoryFunctions.h} (64%) diff --git a/src/common/Utilities/Memory.h b/src/common/Utilities/Memory.h new file mode 100644 index 0000000000..8d67e80210 --- /dev/null +++ b/src/common/Utilities/Memory.h @@ -0,0 +1,49 @@ +/* + * This file is part of the TrinityCore Project. See AUTHORS file for Copyright information + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or (at your + * option) any later version. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along + * with this program. If not, see . + */ + +#ifndef TRINITY_MEMORY_H +#define TRINITY_MEMORY_H + +#include + +namespace Trinity +{ +namespace Impl +{ +template +struct unique_ptr_deleter +{ + using pointer = T; + unique_ptr_deleter(Del deleter) : _deleter(std::move(deleter)) { } + + void operator()(pointer ptr) const { _deleter(ptr); } + +private: + Del _deleter; +}; +} + +template +auto make_unique_ptr_with_deleter(T ptr, Del&& deleter) +{ + using Deleter_t = Impl::unique_ptr_deleter; + + return std::unique_ptr(ptr, Deleter_t(std::forward(deleter))); +} +} + +#endif // TRINITY_MEMORY_H diff --git a/src/server/game/World/World.cpp b/src/server/game/World/World.cpp index ba7918261b..c3041588d7 100644 --- a/src/server/game/World/World.cpp +++ b/src/server/game/World/World.cpp @@ -41,7 +41,7 @@ #include "DatabaseEnv.h" #include "DBCStores.h" #include "DB2Stores.h" -#include "DBCStores.h" +#include "DetourMemoryFunctions.h" #include "DisableMgr.h" #include "GameEventMgr.h" #include "GameObjectModel.h" @@ -60,7 +60,6 @@ #include "LootMgr.h" #include "M2Stores.h" #include "MapManager.h" -#include "Memory.h" #include "Metric.h" #include "MMapFactory.h" #include "ObjectAccessor.h" diff --git a/src/server/shared/Memory.h b/src/server/shared/DetourMemoryFunctions.h similarity index 64% rename from src/server/shared/Memory.h rename to src/server/shared/DetourMemoryFunctions.h index faa48a7225..0c33a2fa5f 100644 --- a/src/server/shared/Memory.h +++ b/src/server/shared/DetourMemoryFunctions.h @@ -1,7 +1,7 @@ -#ifndef _MEMORY_H -#define _MEMORY_H +#ifndef TRINITY_DETOUR_MEMORY_FUNCTIONS_H +#define TRINITY_DETOUR_MEMORY_FUNCTIONS_H #include "DetourAlloc.h" @@ -16,4 +16,4 @@ inline void dtCustomFree(void* ptr) delete [] (unsigned char*)ptr; } -#endif +#endif // TRINITY_DETOUR_MEMORY_FUNCTIONS_H