Few small optimizations here and there
This commit is contained in:
1 parent
0f9c7106ce
commit
8bb777ef5c
35 files changed
+366
-373
No files matched your search
@@ -123,7 +123,7 @@ WorldSession::WorldSession(uint32 id, std::string&& name, uint32 battlenetAccoun
|
||||
m_sessionDbLocaleIndex(locale),
|
||||
m_latency(0),
|
||||
m_clientTimeDelay(0),
|
||||
m_TutorialsChanged(false),
|
||||
m_TutorialsChanged(TUTORIALS_FLAG_NONE),
|
||||
_filterAddonMessages(false),
|
||||
recruiterId(recruiter),
|
||||
isRecruiter(isARecruiter),
|
||||
@@ -795,10 +795,13 @@ void WorldSession::LoadTutorialsData(PreparedQueryResult result)
|
||||
memset(m_Tutorials, 0, sizeof(uint32) * MAX_ACCOUNT_TUTORIAL_VALUES);
|
||||
|
||||
if (result)
|
||||
{
|
||||
for (uint8 i = 0; i < MAX_ACCOUNT_TUTORIAL_VALUES; ++i)
|
||||
m_Tutorials[i] = (*result)[i].GetUInt32();
|
||||
m_TutorialsChanged |= TUTORIALS_FLAG_LOADED_FROM_DB;
|
||||
}
|
||||
|
||||
m_TutorialsChanged = false;
|
||||
m_TutorialsChanged &= ~TUTORIALS_FLAG_CHANGED;
|
||||
}
|
||||
|
||||
void WorldSession::SendTutorialsData()
|
||||
@@ -811,20 +814,17 @@ void WorldSession::SendTutorialsData()
|
||||
|
||||
void WorldSession::SaveTutorialsData(SQLTransaction &trans)
|
||||
{
|
||||
if (!m_TutorialsChanged)
|
||||
if (!(m_TutorialsChanged & TUTORIALS_FLAG_CHANGED))
|
||||
return;
|
||||
|
||||
PreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_SEL_HAS_TUTORIALS);
|
||||
stmt->setUInt32(0, GetAccountId());
|
||||
bool hasTutorials = bool(CharacterDatabase.Query(stmt));
|
||||
// Modify data in DB
|
||||
stmt = CharacterDatabase.GetPreparedStatement(hasTutorials ? CHAR_UPD_TUTORIALS : CHAR_INS_TUTORIALS);
|
||||
bool const hasTutorialsInDB = (m_TutorialsChanged & TUTORIALS_FLAG_LOADED_FROM_DB) != 0;
|
||||
PreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(hasTutorialsInDB ? CHAR_UPD_TUTORIALS : CHAR_INS_TUTORIALS);
|
||||
for (uint8 i = 0; i < MAX_ACCOUNT_TUTORIAL_VALUES; ++i)
|
||||
stmt->setUInt32(i, m_Tutorials[i]);
|
||||
stmt->setUInt32(MAX_ACCOUNT_TUTORIAL_VALUES, GetAccountId());
|
||||
trans->Append(stmt);
|
||||
|
||||
m_TutorialsChanged = false;
|
||||
m_TutorialsChanged &= ~TUTORIALS_FLAG_CHANGED;
|
||||
}
|
||||
|
||||
void WorldSession::ReadAddonsInfo(ByteBuffer &data)
|
||||
|
||||
@@ -164,6 +164,13 @@ enum DeclinedNameResult
|
||||
DECLINED_NAMES_RESULT_ERROR = 1
|
||||
};
|
||||
|
||||
enum TutorialsFlag : uint8
|
||||
{
|
||||
TUTORIALS_FLAG_NONE = 0x00,
|
||||
TUTORIALS_FLAG_CHANGED = 0x01,
|
||||
TUTORIALS_FLAG_LOADED_FROM_DB = 0x02
|
||||
};
|
||||
|
||||
//class to deal with packet processing
|
||||
//allows to determine if next packet is safe to be processed
|
||||
class PacketFilter
|
||||
@@ -395,7 +402,7 @@ class TC_GAME_API WorldSession
|
||||
if (m_Tutorials[index] != value)
|
||||
{
|
||||
m_Tutorials[index] = value;
|
||||
m_TutorialsChanged = true;
|
||||
m_TutorialsChanged |= TUTORIALS_FLAG_CHANGED;
|
||||
}
|
||||
}
|
||||
//used with item_page table
|
||||
@@ -568,10 +575,8 @@ class TC_GAME_API WorldSession
|
||||
// Social
|
||||
void HandleContactListOpcode(WorldPacket& recvPacket);
|
||||
void HandleAddFriendOpcode(WorldPacket& recvPacket);
|
||||
void HandleAddFriendOpcodeCallback(std::string const& friendNote, PreparedQueryResult result);
|
||||
void HandleDelFriendOpcode(WorldPacket& recvPacket);
|
||||
void HandleAddIgnoreOpcode(WorldPacket& recvPacket);
|
||||
void HandleAddIgnoreOpcodeCallback(PreparedQueryResult result);
|
||||
void HandleDelIgnoreOpcode(WorldPacket& recvPacket);
|
||||
void HandleSetContactNotesOpcode(WorldPacket& recvPacket);
|
||||
void HandleBugOpcode(WorldPacket& recvPacket);
|
||||
@@ -783,6 +788,7 @@ class TC_GAME_API WorldSession
|
||||
|
||||
void HandleUseItemOpcode(WorldPacket& recvPacket);
|
||||
void HandleOpenItemOpcode(WorldPacket& recvPacket);
|
||||
void HandleOpenWrappedItemCallback(uint16 pos, ObjectGuid itemGuid, PreparedQueryResult result);
|
||||
void HandleCastSpellOpcode(WorldPacket& recvPacket);
|
||||
void HandleCancelCastOpcode(WorldPacket& recvPacket);
|
||||
void HandleCancelAuraOpcode(WorldPacket& recvPacket);
|
||||
@@ -1073,6 +1079,9 @@ class TC_GAME_API WorldSession
|
||||
void SendStreamingMovie();
|
||||
int32 HandleEnableNagleAlgorithm();
|
||||
|
||||
public:
|
||||
QueryCallbackProcessor& GetQueryProcessor() { return _queryProcessor; }
|
||||
|
||||
// Compact Unit Frames (4.x)
|
||||
void HandleSaveCUFProfiles(WorldPacket& recvPacket);
|
||||
void SendLoadCUFProfiles();
|
||||
@@ -1165,7 +1174,7 @@ class TC_GAME_API WorldSession
|
||||
std::atomic<uint32> m_clientTimeDelay;
|
||||
AccountData m_accountData[NUM_ACCOUNT_DATA_TYPES];
|
||||
uint32 m_Tutorials[MAX_ACCOUNT_TUTORIAL_VALUES];
|
||||
bool m_TutorialsChanged;
|
||||
uint8 m_TutorialsChanged;
|
||||
AddonsList m_addonsList;
|
||||
std::vector<std::string> _registeredAddonPrefixes;
|
||||
bool _filterAddonMessages;
|
||||
|
||||
Reference in new issue
Block a user