Core: Fix many "errors"/warnings and coding style (2)
Scripts; also reverted a change to AuthSocket Errors were found using Cppcheck, open-source static analysis tool
This commit is contained in:
1 parent
5f1977cb1d
commit
abbb896cfb
16 files changed
+70
-93
No files matched your search
@@ -278,6 +278,9 @@ class achievement_tilted : public AchievementCriteriaScript
|
||||
|
||||
bool OnCheck(Player* player, Unit* /*target*/)
|
||||
{
|
||||
if (!player)
|
||||
return false;
|
||||
|
||||
bool checkArea = player->GetAreaId() == AREA_ARGENT_TOURNAMENT_FIELDS ||
|
||||
player->GetAreaId() == AREA_RING_OF_ASPIRANTS ||
|
||||
player->GetAreaId() == AREA_RING_OF_ARGENT_VALIANTS ||
|
||||
@@ -285,7 +288,7 @@ class achievement_tilted : public AchievementCriteriaScript
|
||||
player->GetAreaId() == AREA_RING_OF_HORDE_VALIANTS ||
|
||||
player->GetAreaId() == AREA_RING_OF_CHAMPIONS;
|
||||
|
||||
return player && checkArea && player->duel && player->duel->isMounted;
|
||||
return checkArea && player->duel && player->duel->isMounted;
|
||||
}
|
||||
};
|
||||
|
||||
|
||||
Reference in new issue
Block a user