*Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..

*Proper Maexxna Web Spray locations (old locations sent players flying into the air)

--HG--
branch : trunk
This commit is contained in:
maximius committed 2009-11-01 17:53:07 -08:00
1 parent 2b2b2a1d0e
commit b257a28fa9
34 files changed
+1088 -1120

No files matched your search

+6 -6
View File
@@ -444,14 +444,14 @@ CREATE TABLE `character_aura` (
`guid` int(11) unsigned NOT NULL default '0' COMMENT 'Global Unique Identifier',
`caster_guid` bigint(20) unsigned NOT NULL default '0' COMMENT 'Full Global Unique Identifier',
`spell` int(11) unsigned NOT NULL default '0',
`effect_mask` int(11) unsigned NOT NULL default '0',
`stackcount` int(11) NOT NULL default '1',
`effect_mask` tinyint(3) unsigned NOT NULL default '0',
`stackcount` tinyint(3) unsigned NOT NULL default '1',
`amount0` int(11) NOT NULL default '0',
`amount1` int(11) NOT NULL default '0',
`amount2` int(11) NOT NULL default '0',
`maxduration` int(11) NOT NULL default '0',
`remaintime` int(11) NOT NULL default '0',
`remaincharges` int(11) NOT NULL default '0',
`remaincharges` tinyint(3) unsigned NOT NULL default '0',
PRIMARY KEY (`guid`,`spell`,`effect_mask`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 ROW_FORMAT=DYNAMIC COMMENT='Player System';
@@ -1492,14 +1492,14 @@ CREATE TABLE `pet_aura` (
`guid` int(11) unsigned NOT NULL default '0' COMMENT 'Global Unique Identifier',
`caster_guid` bigint(20) unsigned NOT NULL default '0' COMMENT 'Full Global Unique Identifier',
`spell` int(11) unsigned NOT NULL default '0',
`effect_mask` int(11) unsigned NOT NULL default '0',
`stackcount` int(11) NOT NULL default '1',
`effect_mask` tinyint(3) unsigned NOT NULL default '0',
`stackcount` tinyint(3) unsigned NOT NULL default '1',
`amount0` int(11) NOT NULL default '0',
`amount1` int(11) NOT NULL default '0',
`amount2` int(11) NOT NULL default '0',
`maxduration` int(11) NOT NULL default '0',
`remaintime` int(11) NOT NULL default '0',
`remaincharges` int(11) NOT NULL default '0',
`remaincharges` tinyint(3) unsigned NOT NULL default '0',
PRIMARY KEY (`guid`,`spell`,`effect_mask`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 ROW_FORMAT=DYNAMIC COMMENT='Pet System';
+8
View File
@@ -0,0 +1,8 @@
ALTER TABLE `character_aura` MODIFY COLUMN `effect_mask` TINYINT(3) UNSIGNED NOT NULL DEFAULT 0,
MODIFY COLUMN `stackcount` TINYINT(3) UNSIGNED NOT NULL DEFAULT 1,
MODIFY COLUMN `remaincharges` TINYINT(3) UNSIGNED NOT NULL DEFAULT 0;
ALTER TABLE `pet_aura` MODIFY COLUMN `effect_mask` TINYINT(3) UNSIGNED NOT NULL DEFAULT 0,
MODIFY COLUMN `stackcount` TINYINT(3) UNSIGNED NOT NULL DEFAULT 1,
MODIFY COLUMN `remaincharges` TINYINT(3) UNSIGNED NOT NULL DEFAULT 0;
+3
View File
@@ -0,0 +1,3 @@
-- the (4) in TINYINT(4) is kind of useless here, but whatever. This column should be unsigned.
ALTER TABLE `exploration_basexp` MODIFY COLUMN `level` TINYINT(4) UNSIGNED NOT NULL DEFAULT 0;
+1 -1
View File
@@ -694,7 +694,7 @@ DROP TABLE IF EXISTS `exploration_basexp`;
SET @saved_cs_client = @@character_set_client;
SET character_set_client = utf8;
CREATE TABLE `exploration_basexp` (
`level` tinyint(4) NOT NULL default '0',
`level` tinyint(4) unsigned NOT NULL default '0',
`basexp` mediumint(9) NOT NULL default '0',
PRIMARY KEY (`level`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8 ROW_FORMAT=FIXED COMMENT='Exploration System';