diff --git a/src/server/game/Instances/InstanceSaveMgr.cpp b/src/server/game/Instances/InstanceSaveMgr.cpp index a9ed04a805..f469c91d7a 100644 --- a/src/server/game/Instances/InstanceSaveMgr.cpp +++ b/src/server/game/Instances/InstanceSaveMgr.cpp @@ -598,7 +598,7 @@ void InstanceSaveManager::_ResetInstance(uint32 mapid, uint32 instanceId) { TC_LOG_DEBUG("maps", "InstanceSaveMgr::_ResetInstance %u, %u", mapid, instanceId); Map const* map = sMapMgr->CreateBaseMap(mapid); - if (!map->Instanceable()) + if (!map->IsDungeon()) return; InstanceSaveHashMap::iterator itr = m_instanceSaveById.find(instanceId); @@ -609,11 +609,9 @@ void InstanceSaveManager::_ResetInstance(uint32 mapid, uint32 instanceId) Map* iMap = ((MapInstanced*)map)->FindInstanceMap(instanceId); - if (iMap && iMap->IsDungeon()) - ((InstanceMap*)iMap)->Reset(INSTANCE_RESET_RESPAWN_DELAY); - if (iMap) { + ((InstanceMap*)iMap)->Reset(INSTANCE_RESET_RESPAWN_DELAY); iMap->DeleteRespawnTimes(); iMap->DeleteCorpseData(); } diff --git a/src/server/game/Maps/MapInstanced.cpp b/src/server/game/Maps/MapInstanced.cpp index 4c6f14e25b..129cc2d58b 100644 --- a/src/server/game/Maps/MapInstanced.cpp +++ b/src/server/game/Maps/MapInstanced.cpp @@ -138,7 +138,7 @@ Map* MapInstanced::CreateInstanceForPlayer(uint32 mapId, Player* player, uint32 } } } - else + else if (IsDungeon()) { InstancePlayerBind* pBind = player->GetBoundInstance(GetId(), player->GetDifficulty(IsRaid())); InstanceSave* pSave = pBind ? pBind->save : nullptr; diff --git a/src/server/game/Maps/MapManager.cpp b/src/server/game/Maps/MapManager.cpp index 84a393a728..0285d8c8da 100644 --- a/src/server/game/Maps/MapManager.cpp +++ b/src/server/game/Maps/MapManager.cpp @@ -293,11 +293,10 @@ uint32 MapManager::GetNumInstances() for (MapMapType::iterator itr = i_maps.begin(); itr != i_maps.end(); ++itr) { Map* map = itr->second; - if (!map->Instanceable()) + if (!map->IsDungeon()) continue; MapInstanced::InstancedMaps &maps = ((MapInstanced*)map)->GetInstancedMaps(); - for (MapInstanced::InstancedMaps::iterator mitr = maps.begin(); mitr != maps.end(); ++mitr) - if (mitr->second->IsDungeon()) ret++; + ret += maps.size(); } return ret; } @@ -310,12 +309,11 @@ uint32 MapManager::GetNumPlayersInInstances() for (MapMapType::iterator itr = i_maps.begin(); itr != i_maps.end(); ++itr) { Map* map = itr->second; - if (!map->Instanceable()) + if (!map->IsDungeon()) continue; MapInstanced::InstancedMaps &maps = ((MapInstanced*)map)->GetInstancedMaps(); for (MapInstanced::InstancedMaps::iterator mitr = maps.begin(); mitr != maps.end(); ++mitr) - if (mitr->second->IsDungeon()) - ret += ((InstanceMap*)mitr->second)->GetPlayers().getSize(); + ret += mitr->second->GetPlayers().getSize(); } return ret; } diff --git a/src/server/scripts/Commands/cs_go.cpp b/src/server/scripts/Commands/cs_go.cpp index 0a3f6a4a5a..d935a8e6e4 100644 --- a/src/server/scripts/Commands/cs_go.cpp +++ b/src/server/scripts/Commands/cs_go.cpp @@ -320,7 +320,7 @@ public: std::shared_ptr terrain = sTerrainMgr.LoadTerrain(zoneEntry->ContinentID); MapEntry const* mapEntry = sMapStore.LookupEntry(terrain->GetId()); - if (!mapEntry || !mapEntry->Instanceable()) + if (!mapEntry || !mapEntry->IsDungeon()) { handler->PSendSysMessage(LANG_INVALID_ZONE_MAP, areaEntry->ID, areaEntry->AreaName, terrain->GetId(), terrain->GetMapName()); handler->SetSentErrorMessage(true); diff --git a/src/server/scripts/Commands/cs_misc.cpp b/src/server/scripts/Commands/cs_misc.cpp index 76bd9cd24d..67c2ae9860 100644 --- a/src/server/scripts/Commands/cs_misc.cpp +++ b/src/server/scripts/Commands/cs_misc.cpp @@ -550,7 +550,7 @@ public: if (!target->GetMap()->IsBattlegroundOrArena()) target->SetBattlegroundEntryPoint(); } - else if (map->Instanceable()) + else if (map->IsDungeon()) { Map* targetMap = target->GetMap(); Player* targetGroupLeader = nullptr;