Core/Spells: calculate crit chance only for spells that do damage/healing
This commit is contained in:
1 parent
dc46f0621b
commit
c81f48197d
6 files changed
+46
-8
No files matched your search
@@ -2690,6 +2690,22 @@ void SpellMgr::LoadSpellInfoCustomAttributes()
|
||||
break;
|
||||
}
|
||||
|
||||
switch (spellInfo->Effects[j].Effect)
|
||||
{
|
||||
case SPELL_EFFECT_SCHOOL_DAMAGE:
|
||||
case SPELL_EFFECT_HEALTH_LEECH:
|
||||
case SPELL_EFFECT_HEAL:
|
||||
case SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL:
|
||||
case SPELL_EFFECT_WEAPON_PERCENT_DAMAGE:
|
||||
case SPELL_EFFECT_WEAPON_DAMAGE:
|
||||
case SPELL_EFFECT_POWER_BURN:
|
||||
case SPELL_EFFECT_HEAL_MECHANICAL:
|
||||
case SPELL_EFFECT_NORMALIZED_WEAPON_DMG:
|
||||
case SPELL_EFFECT_HEAL_PCT:
|
||||
spellInfo->AttributesCu |= SPELL_ATTR0_CU_CAN_CRIT;
|
||||
break;
|
||||
}
|
||||
|
||||
switch (spellInfo->Effects[j].Effect)
|
||||
{
|
||||
case SPELL_EFFECT_SCHOOL_DAMAGE:
|
||||
@@ -2903,6 +2919,20 @@ void SpellMgr::LoadSpellInfoCustomAttributes()
|
||||
spellInfo->AttributesCu &= ~SPELL_ATTR0_CU_BINARY_SPELL;
|
||||
}
|
||||
|
||||
// remove attribute from spells that can't crit
|
||||
for (uint32 i = 0; i < GetSpellInfoStoreSize(); ++i)
|
||||
{
|
||||
spellInfo = mSpellInfoMap[i];
|
||||
if (!spellInfo)
|
||||
continue;
|
||||
|
||||
if (!spellInfo->HasAttribute(SPELL_ATTR0_CU_CAN_CRIT))
|
||||
continue;
|
||||
|
||||
if (spellInfo->HasAttribute(SPELL_ATTR2_CANT_CRIT))
|
||||
spellInfo->AttributesCu &= ~SPELL_ATTR0_CU_CAN_CRIT;
|
||||
}
|
||||
|
||||
// add custom attribute to liquid auras
|
||||
for (LiquidTypeEntry const* liquid : sLiquidTypeStore)
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user