Core/Misc: Refactor scripts to fix static analysis warnings

First batch of fixes targeting 100 issues reported by Coverity
This commit is contained in:
jackpoz committed 2014-08-31 20:42:02 +02:00
1 parent 681cf8f27c
commit dd4dbdcd16
45 files changed
+1150 -450

No files matched your search

+10 -2
View File
@@ -43,12 +43,20 @@ class npc_pet_dk_ebon_gargoyle : public CreatureScript
struct npc_pet_dk_ebon_gargoyleAI : CasterAI
{
npc_pet_dk_ebon_gargoyleAI(Creature* creature) : CasterAI(creature) { }
npc_pet_dk_ebon_gargoyleAI(Creature* creature) : CasterAI(creature)
{
Initialize();
}
void InitializeAI() override
void Initialize()
{
// Not needed to be despawned now
_despawnTimer = 0;
}
void InitializeAI() override
{
Initialize();
CasterAI::InitializeAI();
uint64 ownerGuid = me->GetOwnerGUID();
+10 -2
View File
@@ -39,11 +39,19 @@ class npc_pet_gen_mojo : public CreatureScript
struct npc_pet_gen_mojoAI : public ScriptedAI
{
npc_pet_gen_mojoAI(Creature* creature) : ScriptedAI(creature) { }
npc_pet_gen_mojoAI(Creature* creature) : ScriptedAI(creature)
{
Initialize();
}
void Initialize()
{
_victimGUID = 0;
}
void Reset() override
{
_victimGUID = 0;
Initialize();
if (Unit* owner = me->GetOwner())
me->GetMotionMaster()->MoveFollow(owner, 0.0f, 0.0f);
+11 -2
View File
@@ -42,13 +42,22 @@ class npc_pet_hunter_snake_trap : public CreatureScript
struct npc_pet_hunter_snake_trapAI : public ScriptedAI
{
npc_pet_hunter_snake_trapAI(Creature* creature) : ScriptedAI(creature) { }
npc_pet_hunter_snake_trapAI(Creature* creature) : ScriptedAI(creature)
{
Initialize();
}
void Initialize()
{
_spellTimer = 0;
_isViper = false;
}
void EnterCombat(Unit* /*who*/) override { }
void Reset() override
{
_spellTimer = 0;
Initialize();
CreatureTemplate const* Info = me->GetCreatureTemplate();