Core/Misc: added more fallthrough attributes and added some missing breaks reported by CI

This commit is contained in:
Ovahlord committed 2020-07-19 12:24:58 +02:00
1 parent 52d9bb2538
commit e1d74d4dc6
25 files changed
+31 -20

No files matched your search

@@ -950,6 +950,7 @@ class npc_ignacious : public CreatureScript
case EVENT_FLAME_STRIKE:
DoCastAOE(SPELL_FLAME_STRIKE_TARGETING, true);
_events.Repeat(20s);
break;
default:
break;
}
@@ -125,6 +125,7 @@ class instance_bastion_of_twilight : public InstanceMapScript
case NPC_TIME_WARDEN:
if (Creature* halfus = GetCreature(DATA_HALFUS_WYRMBREAKER))
halfus->AI()->JustSummoned(creature);
[[fallthrough]];
case NPC_ORPHANED_EMERALD_WELP:
case NPC_SPIKE:
_halfusEncounterGUIDs.insert(creature->GetGUID());
@@ -60,10 +60,6 @@ class instance_blackrock_caverns : public InstanceMapScript
if (state == DONE)
if (Creature* raz = GetCreature(DATA_RAZ_THE_CRAZED))
raz->AI()->DoAction(ACTION_BREAK_OUT_OF_PRISON);
case DATA_CORLA_HERALD_OF_TWILIGHT:
case DATA_KARSH_STEELBENDER:
case DATA_BEAUTY:
case DATA_ASCENDANT_LORD_OBSIDIUS:
break;
default:
break;
@@ -324,6 +324,7 @@ struct boss_magmaw : public BossAI
return _pincer1->GetGUID();
else if (_pincer2->GetVehicleKit() && _pincer2->GetVehicleKit()->GetAvailableSeatCount())
return _pincer2->GetGUID();
break;
default:
return ObjectGuid::Empty;
}
@@ -1121,6 +1121,7 @@ struct npc_nefarians_end_lord_victor_nefarius : public PassiveAI
stalker->CastSpell(stalker, SPELL_INTRO_1_TRANSFORM_VISUAL);
stalker->DespawnOrUnsummon(2s + 400ms);
}
break;
default:
break;
}
@@ -179,6 +179,7 @@ public:
me->StopMoving();
me->SetFacingToObject(summon);
DoCast(summon, SPELL_SHIELD_OF_THE_PERFIDIOUS);
break;
default:
break;
}
@@ -330,6 +330,7 @@ class instance_throne_of_the_tides : public InstanceMapScript
case GO_DOODAD_ABYSSAL_CORAL_CHUNK_CEILING:
if (_eventIndex == EVENT_INDEX_ULTHOK_ARRIVED)
go->DespawnOrUnsummon();
break;
default:
break;
}
@@ -231,6 +231,7 @@ class instance_throne_of_the_four_winds : public InstanceMapScript
vehicle->DespawnOrUnsummon(0);
}
}
break;
default:
break;
}
@@ -562,7 +562,9 @@ public:
Spark->DisappearAndDie();
DespawnNagaFlag(false);
me->DisappearAndDie();
default: return 99999999;
return 99999999;
default:
return 99999999;
}
}
@@ -125,8 +125,9 @@ class boss_prince_taldaram : public CreatureScript
case NPC_FLAME_SPHERE_2:
case NPC_FLAME_SPHERE_3:
summon->AI()->SetGUID(_flameSphereTargetGUID);
break;
default:
return;
break;
}
}
@@ -221,7 +221,7 @@ class boss_kologarn : public CreatureScript
break;
case NPC_RUBBLE:
summons.Summon(summon);
// absence of break intended
[[fallthrough]];
default:
return;
}
@@ -2970,6 +2970,7 @@ class spell_gen_replenishment : public SpellScriptLoader
case SPELL_REPLENISHMENT:
case SPELL_INFINITE_REPLENISHMENT:
amount = CalculatePct(GetUnitOwner()->GetMaxPower(POWER_MANA), 0.1f);
break;
default:
break;
}