Core/Dungeon Finder: Code cleanup and minor optimizations
- Extend LfgState to keep control of the state of group and players using LFG - Move scripts to its own class and initialize only if Dungeon finder is enabled - Updated comments to doxygen format - Use constructor initialization list - All variables are declared in the inner most scope - Fix some mem leaks - Remove no longer needed code (Cleaner) - Normalize handler function names --HG-- branch : trunk
This commit is contained in:
1 parent
71c2698faf
commit
e621f5fe98
16 files changed
+1015
-1024
No files matched your search
@@ -22190,13 +22190,13 @@ PartyResult Player::CanUninviteFromGroup() const
|
||||
if (grp->GetLfgKicks() == GROUP_MAX_LFG_KICKS)
|
||||
return ERR_PARTY_LFG_BOOT_LIMIT;
|
||||
|
||||
if (grp->isLfgKickActive())
|
||||
if (GetLfgState() == LFG_STATE_BOOT)
|
||||
return ERR_PARTY_LFG_BOOT_IN_PROGRESS;
|
||||
|
||||
if (grp->GetMembersCount() <= GROUP_LFG_KICK_VOTES_NEEDED)
|
||||
return ERR_PARTY_LFG_BOOT_TOO_FEW_PLAYERS;
|
||||
|
||||
if (grp->isLfgDungeonComplete())
|
||||
if (GetLfgState() == LFG_STATE_FINISHED_DUNGEON)
|
||||
return ERR_PARTY_LFG_BOOT_DUNGEON_COMPLETE;
|
||||
|
||||
if (grp->isRollLootActive())
|
||||
|
||||
Reference in new issue
Block a user