Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

Fix various warnings. The core, the scripts and the tools now compile without warnings with -Wall -Wextra -pedantic.

Browse Source 
-Fix warnings from -Woverflow on implicit constant conversion.
-Fix warnings from -pedantic.
-Fix warnings from -pedantic.
-Fix warnings from -Wformat.

Two minor changes in addition :

-Replace a defined value equal to 2^31 - 1 by std::numeric_limits<int>::max().
-Remove useless null-check on pointer returned by new. New doesn't returns nullptr on failure, it throws std::bad_alloc.
This commit is contained in:
Praetonus committed 2014-05-15 21:32:47 +02:00
1 parent 9d760098a5
commit f296095191
130 files changed
+799 -801
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/server/scripts/Spells/spell_dk.cpp
+24 -24
View File
@@ -79,7 +79,7 @@ class spell_dk_anti_magic_shell_raid : public SpellScriptLoader
class spell_dk_anti_magic_shell_raid_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_anti_magic_shell_raid_AuraScript);
PrepareAuraScript(spell_dk_anti_magic_shell_raid_AuraScript)
uint32 absorbPct;
@@ -121,7 +121,7 @@ class spell_dk_anti_magic_shell_self : public SpellScriptLoader
class spell_dk_anti_magic_shell_self_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_anti_magic_shell_self_AuraScript);
PrepareAuraScript(spell_dk_anti_magic_shell_self_AuraScript)
uint32 absorbPct, hpPct;
bool Load() override
@@ -178,7 +178,7 @@ class spell_dk_anti_magic_zone : public SpellScriptLoader
class spell_dk_anti_magic_zone_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_anti_magic_zone_AuraScript);
PrepareAuraScript(spell_dk_anti_magic_zone_AuraScript)
uint32 absorbPct;
@@ -229,7 +229,7 @@ class spell_dk_blood_boil : public SpellScriptLoader
class spell_dk_blood_boil_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_blood_boil_SpellScript);
PrepareSpellScript(spell_dk_blood_boil_SpellScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -275,7 +275,7 @@ class spell_dk_blood_gorged : public SpellScriptLoader
class spell_dk_blood_gorged_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_blood_gorged_AuraScript);
PrepareAuraScript(spell_dk_blood_gorged_AuraScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -349,7 +349,7 @@ class spell_dk_corpse_explosion : public SpellScriptLoader
class spell_dk_corpse_explosion_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_corpse_explosion_SpellScript);
PrepareSpellScript(spell_dk_corpse_explosion_SpellScript)
bool Validate(SpellInfo const* spellInfo) override
{
@@ -448,7 +448,7 @@ class spell_dk_death_coil : public SpellScriptLoader
class spell_dk_death_coil_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_death_coil_SpellScript);
PrepareSpellScript(spell_dk_death_coil_SpellScript)
bool Validate(SpellInfo const* /*spell*/) override
{
@@ -515,7 +515,7 @@ class spell_dk_death_gate : public SpellScriptLoader
class spell_dk_death_gate_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_death_gate_SpellScript);
PrepareSpellScript(spell_dk_death_gate_SpellScript)
SpellCastResult CheckClass()
{
@@ -556,7 +556,7 @@ class spell_dk_death_grip : public SpellScriptLoader
class spell_dk_death_grip_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_death_grip_SpellScript);
PrepareSpellScript(spell_dk_death_grip_SpellScript)
void HandleDummy(SpellEffIndex /*effIndex*/)
{
@@ -590,7 +590,7 @@ class spell_dk_death_pact : public SpellScriptLoader
class spell_dk_death_pact_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_death_pact_SpellScript);
PrepareSpellScript(spell_dk_death_pact_SpellScript)
SpellCastResult CheckCast()
{
@@ -646,7 +646,7 @@ class spell_dk_death_strike : public SpellScriptLoader
class spell_dk_death_strike_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_death_strike_SpellScript);
PrepareSpellScript(spell_dk_death_strike_SpellScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -690,7 +690,7 @@ class spell_dk_ghoul_explode : public SpellScriptLoader
class spell_dk_ghoul_explode_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_ghoul_explode_SpellScript);
PrepareSpellScript(spell_dk_ghoul_explode_SpellScript)
bool Validate(SpellInfo const* spellInfo) override
{
@@ -738,7 +738,7 @@ class spell_dk_icebound_fortitude : public SpellScriptLoader
class spell_dk_icebound_fortitude_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_icebound_fortitude_AuraScript);
PrepareAuraScript(spell_dk_icebound_fortitude_AuraScript)
bool Load() override
{
@@ -787,7 +787,7 @@ class spell_dk_improved_blood_presence : public SpellScriptLoader
class spell_dk_improved_blood_presence_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_improved_blood_presence_AuraScript);
PrepareAuraScript(spell_dk_improved_blood_presence_AuraScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -834,7 +834,7 @@ class spell_dk_improved_frost_presence : public SpellScriptLoader
class spell_dk_improved_frost_presence_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_improved_frost_presence_AuraScript);
PrepareAuraScript(spell_dk_improved_frost_presence_AuraScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -881,7 +881,7 @@ class spell_dk_improved_unholy_presence : public SpellScriptLoader
class spell_dk_improved_unholy_presence_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_improved_unholy_presence_AuraScript);
PrepareAuraScript(spell_dk_improved_unholy_presence_AuraScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -941,7 +941,7 @@ class spell_dk_presence : public SpellScriptLoader
class spell_dk_presence_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_presence_AuraScript);
PrepareAuraScript(spell_dk_presence_AuraScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -1057,7 +1057,7 @@ class spell_dk_raise_dead : public SpellScriptLoader
class spell_dk_raise_dead_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_raise_dead_SpellScript);
PrepareSpellScript(spell_dk_raise_dead_SpellScript)
bool Validate(SpellInfo const* spellInfo) override
{
@@ -1190,7 +1190,7 @@ class spell_dk_rune_tap_party : public SpellScriptLoader
class spell_dk_rune_tap_party_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_rune_tap_party_SpellScript);
PrepareSpellScript(spell_dk_rune_tap_party_SpellScript)
void CheckTargets(std::list<WorldObject*>& targets)
{
@@ -1217,7 +1217,7 @@ class spell_dk_scent_of_blood : public SpellScriptLoader
class spell_dk_scent_of_blood_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_scent_of_blood_AuraScript);
PrepareAuraScript(spell_dk_scent_of_blood_AuraScript)
bool Validate(SpellInfo const* /*spellInfo*/) override
{
@@ -1253,7 +1253,7 @@ class spell_dk_scourge_strike : public SpellScriptLoader
class spell_dk_scourge_strike_SpellScript : public SpellScript
{
PrepareSpellScript(spell_dk_scourge_strike_SpellScript);
PrepareSpellScript(spell_dk_scourge_strike_SpellScript)
float multiplier;
bool Load() override
@@ -1316,7 +1316,7 @@ class spell_dk_spell_deflection : public SpellScriptLoader
class spell_dk_spell_deflection_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_spell_deflection_AuraScript);
PrepareAuraScript(spell_dk_spell_deflection_AuraScript)
uint32 absorbPct;
@@ -1360,7 +1360,7 @@ class spell_dk_vampiric_blood : public SpellScriptLoader
class spell_dk_vampiric_blood_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_vampiric_blood_AuraScript);
PrepareAuraScript(spell_dk_vampiric_blood_AuraScript)
void CalculateAmount(AuraEffect const* /*aurEff*/, int32& amount, bool& /*canBeRecalculated*/)
{
@@ -1387,7 +1387,7 @@ class spell_dk_will_of_the_necropolis : public SpellScriptLoader
class spell_dk_will_of_the_necropolis_AuraScript : public AuraScript
{
PrepareAuraScript(spell_dk_will_of_the_necropolis_AuraScript);
PrepareAuraScript(spell_dk_will_of_the_necropolis_AuraScript)
bool Validate(SpellInfo const* spellInfo) override
{