Core/Units: removed the packetOnly parameter from several movement flag setters

This commit is contained in:
Ovahlord committed 2025-03-10 17:43:42 +01:00
1 parent f72f923d7e
commit f46b6f0797
37 files changed
+194 -224

No files matched your search

@@ -397,7 +397,6 @@ struct npc_halfus_enslaved_dragon final : public ScriptedAI
void JustDied(Unit* /*killer*/) override
{
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
me->DespawnOrUnsummon(6s);
if (Creature* protoBehemoth = _instance->GetCreature(DATA_PROTO_BEHEMOTH))
@@ -273,7 +273,6 @@ struct boss_theralion final : public BossAI
{
_EnterEvadeMode();
instance->SendEncounterUnit(ENCOUNTER_FRAME_DISENGAGE, me);
me->SendSetPlayHoverAnim(false);
me->SetDisableGravity(false);
summons.DespawnAll();
@@ -311,7 +310,6 @@ struct boss_theralion final : public BossAI
me->SetReactState(REACT_PASSIVE);
me->PlayOneShotAnimKitId(ANIM_KIT_LIFTOFF);
me->SetDisableGravity(true);
me->SendSetPlayHoverAnim(true);
_dazzlingDestructionCount = 0;
events.SetPhase(PHASE_AIR);
events.CancelEvent(EVENT_FABULOUS_FLAMES);
@@ -355,7 +353,6 @@ struct boss_theralion final : public BossAI
break;
case POINT_LAND:
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
events.ScheduleEvent(EVENT_ATTACK_PLAYERS, 2s);
break;
default:
@@ -514,7 +511,6 @@ struct boss_valiona final : public BossAI
{
_EnterEvadeMode();
instance->SendEncounterUnit(ENCOUNTER_FRAME_DISENGAGE, me);
me->SendSetPlayHoverAnim(false);
me->SetDisableGravity(false);
summons.DespawnAll();
_DespawnAtEvade();
@@ -554,7 +550,6 @@ struct boss_valiona final : public BossAI
events.CancelEvent(EVENT_DEVOURING_FLAMES);
me->PlayOneShotAnimKitId(ANIM_KIT_LIFTOFF);
me->SetDisableGravity(true);
me->SendSetPlayHoverAnim(true);
_deepBreathCount = 0;
events.ScheduleEvent(EVENT_FLY_TO_DESTINATION, 1s);
events.ScheduleEvent(EVENT_DEEP_BREATH, 1min + 25s + 100ms);
@@ -606,7 +601,6 @@ struct boss_valiona final : public BossAI
break;
case POINT_LAND:
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
events.ScheduleEvent(EVENT_ATTACK_PLAYERS, 2s);
events.ScheduleEvent(EVENT_BLACKOUT, 10s + 500ms);
events.ScheduleEvent(EVENT_DEVOURING_FLAMES, 25s);
@@ -367,7 +367,6 @@ struct boss_atramedes : public BossAI
break;
case POINT_LAND_INTRO:
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
me->HandleEmoteCommand(EMOTE_ONESHOT_ROAR);
me->SetReactState(REACT_AGGRESSIVE);
break;
@@ -380,7 +379,6 @@ struct boss_atramedes : public BossAI
break;
case POINT_LAND:
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
events.SetPhase(PHASE_GROUND);
events.ScheduleEvent(EVENT_REENGAGE_PLAYERS, 800ms, 0, PHASE_GROUND);
events.ScheduleEvent(EVENT_SONAR_PULSE, 14s, 0, PHASE_GROUND);
@@ -707,7 +707,6 @@ struct npc_maloriak_experiment : public ScriptedAI
{
case POINT_GROUND:
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
me->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE_TO_PC);
me->SetReactState(REACT_AGGRESSIVE);
DoZoneInCombat();
@@ -400,14 +400,13 @@ struct boss_nefarians_end : public BossAI
{
events.ScheduleEvent(EVENT_CHAIN_ONYXIA, 1s, 0, PHASE_ONE);
events.ScheduleEvent(EVENT_REMOVE_TRANSFORM_AURA, 26s + 700ms, 0, PHASE_ONE);
me->SendSetPlayHoverAnim(false);
me->SetDisableGravity(false);
DoCastSelf(SPELL_INTRO_2_STALKER_TRANSFORM);
DoCastSelf(SPELL_INTRO_3_SHRINK_AURA);
}
else
{
me->AddUnitMovementFlag(MOVEMENTFLAG_DISABLE_GRAVITY);
me->SetAnimationTier(AnimationTier::Fly);
me->SetDisableGravity(true);
me->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE_TO_NPC | UNIT_FLAG_IMMUNE_TO_PC | UNIT_FLAG_NOT_SELECTABLE);
me->GetMotionMaster()->MoveCyclicPath(NefarianCyclicRespawnPath, CyclicRespawnPathPoints, false, true, 14.0f);
DoCastSelf(SPELL_INTRO_5A_START_FIGHT_PROC);
@@ -634,7 +633,6 @@ struct boss_nefarians_end : public BossAI
me->RemoveAurasDueToSpell(SPELL_INTRO_2_STALKER_TRANSFORM);
me->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NOT_SELECTABLE);
me->SetDisableGravity(true);
me->SendSetPlayHoverAnim(true);
events.ScheduleEvent(EVENT_LIFT_OFF, 2s, 0, PHASE_ONE);
break;
case EVENT_LIFT_OFF:
@@ -666,7 +664,6 @@ struct boss_nefarians_end : public BossAI
break;
case EVENT_LANDED:
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
if (events.IsInPhase(PHASE_ONE))
{
@@ -735,7 +732,6 @@ struct boss_nefarians_end : public BossAI
case EVENT_LIFTOFF_PHASE_TWO:
DoCastSelf(SPELL_NEFARIAN_PHASE_2_HEALTH_AURA);
me->SetDisableGravity(true);
me->SendSetPlayHoverAnim(true);
me->GetMotionMaster()->MovePoint(POINT_NONE, NefarianElevatorLiftOffPosition);
events.ScheduleEvent(EVENT_SUMMON_CHROMATIC_PROTOTYPES, 400ms, 0, PHASE_TWO);
events.ScheduleEvent(EVENT_LOWER_ELEVATOR, 800ms, 0, PHASE_TWO);
@@ -790,7 +786,6 @@ struct boss_nefarians_end : public BossAI
instance->DoUpdateWorldState(WORLD_STATE_ID_KEEPING_IT_IN_THE_FAMILY, 0);
me->RemoveAurasDueToSpell(SPELL_NEFARIAN_PHASE_2_HEALTH_AURA);
me->SendSetPlayHoverAnim(true);
me->GetMotionMaster()->MoveLand(POINT_LAND, NefarianElevatorLandPhaseThreePosition);
break;
case EVENT_ELECTROCUTE:
@@ -341,7 +341,6 @@ class instance_blackwing_descent : public InstanceMapScript
atramedes->SetDisableGravity(true);
atramedes->SetReactState(REACT_PASSIVE);
atramedes->SendSetPlayHoverAnim(true);
if (atramedes->IsAIEnabled())
atramedes->AI()->DoAction(ACTION_START_ATRAMEDES_INTRO);
@@ -274,7 +274,6 @@ struct boss_glubtok : public BossAI
Talk(SAY_ARCANE_POWER);
DoCastSelf(SPELL_ARCANE_POWER);
me->SetDisableGravity(true);
me->SendSetPlayHoverAnim(true);
Movement::MoveSplineInit init(me);
init.MoveTo(me->GetPositionX(), me->GetPositionY(), me->GetPositionZ() + 2.0f, false);
@@ -650,7 +650,7 @@ struct npc_gilnean_crow : public PassiveAI
{
case EVENT_APPLY_HOVER_BYTES:
me->SetStandState(UNIT_STAND_STATE_SIT);
me->SetAnimationTier(AnimationTier::Submerged);
me->SetAnimTier(AnimTier::Submerged);
_events.ScheduleEvent(EVENT_FLY_AWAY_1, 1s);
break;
case EVENT_FLY_AWAY_1:
@@ -187,8 +187,6 @@ struct npc_grim_batol_battered_red_drake: public VehicleAI
me->RemoveAurasDueToSpell(SPELL_NET);
DoCastSelf(SPELL_BOMBING_RUN_PROTECTION_TRIGGER);
// Yes, this is stupid. Don't argue. Confirmed by 2012 sniffs.
me->SetDisableGravity(true, false, false);
summon->CastSpell(summon, SPELL_NET_SCRIPT);
summon->DespawnOrUnsummon(3s);
}
@@ -221,7 +219,6 @@ struct npc_grim_batol_battered_red_drake: public VehicleAI
_instance->SetData(DATA_START_BATTERED_RED_DRAKE_DESPAWN_EVENT, IN_PROGRESS);
me->SetControlled(true, UNIT_STATE_ROOT);
me->PlayOneShotAnimKitId(ANIM_KIT_ID_LIFTOFF);
me->SetAnimationTier(AnimationTier::Fly);
_playerGuid = player->GetGUID();
@@ -129,7 +129,6 @@ class PrepareDelayedAttackEvent : public BasicEvent
{
_owner->RemoveAurasDueToSpell(SPELL_WATER_JUMP_THROUGH_WINDOW_VISUAL);
_owner->SetDisableGravity(false);
_owner->SendSetPlayHoverAnim(false);
_owner->SetMovementAnimKitId(0);
_owner->m_Events.AddEvent(new DelayedAttackEvent(_owner), _owner->m_Events.CalculateTime(1000));
return true;
@@ -281,7 +280,6 @@ struct boss_lady_nazjar : public BossAI
{
invader->SetReactState(REACT_PASSIVE);
invader->SetDisableGravity(true);
invader->SendSetPlayHoverAnim(true);
invader->SetMovementAnimKitId(3);
invader->CastSpell(invader, SPELL_WATER_WINDOW_BREAK_VISUAL);
invader->GetMotionMaster()->MoveJump(LadyNazjarAddJumpPositions[i], 16.0f, 11.0f);
@@ -473,14 +473,12 @@ struct npc_ozumat_neptulon : public ScriptedAI
case NPC_UNYIELDING_BEHEMOTH:
summon->SetReactState(REACT_PASSIVE);
summon->SetDisableGravity(true);
summon->SendSetPlayHoverAnim(true);
summon->SetCorpseDelay(4);
summon->m_Events.AddEvent(new ChargeToWindowEvent(summon), summon->m_Events.CalculateTime(2 * IN_MILLISECONDS));
break;
case NPC_BLIGHT_BEAST:
summon->SetReactState(REACT_PASSIVE);
summon->SetDisableGravity(true);
summon->SendSetPlayHoverAnim(true);
summon->SetCorpseDelay(4);
summon->m_Events.AddEvent(new ChargeToWindowEvent(summon), summon->m_Events.CalculateTime(2400));
break;
@@ -671,7 +669,6 @@ struct npc_ozumat_unyielding_behemoth : public ScriptedAI
me->AttackStop();
me->SetReactState(REACT_PASSIVE);
me->SetDisableGravity(true);
me->SendSetPlayHoverAnim(true);
DoCast(summon, SPELL_SHADOW_BLAST_RIDE_VEHICLE);
_events.ScheduleEvent(EVENT_DISABLE_HOVER_ANIM, 400ms);
_events.ScheduleEvent(EVENT_SHADOW_BLAST_VISUAL, 1s + 200ms);
@@ -709,14 +706,13 @@ struct npc_ozumat_unyielding_behemoth : public ScriptedAI
DoCastAOE(SPELL_SHADOW_BLAST);
break;
case EVENT_DISABLE_HOVER_ANIM:
me->SendSetPlayHoverAnim(false);
me->SetPlayHoverAnim(false);
break;
case EVENT_SHADOW_BLAST_VISUAL:
DoCastAOE(SPELL_SHADOW_BLAST_VISUAL);
break;
case EVENT_FINISH_SHADOW_BLAST:
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
me->SetReactState(REACT_AGGRESSIVE);
if (Unit* victim = me->GetVictim())
AttackStart(victim);
@@ -773,7 +769,6 @@ class spell_ozumat_jump_to_ground : public SpellScript
if (Unit* caster = GetCaster())
{
caster->SetDisableGravity(false);
caster->SendSetPlayHoverAnim(false);
}
}
@@ -821,7 +816,7 @@ class spell_ozumat_shadow_blast_AuraScript : public AuraScript
{
if (Unit* target = GetTarget())
{
target->SendSetPlayHoverAnim(true);
target->SetPlayHoverAnim(true);
target->CastSpell(target, SPELL_SHADOW_BLAST_MISSILE);
if (Vehicle* vehicle = target->GetVehicleKit())
@@ -94,7 +94,6 @@ class FaceDirectionEvent : public BasicEvent
{
_owner->RemoveAurasDueToSpell(SPELL_WATER_JUMP_THROUGH_WINDOW_VISUAL);
_owner->SetDisableGravity(false);
_owner->SendSetPlayHoverAnim(false);
_owner->SetMovementAnimKitId(0);
_owner->SetFacingTo(_facingAngle);
_owner->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE_TO_PC);
@@ -401,7 +400,6 @@ class instance_throne_of_the_tides : public InstanceMapScript
{
invader->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE_TO_PC);
invader->SetDisableGravity(true);
invader->SendSetPlayHoverAnim(true);
invader->SetMovementAnimKitId(3);
invader->SetReactState(REACT_PASSIVE);
invader->GetMotionMaster()->MovePoint(0, TotTFirstInvaderInitialMovePositions[i], false);
@@ -418,7 +416,6 @@ class instance_throne_of_the_tides : public InstanceMapScript
{
invader->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE_TO_PC);
invader->SetDisableGravity(true);
invader->SendSetPlayHoverAnim(true);
invader->SetMovementAnimKitId(3);
invader->SetReactState(REACT_PASSIVE);
invader->GetMotionMaster()->MovePoint(0, TotTLadyNazjarInvaderInitialMovePositions[i], false);
@@ -543,7 +540,7 @@ class instance_throne_of_the_tides : public InstanceMapScript
break;
default:
break;
}
}
@@ -563,7 +563,6 @@ class spell_akilzon_electrical_storm : public AuraScript
{
Unit* target = GetTarget();
target->SetDisableGravity(true);
target->SendSetPlayHoverAnim(true);
target->SetControlled(true, UNIT_STATE_ROOT);
target->CastSpell(target, SPELL_ELECTRICAL_STORM_AREA_AURA, true);
target->CastSpell(target, SPELL_TELEPORT_SELF, true);
@@ -575,7 +574,6 @@ class spell_akilzon_electrical_storm : public AuraScript
target->SetDisableGravity(false);
target->SetControlled(false, UNIT_STATE_ROOT);
target->RemoveAurasDueToSpell(SPELL_ELECTRICAL_STORM_AREA_AURA);
target->SendSetPlayHoverAnim(false);
target->CastSpell(target, GetSpellInfo()->Effects[EFFECT_2].BasePoints);
}
@@ -122,7 +122,6 @@ struct boss_high_priestess_kilnara : public BossAI
DoCastAOE(SPELL_CLEAR_ACHIEVEMENT_CREDITS);
me->SetHover(false);
me->SendSetPlayHoverAnim(false);
me->RemoveAurasDueToSpell(SPELL_KILNARA_HOVER_VISUAL_1);
me->RemoveAurasDueToSpell(SPELL_KILNARA_HOVER_VISUAL_2);
instance->SendEncounterUnit(ENCOUNTER_FRAME_ENGAGE, me);
@@ -386,7 +386,6 @@ struct npc_zanzil_zanzili_berserker : public ScriptedAI
me->SetAIAnimKitId(0);
me->GetMotionMaster()->MoveFall();
me->SetDisableGravity(false);
me->SendSetPlayHoverAnim(false);
me->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NOT_SELECTABLE | UNIT_FLAG_IMMUNE_TO_PC | UNIT_FLAG_IMMUNE_TO_NPC);
DoZoneInCombat();
_events.ScheduleEvent(EVENT_PURSUIT, 2s);
@@ -1359,7 +1359,6 @@ struct npc_madness_of_deathwing_thrall : public ScriptedAI
case ACTION_FIRE_DRAGON_SOUL:
_events.Reset();
me->SetDisableGravity(true);
me->SendSetPlayHoverAnim(true);
DoCastAOE(SPELL_FIRE_DRAGON_SOUL_ASPECTS);
DoCastAOE(SPELL_TRIGGER_ASPECT_YELL);
DoCastSelf(SPELL_ASTRAL_RECALL_OUTRO);
@@ -1396,7 +1395,6 @@ struct npc_madness_of_deathwing_thrall : public ScriptedAI
case EVENT_PLAY_MOVIE:
DoCastAOE(SPELL_PLAY_MOVIE);
me->SetFlag(UNIT_NPC_FLAGS, UNIT_NPC_FLAG_GOSSIP);
me->SendSetPlayHoverAnim(false);
me->SetDisableGravity(false);
if (Creature* ysera = _instance->GetCreature(DATA_YSERA_MADNESS_OF_DEATHWING))
@@ -2142,14 +2140,14 @@ class spell_madness_of_deathwing_concentration : public AuraScript
if (creature->IsAIEnabled())
creature->AI()->SetGUID(GetTarget()->GetGUID(), DATA_FOCUSED_LIMB);
GetTarget()->SetAnimationTier(AnimationTier::Fly);
GetTarget()->SetAnimTier(AnimTier::Fly);
for (uint8 i = 0; i < 2; ++i)
GetTarget()->CastSpell(GetTarget(), SPELL_SUMMON_COSMETIC_TENTACLE);
}
void AfterRemove(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
GetTarget()->SetAnimationTier(AnimationTier::Ground);
GetTarget()->SetAnimTier(AnimTier::Ground);
}
void Register() override
@@ -783,8 +783,7 @@ struct boss_ragnaros_firelands : public BossAI
if (GameObject* platform = instance->GetGameObject(DATA_RAGNAROS_PLATFORM))
platform->SetDestructibleState(GO_DESTRUCTIBLE_DAMAGED);
me->RemoveAurasDueToSpell(SPELL_LEGS_SUBMERGE);
me->SendSetPlayHoverAnim(true);
me->SetAnimationTier(AnimationTier::Fly, false);
me->SetDisableGravity(true);
me->SetControlled(false, UNIT_STATE_ROOT);
me->PlayOneShotAnimKitId(ANIM_KIT_ID_EMERGE_HEROIC);
instance->SetData(DATA_MAGMA_KNOCKBACK, 0);
@@ -808,8 +807,6 @@ struct boss_ragnaros_firelands : public BossAI
Talk(SAY_BREAK_FREE);
DoCastSelf(SPELL_DREADFLAME_SUMMON_CONTROLLER);
me->PlayOneShotAnimKitId(ANIM_KIT_ID_BREAK_FREE);
me->SendSetPlayHoverAnim(false);
me->SetAnimationTier(AnimationTier::Ground, false);
me->SetDisableGravity(false);
_canBeKilled = true;
events.ScheduleEvent(EVENT_SET_AGGRESSIVE_REACT_STATE, 5s, 0, PHASE_FOUR);
@@ -973,7 +973,7 @@ class spell_alakir_wind_burst : public AuraScript
{
void HandlePeriodic(AuraEffect const* /*aurEff*/)
{
GetTarget()->SetCanFly(true, true);
GetTarget()->SetCanFly(true);
}
void Register() override
@@ -520,7 +520,6 @@ class spell_uldum_rescue_survivor : public SpellScript
{
creature->ExitVehicle();
creature->SetDisableGravity(false);
creature->SetAnimationTier(AnimationTier::Ground, false);
creature->DespawnOrUnsummon(30s);
Position dest = creature->GetPosition();
@@ -353,7 +353,7 @@ class boss_blood_queen_lana_thel : public CreatureScript
break;
}
case EVENT_DELIRIOUS_SLASH:
if (_offtankGUID && me->GetAnimationTier() != AnimationTier::Fly)
if (_offtankGUID && me->GetAnimTier() != AnimTier::Fly)
if (Player* _offtank = ObjectAccessor::GetPlayer(*me, _offtankGUID))
DoCast(_offtank, SPELL_DELIRIOUS_SLASH);
events.ScheduleEvent(EVENT_DELIRIOUS_SLASH, urand(20000, 24000), EVENT_GROUP_NORMAL);
@@ -300,9 +300,7 @@ class boss_sindragosa : public CreatureScript
{
BossAI::JustReachedHome();
instance->SetBossState(DATA_SINDRAGOSA, FAIL);
me->SetCanFly(false);
me->SetDisableGravity(false);
me->SetAnimationTier(AnimationTier::Ground);
me->SetReactState(REACT_DEFENSIVE);
}
@@ -279,7 +279,7 @@ class npc_enslaved_proto_drake : public CreatureScript
{
if (type == WAYPOINT_MOTION_TYPE && id == POINT_LAST)
{
me->SetAnimationTier(AnimationTier::Ground);
me->SetAnimTier(AnimTier::Ground);
}
}
@@ -288,7 +288,7 @@ class npc_enslaved_proto_drake : public CreatureScript
if (type == TYPE_PROTODRAKE_AT && data == DATA_PROTODRAKE_MOVE && !_setData && me->GetDistance(protodrakeCheckPos) < 5.0f)
{
_setData = true;
me->SetAnimationTier(AnimationTier::Fly);
me->SetAnimTier(AnimTier::Fly);
me->GetMotionMaster()->MovePath(PATH_PROTODRAKE, false);
}
}