From fd815dfe3386a98871b407ac7ef8387fd3b6e52f Mon Sep 17 00:00:00 2001 From: Ovahlord Date: Sun, 29 Aug 2021 01:52:39 +0200 Subject: [PATCH] Core/Units: remove an incorrect check for SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER from Unit::GetUnitCriticalChanceTaken as that aura is only being involved for increasing crit chance values for spells with a class mask value --- src/server/game/Entities/Unit/Unit.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp index 585c0c8df8..4cef735a47 100644 --- a/src/server/game/Entities/Unit/Unit.cpp +++ b/src/server/game/Entities/Unit/Unit.cpp @@ -2862,13 +2862,6 @@ float Unit::GetUnitCriticalChanceTaken(Unit const* attacker, WeaponAttackType at else chance += GetTotalAuraModifier(SPELL_AURA_MOD_ATTACKER_MELEE_CRIT_CHANCE); - chance += GetTotalAuraModifier(SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER, [attacker](AuraEffect const* aurEff) -> bool - { - if (aurEff->GetCasterGUID() == attacker->GetGUID()) - return true; - return false; - }); - // applied after resilience chance += GetTotalAuraModifier(SPELL_AURA_MOD_ATTACKER_SPELL_AND_WEAPON_CRIT_CHANCE);