From dc6157020fef416c6055e3e89186da950d096c12 Mon Sep 17 00:00:00 2001
From: wareya <wareya@gmail.com>
Date: Fri, 6 Jul 2018 22:22:39 -0400
Subject: [PATCH] Add 'popup requires key' option

---
 options.html |  1 +
 options.js   |  9 ++++++++-
 texthook.js  | 51 ++++++++++++++++++++++++++++++++++++++++++++++++---
 3 files changed, 57 insertions(+), 4 deletions(-)

diff --git a/options.html b/options.html
index aee15bd..70af081 100644
--- a/options.html
+++ b/options.html
@@ -10,6 +10,7 @@
 <div class=panel>
 <!-- target=_blank prevents firefox mobile from opening the link inside the about:addons page and hitting a CSP error -->
 <p>View the tutorial <a href="https://github.com/wareya/nazeka/blob/master/tutorial.md" target="_blank">here!</a></p>
+<p>Do you want an option that isn't here? Post a request on the <a href="https://github.com/wareya/nazeka/issues" target="_blank">issue tracker</a>.</p>
 
 <form name=optform>
 <div id=optionsection>
diff --git a/options.js b/options.js
index 84d577f..5a3c8e7 100644
--- a/options.js
+++ b/options.js
@@ -67,6 +67,13 @@ function defaults()
         default: true,
         label: "Strict matching for alternative matches"
     });
+    settings.push({
+        id: "popup_requires_key",
+        kind: "combobox",
+        options: ["None", "Ctrl", "Shift"],
+        default: 0,
+        label: "Popup requires key"
+    });
     
     // display
     settings.push({
@@ -127,7 +134,7 @@ function defaults()
         kind: "combobox",
         options: ["Top left", "Top right", "Bottom left", "Bottom right", "Top auto"],
         default: 0,
-        label: "Popup positioning corner (note: for \"bottom\" corners, order of definitions is reversed, but \"original text\" still shows up at top of each lookup's definitions, not bottom) (\"top auto\" feels very bad unless \"position as though fixed width\" is also enabled)"
+        label: "Popup positioning corner (note: \"bottom ___\" and \"top auto\" have problems due to web technology being a bad fit for mouseover dictionaries)"
     });
     
     // theme
diff --git a/texthook.js b/texthook.js
index 15f6c81..52c3d43 100644
--- a/texthook.js
+++ b/texthook.js
@@ -43,7 +43,8 @@ xoffset: 5,
 yoffset: 22,
 ignore_linebreaks: false,
 sticky: false,
-popup_follows_mouse: true
+popup_follows_mouse: true,
+popup_requires_key: 0 // 0: none; 1: ctrl; 2: shift
 };
 
 let platform = "win";
@@ -126,8 +127,12 @@ function get_doc()
 
 // here we set all the styling and positioning of the div, passing "middle" as the actual contents of it.
 // this is rather elaborate because of 1) a lack of shadow DOM, even for just styling 2) options 3) """features""" of how HTML viewport stuff works that are actually terrible
+let last_display_x = 0;
+let last_display_y = 0;
 function display_div(middle, x, y)
 {
+    last_display_x = x;
+    last_display_y = y;
     let font = settings.font.trim().replace(";","").replace("}","");
     if(font != "")
         font += ",";
@@ -954,6 +959,7 @@ async function settings_init()
         getvar("ignore_linebreaks", false);
         getvar("sticky", false);
         getvar("popup_follows_mouse", true);
+        getvar("popup_requires_key", 0);
         
         if(!settings.enabled && exists_div())
             delete_div();
@@ -1284,8 +1290,23 @@ function grab_text(textNode, offset, elemental)
     return [text, moreText, index];
 }
 
+let last_seen_event = undefined;
+let shift_down = false;
+let ctrl_down = false;
 function update(event)
 {
+    if(!event) return;
+    last_seen_event = event;
+    
+    if((settings.popup_requires_key == 2 && !shift_down)
+    || (settings.popup_requires_key == 1 && !ctrl_down))
+    {
+        function sqr(n) {return n*n;}
+        if(Math.sqrt(sqr(last_display_x-event.pageX) + sqr(last_display_y-event.pageY)) > 20)
+            lookup_cancel();
+        return;
+    }
+    
     if(!settings.enabled) return;
     
     if(settings.popup_follows_mouse && exists_div() && !settings.sticky && platform != "android")
@@ -1523,6 +1544,18 @@ function keytest(event)
 {
     if(event.target != document.body)
         return;
+    if(settings.popup_requires_key == 2 && event.key == "Shift")
+    {
+        shift_down = true;
+        update(last_seen_event);
+        return;
+    }
+    if(settings.popup_requires_key == 1 && event.key == "Control")
+    {
+        ctrl_down = true;
+        update(last_seen_event);
+        return;
+    }
     if(event.shiftKey || event.ctrlKey || event.metaKey || event.altKey)
         return;
     if(event.key == "m")
@@ -1592,17 +1625,29 @@ function keytest(event)
         settings.sticky = !settings.sticky;
         browser.storage.local.set({"sticky":settings.sticky});
     }
-    if(event.keyCode == 37) // left
+    if(event.key == "ArrowLeft")
     {
         lookup_left();
     }
-    if(event.keyCode == 39) // right
+    if(event.key == "ArrowRight")
     {
         lookup_right();
     }
 }
 
+function keyuntest(event)
+{
+    if(event.key == "Shift")
+        shift_down = false;
+    if(event.key == "Control")
+        ctrl_down = false;
+    if(event.key == "Alt")
+        alt_down = false;
+    
+}
+
 window.addEventListener("mousemove", update);
 window.addEventListener("keydown", keytest);
+window.addEventListener("keyup", keyuntest);
 document.addEventListener("touchstart", update_touch);