Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

Core/Misc: Remove incorrect (and unused) equality operator overloads from LinkedListHead::Iterator class

Browse Source
This commit is contained in:
Shauren authored and Ovahlord committed 2023-10-18 22:04:11 +02:00
1 parent 2e2a928204
commit 031e41c94e
2 files changed
+4 -36
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/server/game/Maps/Map.cpp
+1 -1
View File
@@ -3207,7 +3207,7 @@ Transport* Map::GetTransport(ObjectGuid const& guid)
void Map::UpdateIteratorBack(Player* player)
{
if (m_mapRefIter == player->GetMapRef())
if (&*m_mapRefIter == &player->GetMapRef())
m_mapRefIter = m_mapRefIter->nocheck_prev();
}
src/server/shared/Dynamic/LinkedList.h
+3 -35
View File
@@ -160,7 +160,7 @@ class LinkedListHead
{ // construct with null node pointer
}
Iterator(pointer _Pnode) : _Ptr(_Pnode)
explicit Iterator(pointer _Pnode) : _Ptr(_Pnode)
{ // construct with node pointer _Pnode
}
@@ -206,40 +206,8 @@ class LinkedListHead
return (_Tmp);
}
bool operator==(Iterator const &_Right) const
{ // test for iterator equality
return (_Ptr == _Right._Ptr);
}
bool operator!=(Iterator const &_Right) const
{ // test for iterator inequality
return (!(*this == _Right));
}
bool operator==(pointer const &_Right) const
{ // test for pointer equality
return (_Ptr != _Right);
}
bool operator!=(pointer const &_Right) const
{ // test for pointer equality
return (!(*this == _Right));
}
bool operator==(const_reference _Right) const
{ // test for reference equality
return (_Ptr == &_Right);
}
bool operator!=(const_reference _Right) const
{ // test for reference equality
return (_Ptr != &_Right);
}
pointer _Mynode()
{ // return node pointer
return (_Ptr);
}
bool operator==(Iterator const& _Right) const = default;
// test for iterator equality
protected:
pointer _Ptr; // pointer to node