Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

Core/GOs: Correct type of lowGuid when loading gameobject_addons

Browse Source 
Coverity IDs: 1302436 1302437 1302438

Issue introduced in 95b5e35745
This commit is contained in:
DDuarte committed 2015-06-01 02:09:45 +01:00
1 parent 1e54097084
commit 08b8dd10d1
2 files changed
+5 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

sql/updates/world/2015_06_01_00_world.sql
+1
View File
@@ -0,0 +1 @@
ALTER TABLE `gameobject_addon` MODIFY `guid` int(10) unsigned NOT NULL DEFAULT '0';
src/server/game/Globals/ObjectMgr.cpp
+4 -4
View File
@@ -1057,12 +1057,12 @@ void ObjectMgr::LoadGameObjectAddons()
{
Field* fields = result->Fetch();
ObjectGuid::LowType guid = fields[0].GetUInt64();
ObjectGuid::LowType guid = fields[0].GetUInt32();
const GameObjectData* goData = GetGOData(guid);
if (!goData)
{
TC_LOG_ERROR("sql.sql", "GameObject (GUID: " UI64FMTD ") does not exist but has a record in `gameobject_addon`", guid);
TC_LOG_ERROR("sql.sql", "GameObject (GUID: %u) does not exist but has a record in `gameobject_addon`", guid);
continue;
}
@@ -1072,14 +1072,14 @@ void ObjectMgr::LoadGameObjectAddons()
if (gameObjectAddon.invisibilityType >= TOTAL_INVISIBILITY_TYPES)
{
TC_LOG_ERROR("sql.sql", "GameObject (GUID: " UI64FMTD ") has invalid InvisibilityType in `gameobject_addon`", guid);
TC_LOG_ERROR("sql.sql", "GameObject (GUID: %u) has invalid InvisibilityType in `gameobject_addon`", guid);
gameObjectAddon.invisibilityType = INVISIBILITY_GENERAL;
gameObjectAddon.InvisibilityValue = 0;
}
if (gameObjectAddon.invisibilityType && !gameObjectAddon.InvisibilityValue)
{
TC_LOG_ERROR("sql.sql", "GameObject (GUID: " UI64FMTD ") has InvisibilityType set but has no InvisibilityValue in `gameobject_addon`, set to 1", guid);
TC_LOG_ERROR("sql.sql", "GameObject (GUID: %u) has InvisibilityType set but has no InvisibilityValue in `gameobject_addon`, set to 1", guid);
gameObjectAddon.InvisibilityValue = 1;
}