Core/Players: Cleanup code in SendPreparedQuest (checks doing nothing...)

This commit is contained in:
Shauren committed 2013-03-21 21:01:52 +01:00
1 parent cf1c1cf992
commit d05aac03ae
1 file changed
+4 -10
+4 -10
View File
@@ -14729,22 +14729,16 @@ void Player::SendPreparedQuest(uint64 guid)
if (questMenu.Empty())
return;
QuestMenuItem const& qmi0 = questMenu.GetItem(0);
uint32 icon = qmi0.QuestIcon;
// single element case
if (questMenu.GetMenuItemCount() == 1)
{
// Auto open -- maybe also should verify there is no greeting
QuestMenuItem const& qmi0 = questMenu.GetItem(0);
uint32 questId = qmi0.QuestId;
Quest const* quest = sObjectMgr->GetQuestTemplate(questId);
if (quest)
// Auto open -- maybe also should verify there is no greeting
if (Quest const* quest = sObjectMgr->GetQuestTemplate(questId))
{
if (icon == 4 && !GetQuestRewardStatus(questId))
PlayerTalkClass->SendQuestGiverRequestItems(quest, guid, CanRewardQuest(quest, false), true);
else if (icon == 4)
if (qmi0.QuestIcon == 4)
PlayerTalkClass->SendQuestGiverRequestItems(quest, guid, CanRewardQuest(quest, false), true);
// Send completable on repeatable and autoCompletable quest if player don't have quest
/// @todo verify if check for !quest->IsDaily() is really correct (possibly not)