Core/Guild: HandleRoster should always have a valid session
This commit is contained in:
1 parent
03fbc0a69d
commit
e794e85969
2 files changed
+4
-12
No files matched your search
@@ -1303,7 +1303,7 @@ bool Guild::SetName(std::string const& name)
|
||||
return true;
|
||||
}
|
||||
|
||||
void Guild::HandleRoster(WorldSession* session /*= NULL*/)
|
||||
void Guild::HandleRoster(WorldSession* session)
|
||||
{
|
||||
// Guess size
|
||||
WorldPacket data(SMSG_GUILD_ROSTER, (4 + m_motd.length() + 1 + m_info.length() + 1 + 4 + _GetRanksSize() * (4 + 4 + GUILD_BANK_MAX_TABS * (4 + 4)) + m_members.size() * 50));
|
||||
@@ -1318,16 +1318,8 @@ void Guild::HandleRoster(WorldSession* session /*= NULL*/)
|
||||
for (Members::const_iterator itr = m_members.begin(); itr != m_members.end(); ++itr)
|
||||
itr->second->WritePacket(data, _HasRankRight(session->GetPlayer(), GR_RIGHT_VIEWOFFNOTE));
|
||||
|
||||
if (session)
|
||||
{
|
||||
TC_LOG_DEBUG("guild", "SMSG_GUILD_ROSTER [%s]", session->GetPlayerInfo().c_str());
|
||||
session->SendPacket(&data);
|
||||
}
|
||||
else
|
||||
{
|
||||
TC_LOG_DEBUG("guild", "SMSG_GUILD_ROSTER [Broadcast]");
|
||||
BroadcastPacket(&data);
|
||||
}
|
||||
TC_LOG_DEBUG("guild", "SMSG_GUILD_ROSTER [%s]", session->GetPlayerInfo().c_str());
|
||||
session->SendPacket(&data);
|
||||
}
|
||||
|
||||
void Guild::HandleQuery(WorldSession* session)
|
||||
|
||||
@@ -661,7 +661,7 @@ public:
|
||||
bool SetName(std::string const& name);
|
||||
|
||||
// Handle client commands
|
||||
void HandleRoster(WorldSession* session = NULL); // NULL = broadcast
|
||||
void HandleRoster(WorldSession* session);
|
||||
void HandleQuery(WorldSession* session);
|
||||
void HandleSetMOTD(WorldSession* session, std::string const& motd);
|
||||
void HandleSetInfo(WorldSession* session, std::string const& info);
|
||||
|
||||
Reference in new issue
Block a user