Commit Graph
26582 Commits
Author SHA1 Message Date
Ovahlord 0527bbdc0c Scripts/GB: updated Forgemaster Throngus' scripts to new model, improved the internals and removed a few now deprecated spell scripts 2022-03-30 22:00:12 +02:00
Ovahlord c71d626b42 Scripts/FL: keep Majordomo Staghelm active for the time being to prevent grid unloading to accidentally despawning him.
* we need a better solution for that. For example by re-introducing spawn point manipulation on a per-map base so we can update his respawn point properl
2022-03-29 22:02:49 +02:00
Ovahlord 4d3ffb2947 Scripts/FL: update Lord Rhyolith's orientation right away since we need it right away rather than when the spline updates 2022-03-29 21:46:52 +02:00
Ovahlord 2443d48081 Core/Creatures: no longer restore stored orientation values after a spell focus expires since there is no evidence, that this is ever being used on retail 2022-03-29 21:46:16 +02:00
Ovahlord 2fefbe8a0c Scripts/Misc: updated Flame Orb scripting modes and assign new AI type since orbs are no longer considered pets 2022-03-28 23:35:51 +02:00
Ovahlord 82c9e10a2a Core/Spells: restore handling for src_area_x channel target selection 2022-03-28 22:51:41 +02:00
Ovahlord a82fe54bb7 Core/Skills: assign loaded skills that have been marked as forbidden to a proper skill position to avoid interfering with legit skills
closes #332
2022-03-25 11:37:52 +01:00
Ovahlord f573f1f8e3 Core/Packets: converted CMSG_LOADING_SCREEN_NOTIFY to packet class 2022-03-22 12:41:48 +01:00
Ovahlord ca9f34574d Core/Misc: fixed a bunch of GCC warnings 2022-03-21 21:32:41 +01:00
Ovahlord 9c88c6ea91 Core/Spells: fixed a typo in Atonement's spell script that was added when porting the CastSpell unclusterfucking 2022-03-17 22:41:58 +01:00
Ovahlord 77db3bf2df Core/Spells: Empowered Shadow's DoT bonus will multiply increase per stack of Shadow Orb 2022-03-12 20:29:21 +01:00
Ovahlord 7a2e26d42e Core/Random: use std::bernoulli_distribution for roll_chance_ calls to get more reliable roll results for yes-no scenarios 2022-03-10 23:10:49 +01:00
Ovahlord 5f2b1e45e4 Core/Spells: improve integer to float conversions and checks for spell proc entries 2022-03-10 20:43:12 +01:00
Ovahlord fd22ea32e6 Core/Spells: merged master version of checking for cast immunities 2022-03-10 20:41:47 +01:00
robinsch ae97821c78 Tool/MMAP: Fixed invalid check causing certain tiles not to build (#27833)
example: mmaps_generator 230 will cause tile 33, 29 to not build because of the check. causing NPCs to not have mmap information in some parts of the map.

.go xyz 1380 -831 -88 230 has no mmap tile information because of above check.
https://i.imgur.com/Pypeu4f.png
# Conflicts:
#	src/tools/mmaps_generator/MapBuilder.cpp
2022-03-04 14:43:21 +01:00
Ovahlord 2aee19fc86 Core/Movement: ported MotionMaster::MoveJumpWithGravity implementation from master branch and cut off post Cataclsym features 2022-02-24 19:37:05 +01:00
Ovahlord ce9da3a209 Core/Spells: integrated Long Arm of the Law's mechanic into the Judgement spell script and removed the proc entry
* updated some proc entries while at it
2022-02-24 14:14:16 +01:00
Ovahlord 1534ede45a Core/Spells: updated proc flags for Cataclysm 2022-02-23 21:17:52 +01:00
Ovahlord f641bcb2d1 Core/Spells: resolved a cherrypick error 2022-02-22 21:51:21 +01:00
Shauren c307969695 Core/Spells: Changed channel triggered spells to inherit positive/negative status from main spells 2022-02-22 21:24:49 +01:00
Ovahlord 78896a132f Core/Spells: ported proc flag updates from master branch 2022-02-22 21:19:09 +01:00
Ovahlord e83c5955b4 Core/Spells: moved Improved Devouring Plague to spell script and fixed the damage effect 2022-02-22 12:57:29 +01:00
Ovahlord 1c56faaa2c Core/Guids: refactored more range based loops to reduce copying elements of containers 2022-02-21 20:36:49 +01:00
Ovahlord 639799c7ed Scripts/LCT: make sure that High Prophet Barim stops moving when he is about to cast Repentance 2022-02-21 19:46:46 +01:00
Ovahlord 80881f898c build fix 2022-02-21 14:55:09 +01:00
Ovahlord 7bf3379df5 warning fixes 2022-02-21 14:43:50 +01:00
Ovahlord a204e9c61a Core/Units: some minor refactors to reduce the amount of container element copies and improved some array initializations 2022-02-21 14:31:46 +01:00
Ovahlord a652191a62 Core/Spells: 6506e71a23 followup 2022-02-21 13:49:17 +01:00
Ovahlord 6506e71a23 Core/Units: added a helper to check if a limited target aura exists without creating an empty element in the container 2022-02-21 13:44:24 +01:00
Ovahlord f97f57c0f6 Core/Spells: Nether Vortex will now only proc its Slow effect only when the mage has no other Slow auras applied 2022-02-21 11:59:42 +01:00
Ovahlord 6e412b16de Core/Spells: correctly implement Elemental Oath 2022-02-21 11:17:41 +01:00
Ovahlord d712a12f1c Core/Spells: use correct macro for tree of life stance requirement 2022-02-21 10:53:32 +01:00
Ovahlord 97a79175fc Core/Spells: added a bunch of default ctors for several spellMgr structs to silence uninitialized member warnings 2022-02-21 10:50:00 +01:00
Ovahlord 06f6987e2a Core/Spells: allow Rupture's damage to scale with combo points as well 2022-02-21 10:21:43 +01:00
Ovahlord f01012aac9 Core/Spells: corrected the finishing move spell attributes for Rupture and Expose Armor 2022-02-21 10:16:30 +01:00
Ovahlord d53fb14cbb Core/Creatures: no longer initialize CharmInfo for minions on creation. Unit::SetCharmed takes care of non-guardian initialization
closes #334
2022-02-21 09:42:41 +01:00
funjoker 429584e5b8 Tools/Patcher: no hardcoded jump 2022-02-20 23:34:01 +01:00
funjoker 10e7828dbc Tools/Patcher: Fix incorrect Mac64 pattern and patches 2022-02-20 22:06:22 +01:00
Shauren 5ad23e61e4 Dep: Raise required boost versions to 1.73 on windows and 1.71 on linux and remove compatibility code for unsupported versions
# Conflicts:
#	dep/boost/CMakeLists.txt
2022-02-20 20:27:35 +01:00
Ovahlord bbcd74d671 Scripts/FL: disable Heart of Ragnaros spell cast on encounter completion until it is handled to avoid spawning hearts at the location of every npc in the raid 2022-02-20 20:21:30 +01:00
ccrs 3499ffa187 Core/Petition: add missing increment on RemovePetitionsByOwnerAndType iteration
(cherry picked from commit aa86dfddca8f1fcb6b77fc1a37f367978c593018)
2022-02-16 05:00:59 +01:00
xinef1 e5f3de026f Core/Misc: implemented petition manager (#19010)
- Implemented manager for petitions to perform all petition related tasks and synchronize data with database.
- This kills ugly synchronous querys on packet handlers

(cherry picked from commit a4aa95a5a39d75b9e38fe03aac57ceb7d9bba90f)
2022-02-16 04:59:12 +01:00
ariel- cb168a8e7e Core/Unit: fix crash on magic school autoattacks
Closes #19436

(cherry picked from commit 0b50ea072e504ac7d5bf87b08d564955785f7197)
2022-02-16 04:49:24 +01:00
jackpoz 8746d9f56a Core/Misc: Fix static analysis issues
(cherry picked from commit 486b03234304526d8f7d66ff0d99ea3de975745e)
2022-02-16 04:49:24 +01:00
ariel- 4c658cf2da Revert "Core/Spell: don't set scaleAura for some special spells"
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e.

Closes #19472

(cherry picked from commit c296d255e25a2d0eb7155f64eea32cc36fed280a)
2022-02-16 04:49:24 +01:00
ariel- 5ad31dcf55 Core/Unit: fix SPELL_AURA_MOD_DAMAGE_DONE damage calculation on non-melee schools
for Keader :P

(cherry picked from commit 66ac1509ae925edc8848cdf6c370f8ed52c688ec)
2022-02-16 04:49:24 +01:00
ariel- d441e864c4 Core/Unit: cleanup and minor fixes of miss and resist calculations
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel
- Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does
- Fix melee miss chances calculated from attacker maxskill instead of victim maxskill
- Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0)
- Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance
- Minor codestyle and cleanup of diminishing returns calcs

(cherry picked from commit e565b34f6d24411e210151d0d03e524f94cdff85)
2022-02-16 04:49:24 +01:00
ariel- 0e8422c30a Core/Misc: fix static analysis issues
CID 1373466
CID 1373481
CID 1373482

(cherry picked from commit e478434146fd479fab955aaa80eb925c15e29809)
2022-02-16 04:49:24 +01:00
ariel- 58745ed8cc Core/AHBot: fixed assert check
(cherry picked from commit c36854677c4cef0c83a81afa23b45ba322d354cc)
2022-02-16 04:49:24 +01:00
ariel- 14a95ff976 Core/Spell: don't set scaleAura for some special spells
Closes #14541

(cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
2022-02-16 04:49:24 +01:00