Commit Graph
172 Commits
Author SHA1 Message Date
Vincent-Michael 08c1a81096 Scripted/Misc: Fix random stuff 2013-07-15 01:01:37 +02:00
Vincent-Michael e464d2bd2c Scripted: Some cleanups + ninja changes 2013-07-08 21:15:23 +02:00
Nay 3561ab98ba Misc: Use override and final C++11 keywords in a few places (mostly scripts)
OVERRIDE and FINAL are TC macros (expand to nothing if compiler does not  support C++11)
2013-07-06 20:21:45 +01:00
Vincent-Michael 6079f369af Scripted/Misc: Some cleanup 2013-07-06 01:00:05 +02:00
Vincent-Michael b4d4e04f53 Scripts/Misc: Rename creatures with mob_ / mobs_ in npc_
Note: Have fun :P
2013-07-04 22:11:47 +02:00
Vincent-Michael e6185c92fc Scripts: Convert DoCast(me->GetVictim(), SPELL_XXXXX); in DoCastVictim(SPELL_XXX); 2013-06-22 16:53:13 +02:00
Shauren b6aadc6698 Scripts/Misc: Use new movement flag setting methods in scripts 2013-06-18 16:48:46 +02:00
Malcrom ec474a62e5 Core: More Function Renaming. 2013-06-11 21:25:12 -02:30
Malcrom 66978cfc3b Core: Some function renaming. 2013-06-11 19:54:27 -02:30
Subv 25acef2572 * Batch of fixes for issues found by static analysis. 2013-05-17 21:11:18 -05:00
Shauren 8be181c7e6 Core/Misc: Fixed a bunch of issues found by static analysis 2013-05-17 20:39:53 +02:00
Spp 1a6a23ec96 Core/Misc: Minor optimizations (+code changes to reduce differences with 4.3.4 branch)
Core/Logging: Create new logger type "Cheat". Will be used to log all cheat attempts
2013-03-25 13:26:48 +01:00
Spp d091097433 Core/AI: Do not expose internal storage of SummonList 2013-03-21 11:06:05 +01:00
Trista df25ccb30d Scripts/Eye of Eternity: Last stability changes
* Release button bug should be now really fixed, if someone manage to get it due to some server delay, it can be hit by typing "RepopMe()" or "Reload". It's now only clientside issue that I couldn't reproduce.

* Before there was a chance for transition to phase III to break if hit at precise moment. On top of that, if SoP was to be executed there was no time for purple dimension change. (Note: If transiton happen while SoP is cast it will get specific client data and dimension light will stay changing that is hard to hit, but is blizz bug.)
2013-03-10 03:30:34 +02:00
Vincent_Michael d2024c5c05 Core: Fix build 2013-03-09 04:54:58 +01:00
Trista 8e44b2d4a6 Scripts/Eye of Eternity: Remove some uneeded check and last to do that is uneeded after last GO changes
* also repair some broken GO data for 3.3.5a.
2013-03-09 05:32:02 +02:00
Nefarion 49fd11ab5a First step of comment style refactoring to doxygen-style. 2013-03-08 21:55:37 +01:00
Trista 2dbe3d6cfe Scripts/Eye of Eternity: Fix not being able to press release button on death during phase III 2013-03-08 19:18:19 +02:00
Spp 377cfdb560 Core/RBAC: Fix multiple permissions and remove multiple config options that are currently implementes by RBAC
- Remove config options: CONFIG_ALLOW_TWO_SIDE_INTERACTION_CHAT, CONFIG_ALLOW_TWO_SIDE_INTERACTION_MAIL, CONFIG_GM_LOG_TRADE, CONFIG_ALLOW_TWO_SIDE_ACCOUNTS, CONFIG_ALLOW_TWO_SIDE_WHO_LIST, CONFIG_ALLOW_GM_FRIEND, CONFIG_ALLOW_TWO_SIDE_ADD_FRIEND, CONFIG_SILENTLY_GM_JOIN_TO_CHANNEL
- Fix RBAC_PERM_SKIP_CHECK_CHAT_SPAM (Was checking spam for those that had the permission)
- Only check RBAC_PERM_TWO_SIDE_INTERACTION_CHAT for sender of whispers (Restores GM being able to whisper players)
- Only check RBAC_PERM_TWO_SIDE_INTERACTION_MAIL for sender
- Fix .ticket assign <Player>, with last RBAC change it was changed by mistake from Player to Account
2013-03-08 13:15:25 +01:00
Trista 8993eef723 Scripts/Eye of Eternity: Fix vehicle crashes
* I tought if a spell would hit all targets on map then the force cast would be cast for each, apparently I was wrong since it had unlimited implicit targets.
* Remove a condition with target mask players since there is a attribute that takes care of that.

Closes #9365
2013-03-07 04:54:57 +02:00
Trista 7508e8cf65 Scripts/Eye of Eternity: Correct failed approach for hook target handling
* thx to Shauren
2013-03-06 11:05:11 +02:00
Trista a79143fc88 Scripts/Eye of Eternity: Fix Arcane Barrage handling and a lot other mechanics
* Nexus Lords had a bit imba timers on Arcane Shork, sorry for it wrong information. Now have retail timers.
* Scion of Eternity Arcane Barrage had wrong timers also for intial random cast and for each after. They were a bit lower.
* Implemented source mechanic that will always differ target of cast X to target of next cast. All rest is % chance based on various cases can happen.
* Removed condition for Arcane Overlaod bubbles now aura will never ("disappear"), if two are at one place they will override each other, but damage will never be leaked test enough times so don't bother stating opposite. Damage in ALL cases is reduced.
* Made Malygos range outside of platform a bit shorter to match retail real distance that also fixed timings of bubble mechanic, now they will always be there, if you are fast enough.
* And finally fixed some slight stuff on Malygos spell. Now all will work and Arcane Storm has it's correct visual mechanic again.

Closes #9321
2013-03-06 04:10:26 +02:00
Shauren 6b37c8d9f3 Scripts/Eye of Eternity: Fixed some silly code 2013-03-04 16:47:12 +01:00
Trista a108a9026a Scripts/Eye of Eternity: Rewrite Arcane Barrage mechanic
* Note that even after last changes happens I'm not sure exactly how the timers are controlled. The wipe chance should be a lot smaller now.. Any further change I can think of is beyond what I see. The main problem is currently. In theory there is chance, If timers get to be same with delay lesser than 2 seconds and if target randomisations select same target for shit out of luck reason. And if starting different timers were matching you can be hit atleast 2-3 times and on 25 mode maybe more. The timers are not with fixed difference for sure is all I know.
2013-03-03 03:16:17 +02:00
Trista d1853f693b Scripts/Eye of Eternity: Remove some flags, fix some timers and some misc
* Starting timers were a bit slower
* Destroy platform proper timing for drake casting mount spell to player (trigger)
* Remove IMMUNITY_PC flag after Iris is triggered (thx to Expecto) and readd it on evade
* Remove NOT_SELECTABLE flag since shouldn't be present at starting event
* Fix misc of id of Static Field added to LOS attributes
2013-03-01 16:25:58 +02:00
Trista 4f40dad714 Scripts/Eye of Eternity: Surge of Power (25 man)
* I have no idea how these breaks were removed, but it was breaking the whole mechanic.
* Also fix some slight chance for fail of transitioning p II -> p III
* Surge of Power (25 man) still needs to get fixed some weird facing and warnings aren't always sent for some reason
2013-03-01 09:33:52 +02:00
Vincent_Michael 6343a28030 Core: Whitespace cleanup 2013-02-28 18:29:43 +01:00
Trista 6801314881 Scripts/Eye of Eternity: Rewrite most of it.
Closes: #1133,  #8212, #1150, #5003, #6794

* More stuff will be done, a lot to clean maybe, as of raiding it's good to go now pretty much*.
* Big thx to Shauren, Horn, manuel, Machiavelli, Nay, Krofna and rest who helped.
2013-02-28 18:44:07 +02:00
Shauren 5b414bb813 Core/Scripts: Removed useless const modifier on method parameters accepting primitive types passed by value 2013-02-19 17:35:27 +01:00
m7nu3l f9654d52e0 Core/AI: Removed Scripted_NoMovementAI which has become obsolete. Use ScriptedAI::SetCombatMovement(false); to get the same functionality. 2013-02-04 19:18:48 -03:00
Spp 802657250c Core/Misc: Apply codestyle to multiple files 2013-01-14 09:50:59 +01:00
Nay 8ac5b3b7d6 Core/Player: Prevent a crash in CastedCreatureOrGO and add an assertion to KilledMonster 2013-01-04 21:15:18 +00:00
Malcrom dbfc4b83aa Core/Scripting: Some file name updates. 2013-01-02 15:08:13 -03:30
Spp 2292025bf9 Core/Misc: Replaced some macro definitions with inline functions 2013-01-02 09:07:52 +01:00
Trista 423fb04270 Script/EoE: Some fixes here and there
* Add db support for Power Sparks, Teleports and Drakes
* Fix Power Sparks animations and texts and add support for giving buff to players + warning
* Fix Power Spark way of stacking - should be MultiSlot aura, didn't stack before either way
* Teleporters mechanic is fixed and will summon only 1 spark per 30-35 sec
* Fixed players getting mounted on 3rd phase
* Cleanned some wrong aggro handling, but whole aggro/attack system should be rewritten to get it working blizz
That is for today, this doesn't fix the whole instance by any means!
2013-01-02 06:35:28 +02:00
Vincent_Michael cc65aba789 Update copyright note for 2013.
Happy new year.
2013-01-01 00:41:01 +01:00
Vincent_Michael 1e22367ca4 Core/Scripts: Add missing creature_text for eregos 2012-12-08 01:18:26 +01:00
Vincent-Michael 40b010e3ad Misc/Scripts: Some fixes for creature_text 2012-12-04 20:12:48 +01:00
Gacko 33c44594cd Core/DB: Creature text for 26 script files 2012-12-03 22:10:18 +01:00
Spp 7bef4ce401 Core/Misc: Reduce header dependencies - Step III 2012-11-20 15:03:56 +01:00
Spp 81606e5d1e Core/Misc: Define some methods const 2012-11-20 09:29:52 +01:00
Gacko 45b07f0931 Scripts&DB: Nexus - Ormorok
Following improvements:
- Spellscript for crystal spikes
- Spawn crystal tanglers with spell
- Usage of event map
- Correct usage of frenzy
- Heroic spells
- Target selection for crystal tanglers

Details for the spell script:
There are 4 spells. Each of them spawns the same trigger but in another direction. The trigger gets an aura which triggers the spell which summoned him after 250ms. This time is too long, so it triggers on apply. Don't worry - test ingame first, it's working blizzlike (I watched some videos on YT to find out which is the best amount of time difference between spawn and next summon).

Some summon types don't store the spell id which summoned them. The trigger is one of them which are not doing so. So I had to move the line, which stores the spell id in the summon out of the if. This could be done more specific, but it works fine. This improvement is required to find out which spell the aura applied to the summoned trigger has to cast to keep the right direction.

Closes #8193

Signed-off-by: Nay <dnpd.dd@gmail.com>
2012-11-18 23:46:03 +00:00
Spp b99c347747 Core: Remove Player.h dependency from all the possible headers 2012-11-17 05:18:37 +01:00
Spp 876ad50dcd Core/Misc: Tweaked ThreatContainer internals
(and many cosmetic changes here and there)
2012-10-26 14:31:19 +02:00
Spp 663db1cee3 Core/Misc: Add default count param to HasItemCount 2012-10-23 13:11:57 +02:00
Spp d0334bf948 Core/Dungeon Finder: Some optimizations.
- Store teleport coordinates to avoid recalculations each time someone has to be teleported
- Correct teleport error msg when player is charming or using vehicle
- Internal changes in storage types
- Proper code for missing achievement lock type
- Better debug msgs
- Trying to get rid of "Player*" and "Group*" inside LFGMgr as much as possible (Step 1)
2012-10-18 09:15:10 +02:00
Nay d27a3955f0 Core/Misc: Tabs to spaces and whitespace cleanup 2012-10-06 16:55:01 +01:00
Kandera cef436e38e Core/Oculus: fix compile. 2012-10-04 09:26:10 -04:00
kandera 6a8706a725 Merge pull request #7944 from Trista/master
Scripts/Oculus: Fixes here and there, implement phasing
2012-10-04 05:58:32 -07:00
Nay 880a9d5cda Merge pull request #7954 from Retriman/Nexus
Core/Script: Dungeon Nexus Boss Anomalus
Closes #7946
2012-10-03 04:43:22 -07:00