Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
30,447 Commits 2 Branches 1 Tag
1106eadac6df7d94de04f9f1642d53f37ca847bc
Commit Graph
30447 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Malcrom 1339d38d4c DB/SAI: Fix some duplicate aura errors and clean up the SAI. 2013-12-16 20:23:29 -03:30
Malcrom b8f9442ec9 Core/Player: Fix logic for questgiver cast spell 2013-12-16 18:50:51 -03:30
jackpoz b3c810a0fb Core/Misc: Fix warning 
Partially revert f0a742a8c4 to fix a warning about unhandled switch case (the same case that Coverity reported as dead code) .
 2013-12-16 19:52:50 +01:00
jackpoz b8908606fc Core/AH: Fix memory leak 
Fix memory leak in Auction House when creating an auction with stackable items and a stack of the same amount in the inventory. Leak added in 15a2acfb52 .
 2013-12-16 19:38:49 +01:00
Malcrom f1a82a578b Core/Waypoints: Stop creatures from skipping at waypoint nodes 
and add smoothing to pathing.
 2013-12-15 20:26:11 -03:30
jackpoz e90a7f82d4 Core/AI: Fix CreatureAI left uninitialized 
Fix CreatureAI left uninitialized for 1 server tick for Creatures with DeathState:DEAD . This is a workaround required after c9cf2f059f changes .

Valgrind log:
 Conditional jump or move depends on uninitialised value(s)
  at : npc_draenei_survivor::npc_draenei_survivorAI::MoveInLineOfSight(Unit*) (zone_azuremyst_isle.cpp:104)
  by : CreatureAI::MoveInLineOfSight_Safe(Unit*) (CreatureAI.cpp:123)
  by : CreatureUnitRelocationWorker(Creature*, Unit*) (GridNotifiers.cpp:134)
  by : Trinity::AIRelocationNotifier::Visit(GridRefManager<Creature>&) (GridNotifiers.cpp:252)
 Uninitialised value was created by a heap allocation
  at : operator new(unsigned long) (vg_replace_malloc.c:319)
  by : npc_draenei_survivor::GetAI(Creature*) const (zone_azuremyst_isle.cpp:66)
  by : ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:792)
  by : FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
  by : Creature::AIM_Initialize(CreatureAI*) (Creature.cpp:716)
  by : Creature::AddToWorld() (Creature.cpp:190)
 2013-12-15 21:14:47 +01:00
Malcrom 9dd30ac5ff DB/Creature: Misc template updates 2013-12-15 14:35:15 -03:30
jackpoz dd4a774c4c Core/Transports: Fix memory leak on shutdown 
Fix world transports not being deleted on shutdown.
 2013-12-15 18:51:34 +01:00
Malcrom a2e7191b26 Core/Unit: prevent COMMAND_ATTACK being added for Trained Rock Falcon. 
Also added spells for Trained Rock Falcon to db.
 2013-12-15 13:43:18 -03:30
jackpoz f0a742a8c4 Core/Misc: Remove unused code 
Remove unused debugging code added in MaNGOS r5067.
Remove dead code from a switch found by Coverity.
 2013-12-15 13:37:49 +01:00
w1sht0l1v3 89ee8cbac1 Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries. 2013-12-15 14:09:49 +02:00
Vincent_Michael f7aedaef33 Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4 
Conflicts:
	src/server/game/Battlegrounds/BattlegroundMgr.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Handlers/QuestHandler.cpp
	src/server/game/Spells/SpellInfo.h
	src/server/game/World/World.cpp
 2013-12-15 03:47:21 +01:00
Malcrom dcfbe53552 Core/Player: Fix questgiver spell cast. 2013-12-14 20:22:39 -03:30
joschiwald d5f6c2e2a2 Merge branch 'master' of github.com:TrinityCore/TrinityCore 2013-12-14 19:45:01 +01:00
joschiwald f5c2dca1d5 Scripts: fix crash in spell_jokkum_scriptcast 
Closes #11313
 2013-12-14 19:43:29 +01:00
Discover- e17af3f203 Core/Quests: Fix an issue where auto-completed quests would not be automatically completed if the quest was added through either the SmartAI action_type SMART_ACTION_ADD_QUEST, the spell effect SPELL_EFFECT_QUEST_START or the opcode CMSG_QUEST_CONFIRM_ACCEPT. Also fixes auto-complete quests in the SAI and opcode case not calling the AI hook. 2013-12-14 19:42:31 +01:00
Discover- ec8e94c6ac Core/AI: Fix an issue where the OnQuestAccept hooks were not called for auto-completed quests. 
Fixes #11304
 2013-12-14 19:39:47 +01:00
jackpoz ca6b9df261 Core/Misc: Fix some static analysis issues 
Fix some static analysis issues about uninitialized values.
 2013-12-14 19:36:43 +01:00
jackpoz 1c0903e286 Core/Misc: Fix some static analysis issues 
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed, while some of them are real issues spotted by valgrind too.
 2013-12-14 18:41:26 +01:00
Malcrom dd546f073a Core/Player: Add another exception to questgiver spell casting. 2013-12-14 14:05:24 -03:30
jackpoz e28cc4660b Core/Movement: Fix invalid memory access 
Fix the stack implementation used in MotionMaster and added few sanity checks to ensure no underflows will be made.

Valgrind log:
 Invalid read of size 8
  at : MotionMaster::top() const (MotionMaster.h:115)
  by : MotionMaster::pop() (MotionMaster.h:91)
  by : MotionMaster::~MotionMaster() (MotionMaster.cpp:74)
  by : Unit::~Unit() (Unit.cpp:296)
  by : Player::~Player() (Player.cpp:880)
  by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:665)
  by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:516)
 2013-12-14 16:51:47 +01:00
Malcrom 9d9d1fb6c6 DB/SAI: Fix an error in Bladespire Mystic SAI 2013-12-14 09:35:36 -03:30
Discover- 4ca63412c8 Core/SmartAI: SMART_ACTION_UPDATE_TEMPLATE will no longer ignore the target type and force the source creature (creature only) to be updated; from now on it updates the given targets to the given entry (actionparam1) 2013-12-13 09:45:58 +01:00
Malcrom c045d4c7f4 Core/SmartAI: Reset Actions will not be processed until creature reaches home. 2013-12-12 21:23:14 -03:30
d-sat 2f3cc24e7f Renamed method 2013-12-12 23:38:32 +01:00
Malcrom 9f741432a3 Core/AI: Some code cleanup 2013-12-12 18:09:07 -03:30
Malcrom 9d95351118 Core/SmartAI: Fixed issue where ranged caster would switch to combat ready state between cast. 2013-12-12 16:39:30 -03:30
Vincent_Michael 506ddbbf40 Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4 2013-12-12 19:36:48 +01:00
Ric101 a8484d2789 Core/Players: On CanRewardQuest, use the same item dest vector for all potential rewards 2013-12-12 14:53:35 +00:00
Aokromes 3cee0b7dc7 Merge pull request #11309 from Lartza/master 
DB/SAI: Fix typo
 2013-12-12 04:20:31 -08:00
Lartza d9dac7b9ca Fix typo 2013-12-12 13:46:22 +02:00
Shauren 54fd53f7e3 Core/Movement: Fixed possible invalid memory access 2013-12-12 09:50:52 +01:00
Malcrom 385e2dba37 DB/SAI: Fix one linking error and updated a few to use CMC "Combat Movement Control" 2013-12-11 17:07:59 -03:30
Vincent_Michael bb62a9180d Core: Fix build 2013-12-11 20:48:40 +01:00
Vincent_Michael 07024d3ea8 Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4 
Conflicts:
	src/server/game/DataStores/DBCEnums.h
	src/server/scripts/Commands/cs_wp.cpp
	src/server/scripts/EasternKingdoms/ZulGurub/boss_jindo.cpp
 2013-12-11 20:34:44 +01:00
Vincent_Michael fb26e18523 Core: Fix warnings 2013-12-11 20:30:15 +01:00
Malcrom e7e708eb0a DB/Misc: fixed comment in one SAI script. 2013-12-11 15:34:57 -03:30
Malcrom a20c89feee DB/Misc: Some Combat AI, Remove spawns, and aura fixes. 2013-12-11 15:32:59 -03:30
Malcrom 551e51bcb9 DB/Waypoints: Some Outlands waypoints. Mostly Blade's Edge. 2013-12-11 15:10:05 -03:30
joschiwald a40e814240 Core/SmartScripts: speedup loading/validating sai scripts from db 
Before:
>> Loaded 6953 SmartAI scripts in 3543 ms

After:
>> Loaded SmartAIMgr Helpers in 4 ms
>> Loaded 6953 SmartAI scripts in 95 ms
 2013-12-11 18:53:05 +01:00
Shauren 70445f34a6 Core/Items: Fixed possible invalid memory access when calculating armor 2013-12-11 16:31:15 +01:00
Shauren 488841dd2c Merge pull request #11306 from trickerer/fixaggro 
Don't allow units to enter combat upon death
 2013-12-11 00:40:46 -08:00
Malcrom fc7e335d3b Scripting/Obsidian Sanctum: Updated scripts to use Events. 2013-12-11 01:13:23 -03:30
trickerer 91ebea4a77 Don't allow units to enter combat upon death 2013-12-11 09:38:24 +07:00
joschiwald eddf1b5a64 Scripts: replace some SetOrientation() calls with spline packets and some random changes 2013-12-10 18:46:11 +01:00
joschiwald bb45db65a0 Merge pull request #11275 from Carbenium/UtgardePinnacle 
Scripts/UtgardePinnacle: Convert Svala Sorrowgrave to event system
 2013-12-10 07:29:00 -08:00
Carbenium 000bfbb732 Convert Svala Sorrowgrave to event system 2013-12-10 16:05:02 +01:00
Discover- e74b11b5fb Scripts/Misc: Fix compile after 755283ac8d 2013-12-10 09:24:28 +01:00
Malcrom 74facef60d Scripting/Storm Peaks: Renamed npc_brann_bronzebeard script because name has already been used. 2013-12-10 00:11:33 -03:30
Malcrom 6af40a28b1 DB/Misc: Mostly cosmetic for Storm Peaks with a few SAI updates. 
"It's like eye liner for your TC server"
 2013-12-09 23:35:37 -03:30