Commit Graph
2765 Commits
Author SHA1 Message Date
jackpoz 166e66cc06 Core/Spells: Fix crash happening when using items to cast spells
Fix a crash happening when using items casting spells like Item ID 37198
Fix #14900
2015-09-05 22:45:15 +02:00
StormBytePP 4ada913d02 Core/Unit: Prevent AoE damage to have effect in some cases when faction is unfriendly but they don't attack you and you don't have at war enabled (Example, Sporaggar faction)
Fixes #15374
2015-08-29 02:35:58 +02:00
StormBytePP 70f029fd0a Core/Unit: Do not remove aura with interrupt flag AURA_INTERRUPT_FLAG_NOT_UNDERWATER when already flying 2015-08-24 16:00:38 +02:00
David Carlos Manuelda 603f49a551 Merge pull request #15327 from Trisjdc/fix_rest_state
Core/Players: Improve rest state handling, allow several rest states to be active
2015-08-23 20:32:54 +02:00
joschiwald df21162fe4 Scripts/VioletHold: rewrote the whole instance
thanks @MitchesD for help
2015-08-23 14:43:11 +02:00
Trisjdc c14b66c24c Core/Players: Improve rest state handling, allow several rest states to be active
Fixes https://github.com/TrinityCore/TrinityCore/issues/15325
2015-08-23 10:47:16 +01:00
StormBytePP 424576e098 Core/Misc: Added checks for procSpell nullptr cases
Fixes Coverity Defect ID: 1023036
2015-08-20 16:29:36 +02:00
StormBytePP 0cc3d883e1 Core/Build: Renamed Revision.h to GitRevision.h to avoid compile failure when old revision.h file is present 2015-08-16 23:08:01 +02:00
StormBytePP 94f69fb1bc Core/Build: Removed obsolete SystemConfig.h and made genrev be part of shared library, which allows cache hits to happen more likely 2015-08-16 17:15:38 +02:00
DDuarte e1b534e40f Core/Object: Add changes to ObjectGuid from 6.x
copy and move cctor
assignment and assig move operators

Ref 81abfe93bb96e5a769dc855f06fdc7578b352b39 and 89a8a7e1a4bdc22d2da17b1a3bf34fd52bf87e85
2015-08-15 18:09:12 +01:00
Incorrect 071b2c68e8 Core/Misc: Add a few consts to methods 2015-08-12 22:49:21 +03:00
jackpoz ea4d9c0d9e Core/Misc: Remove unneeded ToCreature() casts
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet(), IsTotem(), IsSummon(), IsGuardian(), IsHunterPet() and IsVehicle() from Creature to Unit
2015-08-12 14:05:14 +02:00
jackpoz d243630acf Core/Misc: Remove unneeded ToCreature() casts
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet() from Creature to Unit
2015-08-12 12:48:33 +02:00
Rochet2 12931f4762 Core/RestState: Check area trigger radius instead of 1.0f distance
Closes #15016
Closes #15052

Signed-off-by: jackpoz <giacomopoz@gmail.com>
2015-08-10 18:12:22 +02:00
jackpoz 3f3ff8b36b Merge pull request #15119 from robinsch/grounding
Core/Spells: Grounding totem fix

Fixes #15108
2015-08-08 21:11:55 +02:00
jackpoz a8ceb18cdf Core/Gameobjects: Move a log from FATAL to DEBUG
The log is triggered when a mage creates a portal to another map, uses it and then the portal despawns.
2015-08-08 19:23:10 +02:00
jackpoz 143026ed19 Core/Spells: Fix damage done by SPELL_EFFECT_NORMALIZED_WEAPON_DMG
Fix a rare case that would cause SPELL_EFFECT_NORMALIZED_WEAPON_DMG to do 4 billions damage or to trigger an assertion in Unit::CalculateDamage() depending by Unit base damage.
To reproduce the issue cast spell 25816 on a level 1-14 warrior, then make the warrior cast spell 694 on a Creature.
2015-08-05 19:58:19 +02:00
Jameyboor b85b0c221b Fix UpdateMovementFlags ignoring DynamicTree height. 2015-07-26 15:08:33 +02:00
Vincent-Michael d2d4bc2668 Core: Header cleanup in game/*/*.cpp
(cherry picked from commit 2e586bc520e7eda2387e850c3c0049e6daa880de)

Conflicts:
	src/server/game/Battlegrounds/Battleground.cpp
	src/server/game/Battlegrounds/BattlegroundMgr.cpp
	src/server/game/Battlegrounds/Zones/BattlegroundBFG.cpp
	src/server/game/Battlegrounds/Zones/BattlegroundEY.cpp
	src/server/game/Battlegrounds/Zones/BattlegroundTP.cpp
	src/server/game/Chat/Chat.cpp
	src/server/game/Combat/ThreatManager.cpp
	src/server/game/DataStores/DB2Stores.cpp
	src/server/game/DataStores/DBCStores.cpp
	src/server/game/Entities/Creature/Creature.cpp
	src/server/game/Entities/Creature/GossipDef.cpp
	src/server/game/Entities/Object/Object.cpp
	src/server/game/Entities/Object/ObjectGuid.cpp
	src/server/game/Entities/Object/Updates/UpdateData.cpp
	src/server/game/Entities/Pet/Pet.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Player/Player.h
	src/server/game/Globals/ObjectAccessor.cpp
	src/server/game/Handlers/BankHandler.cpp
	src/server/game/Handlers/CombatHandler.cpp
	src/server/game/Handlers/GroupHandler.cpp
	src/server/game/Handlers/GuildHandler.cpp
	src/server/game/Handlers/ItemHandler.cpp
	src/server/game/Handlers/MiscHandler.cpp
	src/server/game/Handlers/MovementHandler.cpp
	src/server/game/Handlers/PetitionsHandler.cpp
	src/server/game/Handlers/QueryHandler.cpp
	src/server/game/Handlers/SpellHandler.cpp
	src/server/game/Handlers/TokenHandler.cpp
	src/server/game/Handlers/VoiceChatHandler.cpp
	src/server/game/Maps/Map.cpp
	src/server/game/Movement/Spline/MoveSplineInit.cpp
	src/server/game/Quests/QuestDef.cpp
	src/server/game/Server/Packet.cpp
	src/server/game/Server/Packets/SpellPackets.cpp
	src/server/game/Server/WorldSession.cpp
	src/server/game/Server/WorldSocket.cpp
	src/server/game/Spells/Auras/SpellAuraEffects.cpp
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellEffects.cpp
	src/server/game/Spells/SpellScript.cpp
	src/server/game/Warden/Warden.cpp
	src/server/game/Warden/WardenWin.cpp
	src/server/game/Weather/WeatherMgr.cpp
2015-07-25 21:53:30 +01:00
Shauren 130878c1a5 Core/Collision: Removed direct GameObject references from collision project
(cherry picked from commit a029f97c8231f7be188663d63f95f34dd1b4f9e1)

Conflicts:
	src/server/collision/Models/GameObjectModel.cpp
2015-07-25 16:22:33 +01:00
DDuarte d12fec67f2 Core/Misc: Add a few consts to methods
(cherry picked from commit 7d9843c380cf00f38ad0c5bc75fd387e50ee11da)

Conflicts:
	src/server/bnetserver/Packets/ConnectionPackets.h
	src/server/game/AI/SmartScripts/SmartAI.h
	src/server/game/Battlefield/Battlefield.h
	src/server/game/Battlegrounds/Battleground.h
	src/server/game/Entities/Object/Object.h
	src/server/game/Entities/Player/Player.h
	src/server/game/Guilds/Guild.h
	src/server/game/Instances/InstanceSaveMgr.h
	src/server/game/Support/SupportMgr.h
2015-07-24 12:02:57 +01:00
Shauren b4adf3f5dd Core/Misc: Fixing warnings detected by Visual Studio 2015 compiler
(cherry picked from commit a22e4e121a1e54b2f4154d59623ee4a94a449176)

Conflicts:
	cmake/compiler/msvc/settings.cmake
	src/server/game/DataStores/DBCStores.cpp
	src/server/game/Entities/GameObject/GameObject.cpp
	src/server/game/Entities/Object/Object.cpp
	src/server/game/Entities/Object/Object.h
	src/server/game/Entities/Pet/Pet.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Unit/Unit.cpp
	src/server/game/Garrison/Garrison.cpp
	src/server/game/Garrison/GarrisonMgr.cpp
	src/server/game/Globals/ObjectMgr.cpp
	src/server/game/Globals/ObjectMgr.h
	src/server/game/Guilds/GuildMgr.cpp
	src/server/game/Handlers/CharacterHandler.cpp
	src/server/game/Handlers/QueryHandler.cpp
	src/server/game/Handlers/QuestHandler.cpp
	src/server/game/Handlers/SpellHandler.cpp
	src/server/game/Server/Packets/ChannelPackets.h
	src/server/game/Server/Packets/PartyPackets.cpp
	src/server/game/Server/WorldSession.h
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellInfo.cpp
	src/server/game/Spells/SpellScript.cpp
	src/server/scripts/Commands/cs_list.cpp
2015-07-24 11:51:48 +01:00
pete318 9a4ccbaebd Learn death knight runeforging skill, when receving the spell book ability. (#13882) 2015-07-19 00:21:55 +00:00
robinsch f4b826002f #15108 2015-07-18 11:48:44 +02:00
mik1893 90fcfb3f2d Merge pull request #14974 from pete318/stealth_work
Stealth changes (Player stealthed vs NPCs) - 3.3.5
2015-07-15 18:43:19 +02:00
Rushor ab0c0b7cb8 Merge pull request #15092 from robinsch/shamanT10enhancement
Core/Spells:  Enhancement Shaman T10 4P bonus set 
closes #15090
2015-07-15 14:21:43 +02:00
robinsch 230df99434 Core/Spells: Enhancement Shaman T10 4P bonus set #15090 2015-07-15 12:04:22 +02:00
mik1893 ef4918d939 Merge pull request #14987 from robinsch/fixupSpellModDOT
Core/Spells: Revert changes to Unit.cpp done in 198ffba
2015-07-14 16:46:55 +02:00
DDuarte 57091cc5f1 CRLF to LF
Seriously....
2015-07-10 20:16:55 +01:00
jackpoz fae8269589 Core/Instances: Fix some Instance Lock chat messages
Always send a Welcome type Instance Lock chat message when entering an instance instead of changing type based on remaining time.
Fix scheduled warning message to always send "Your instance lock for ... will expire in 0 minutes." even if there are hours left, issue added in 4193806dba , closes #11519 .
Update warning messages based on remaining time so that the most meaning is always used (6 hours left, 59 minutes left, etc).
2015-07-08 23:32:04 +02:00
jackpoz 6681b3600c Core/Misc: Fix build warnings
Fix build warning reported by clang 3.6
2015-07-04 19:28:11 +02:00
pete318 1e0213bc57 The following stealth changes are implemented.
- Combat no longer removes stealth, only damage does
 - Creatures will pursue a stealthed unit they cannot see if they're already in combat with them
 - When a player is ~~3 yards~~ 8% + 1.5 yards away from the usual stealth detection distance, the creature will perform the "alerted" effect.
 - When sitting/sleeping creatures are distracted or alerted, they will stand up
 - Idle movement creatures will return to their original (spawn) orientation after distract/alert
 - When entering combat with a distracted/alerted creature, distract state is removed
 - NPC no longer have a limit to stealth visibility (granted by stealth modifier spells/buffs)
 - If alert visibility is greater than aggro range, no alert sent
2015-07-02 23:11:20 +00:00
jackpoz 55681666b3 Core/Misc: Fix build warnings 2015-07-01 20:57:20 +02:00
robinsch 2263cb9e10 Core/Unit: Fix issue with Divine Shield immunities
Closes #14910
2015-07-01 17:37:36 +02:00
robinsch 067b4c3243 Core/Spells: Revert changes to Unit.cpp done in https://github.com/TrinityCore/TrinityCore/commit/198ffba5ee3b64852b3b090ebdeebd87494cc9f6. This will fix issues with direct damage spells dealing wrong damage that are based on percentage of existing HOT or DOT auras due to missing SPELLMOD_DOT apply. 2015-07-01 16:04:37 +02:00
Shauren efad3a3123 Core/Spells: Implemented CAST_FLAG_IMMUNITY 2015-06-30 11:44:11 +02:00
Carbenium adb5d3ea5f Merge pull request #14941 from ShinDarth/db_backports3
DB/World schema backport: move questItem* fields to *_questitem tables
2015-06-29 20:03:11 +02:00
ShinDarth 1c0b0f825c DB/World schema backport: move questItem* fields to *_questitem tables 2015-06-29 19:21:00 +02:00
robinsch 7fbd035620 Core/WorldState: Send BATTLEFIELD_WG_WORLD_STATE_ACTIVE when sending initial world states for Wintergrasp. This will fix issue #14913 2015-06-29 10:49:43 +02:00
Mik1893 accab5451d Core/Creature: Fix UNIT_FLAG_IMMUNE_TO_PC validity for player pets
related to #14780 and #14744
2015-06-26 16:52:40 +02:00
Shauren 2538a84d0c Core/Units: Changed SPELL_AURA_MOD_MINIMUM_SPEED to always be applied, not only if under a slow aura (SPELL_AURA_MOD_MINIMUM_SPEED can set the minimum speed higher than base speed)
(cherry picked from commit d2142ac380863716ecea6f4aa44f7e556e44dfd9)
2015-06-26 01:26:22 +01:00
Shauren 5fe819462f Core/GameObject: Removed unneeded argument from GameObjectModel::Relocate and renamed it to UpdatePosition
(cherry picked from commit 6e9ab38fcc9d2859393e452ef8630ee420783e47)
2015-06-26 00:53:12 +01:00
ShinDarth f8230a59a9 DB/Characters: Backport schema changes from 6.x branch (renames)
Closes #14951
2015-06-26 00:28:32 +01:00
jackpoz cb4d1574e0 Core/Instances: Make achievements and loot rolls instance-wide
Make achievements, loot rolls, master loot at money loot instance-wide, removing the previous limit for 74.f yards
2015-06-24 22:40:57 +02:00
Rushor 8f3a9b7fe3 Game/GameObject: Fix Spellcast for 'Silithyst'
by @Whoami
updates #14637
2015-06-23 15:28:51 +02:00
MitchesD a35ec4c35a Core/Creature: fixed loading of creature auras on respawn, deathState needs to be set to ALIVE before trying to AddAuras (which fails with different deathState than ALIVE)
Closes https://github.com/TrinityCore/TrinityCore/issues/4150

(cherry picked from commit 530074f453c568dc4065994ad908d3bfc7388534)
2015-06-21 13:44:01 +02:00
jackpoz 81cec13a58 Merge pull request #14250 from xjose93/SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED
Core/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED

Fix SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED modifying speeds of bosses that are immune to changes of speeds.
2015-06-14 16:34:49 +02:00
xjose93 6f2b086048 Core/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED. 2015-06-14 13:45:29 +02:00
jackpoz d123c81162 Core/Texts: Fix race conditions in CreatureTextMgr repeat group
Fix race conditions in CreatureTextMgr repeat group happening with MapThreads > 1 reported by helgrind by moving Creature-GUID-base data from CreatureTextMgr to Creature.
Issues added in bbf86641a1
2015-06-13 12:27:19 +02:00
Carbenium fa6a063329 Core/Creature Fix compiler warning 2015-06-02 20:13:12 +02:00