Commit Graph
620 Commits
Author SHA1 Message Date
Kandera 17d87c0103 Core/Misc: researched the reasons for instance reset failure and added them as comments to the sendresetinstancefailed function. 2012-04-17 09:56:08 -04:00
Shauren 61cb2db1bd Core/Player: Removed _lastLiquid from Player class, no need to have it in both Unit and Player 2012-04-17 10:16:31 +02:00
Kandera bb97ff7601 Attempt on converting updatewaterstate for use with units (pets and vehicles) 2012-04-16 12:27:06 -04:00
Shauren 63ec9f2299 Core/Player: Send calendar raid lockout remove before removing player from instance save (may invalidate instance save) 2012-04-14 11:09:40 +02:00
Subv 98e1847999 Player/Items: Fix the item durations when the item is stored in a bag different than the default backpack
Closes #1026
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-04-13 18:58:27 -05:00
click a470a5ad93 Fix a typo in previous commit 2012-04-10 02:11:27 +02:00
click 5d7d635b9e Core: Add proper log output in Player::Create functions, warning admins about possible hackers during character creation 2012-04-10 02:06:10 +02:00
kaelima 3bbabb1400 Core/Spell: Fix crash when blinking on transports in instancable maps
Closes #789
2012-04-09 03:02:45 +02:00
kaelima 49e24e2dfb Core/Cleanup:
Mostly if(.. -> if (.. and for(.. -> for (..
but also some miscellaneous cleanup
2012-04-08 23:59:52 +02:00
Machiavelli e636531da3 Core/Movement: Fix pushback issues and client freeze. 2012-04-08 17:03:44 +02:00
Shocker cce6424337 Merge pull request #6001 from Tasssadar/master
Code style: Give field pointers in Player::DeleteFromDB() more appropriate name
2012-04-07 19:14:48 -07:00
kaelima a5a123197b Core/Item: Fix possible exploit stacking critical strike when switching weapons during disarm. Closes #3532 2012-04-08 03:12:40 +02:00
Nay 945566e84e Scripts/SM: Fix dead anymation of Fairbanks
Patch by DennisRassmann (25/10/2010)
Closes #4998
2012-04-07 22:29:19 +01:00
kaelima cadf311ac6 Core/Players: Reward XP to dead players inside battlegrounds
(29/05/2010)
2012-04-07 21:42:49 +01:00
Vojtěch Boček cea3930610 Core: Give field pointers in Player::DeleteFromDB() more appropriate name 2012-04-04 19:07:22 +03:00
click 0447ddacef Core: Fix a crash in Player::DeleteFromDB due to loading wrong fields 2012-04-04 17:42:45 +02:00
Nay b7f7e3118c Core/DBLayer: More type fixes
Thanks to Vasago for the help in spotting the errors
Thanks to Subv as well (so he doesn't feel lonely)
2012-04-01 22:41:47 +01:00
Nay 1bc99cd5af DB/Spawns: Fix previous commit (512aa8897b) 2012-04-01 14:55:19 +01:00
Nay 377c5ce36e Core/DBLayer: Fix another wrong type in mail related code 2012-04-01 03:09:01 +01:00
Shocker b292437989 Merge pull request #5933 from GyxTom/master
Core/Misc: Code style and remove unused define
2012-03-30 14:49:44 -07:00
Shauren 5843851559 Core/DBLayer: More prepared statement corrections 2012-03-29 23:22:10 +02:00
Kandera 4a0085ad2c Core/DBLayer: more type fixes 2012-03-29 12:21:38 -04:00
leak 5e58905aa0 Core/DBLayer: More types fixes 2012-03-29 17:43:23 +02:00
Nay 92d3548f0b Core/DBLayer: Even more types fixes... 2012-03-29 15:08:17 +01:00
Gyx 5b7493fc66 Core/Misc: Code style and remove unused define.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 14:43:34 +08:00
Gyx 360014856d Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 13:42:04 +08:00
Shocker a08cb234c0 Merge pull request #5918 from GyxTom/master
Core/Misc: Various cleanups
2012-03-28 18:00:42 -07:00
click 6237ddac34 Partially revert a36a0a77ef.
Cleaning databases for old/deprecated and expired quests should never be a
developers choice specifically. This should be done by admins, not developers,
through the use of the already existing paramters found in the worldserver config :
CleanCharacterDB / PersistentCharacterCleanFlags

An adjustment to the respective questloader prepared statement has been done to
accomodate for the earlier change (by not loading such quests into memory at all).

Documentation for how this cleanup-procedures work already exists in the core :
doc/CharacterDBCleanup.txt.
2012-03-28 19:31:06 +02:00
Gyx 1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 20:00:29 +08:00
Gyx 72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 19:11:50 +08:00
Machiavelli 91228d2711 Core/Player: Similarly initialize m_SeasonalQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7C42: Player::_SaveSeasonalQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19375)
==8111==    by 0xFB56BA: Player::SaveToDB(bool) (Player.cpp:18898)
2012-03-28 13:07:37 +03:00
Machiavelli c3db19b80b Core/Player: Initialize m_WeeklyQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7AD2: Player::_SaveWeeklyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19352)
2012-03-28 13:06:02 +03:00
Shauren 697fda7d27 Core/Players: Fixed copy paste mistake 2012-03-28 00:03:11 +02:00
Shauren 38deaa5dba Core/Players: Fixed saving glyphs to database
Closes #5909
2012-03-27 19:00:41 +02:00
leak b1ca1ee5ec Core/DBLayer: Convert PAppend() queries to prepared statements No.4 NOTE:
Most of the cores queries have been converted to prepared statements now. If your code contains queries, please either use the exiting or implement new statements.
The only exclusions are one-time queries (e.g. for core startup) and queries that can't be prepared due to limitations.
2012-03-26 15:47:37 +02:00
kaelima 786c226b74 Core/CombatLog:
- Send more proper hitinfo values in SMSG_ATTACKERSTATEUPDATE (still lot of research todo)
- Some renaming and commenting

- Minor cleanup in Player::UpdateZone
2012-03-26 02:16:19 +02:00
Shauren 9ec61089be Core/Player: Fixed accessing possibly deallocated memory 2012-03-25 22:24:11 +02:00
Subv 04099402cd Core/Players: Use correct size in variables 2012-03-25 13:05:13 -05:00
Subv 19747fb95e Core/DBLayer: Use correct Get method in some DB fields 2012-03-25 12:59:18 -05:00
leak e37a4e5fe2 Merge pull request #5870 from Elron103/pull-requests5
Core: Fix warnings
2012-03-24 16:14:21 -07:00
Elron103 7daf69f20c Core: Fix warnings 2012-03-24 18:25:24 +01:00
leak 12e55a04bb Core/DBLayer: Convert PQuery() queries to prepared statements 2012-03-24 01:25:08 +01:00
Gyx 1e94ab8d51 Core/Game: Code style and remove unused core.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-17 20:13:37 +08:00
Machiavelli f8c04b1bc5 Core/Movement: Fix players still able to fly on SPELL_AURA_FLY and SPELL_AURA_MOD_INCREASE_MOUNTED_FLIGHT_SPEED unapply.
Closes #5731
2012-03-16 17:10:01 +01:00
leak 2a5caef4a6 Revert "Core: more more cleanup" - Build test anyone?
This reverts commit 20cd4c71ee.
2012-03-14 18:51:51 +01:00
thomas33 20cd4c71ee Core: more more cleanup 2012-03-14 17:51:11 +01:00
Shauren 1dde22394c Core: Corrected conflicting variable names 2012-03-14 00:21:46 +01:00
thomas33 0532afed90 more cleanup 2012-03-13 14:53:36 +01:00
kaelima 6217583627 Core/Map:
- Remove mysterious restriction in visibilityhelper for gameobjects
- Some cleanup in CheckAreaExploreAndOutdoor() and GridDefines.h
- Set nocreate for cells visited in Map::VisitNearbyCellsOf
2012-03-12 04:33:24 +01:00
Machiavelli 03a24a84e4 Core/Units:
- Implement UNIT_FIELD_HOVERHEIGHT (requires DB data). This field, sent in update object packet, will determine the height at which a creature hovers if it has movementflag_hover applied. Note that hovering will now update the server-sided z-coordinate by the value of this field, and that all subsequent positional updates to the client will need to send z coordinate MINUS the hover height offset, or the hoverheight will be visually doubled client side.
- Correct our usage of movementflag_flying, movementflag_can_fly, movementflag_hover and movementflag_disable_gravity (previously levitate), and how they relate to InhabitType in the database. This fixes "flying creatures on steroids" bug (wings flapping too fast), and potentially a lot of visual issues in AI scripts. Note that a lot of scripts still set wrong movementflags, these need to be fixed on a case by case basis.
- Send correct packets for SPELL_AURA_FEATHER_FALL, SPELL_AURA_WATER_WALK and SPELL_AURA_HOVER apply/unapply.
- Send correct packet contents for movement update in Unit::SetSpeed.
- Misc. cleanup in affected scripts.
2012-03-12 00:53:45 +01:00