Commit Graph
922 Commits
Author SHA1 Message Date
Shauren 0d1d468c88 Core/Spells: Fully prevent infinite proc loops and add logging to detect most spells that could possibly trigger this behavior at startup 2025-08-03 14:28:23 +02:00
Ovahlord 744aa1fd96 Core/Spells: make proc related fields typesafe 2025-08-03 13:33:05 +02:00
Ovahlord a9579cb33b Core/Skills: ported skill refactors from master branch
* implement automatic skill learning from dbc data which
2025-06-21 01:23:27 +02:00
Ovahlord 5c9ecf27e9 Core/Spells: dropped spell_bonus_data table and use the dbc internal data to calculate ap and sp bonus values
* some spells have a special formula in their tooltips, which need manual scripting via the CalcDamage and CalcHealing hooks respectively
2025-06-08 15:16:17 +02:00
Shauren 3c0cf32b43 Core/Spells: Named and implemented most of SpellAttr7 2023-10-21 20:32:32 +02:00
Ovahlord 4ff88148c8 Core/Spells: only provide base difficulty spell Ids to criteria events to match their requirements (see It's Not Easy Being Green' for reference) 2023-10-11 02:09:44 +02:00
Ovahlord a4ffa701a5 Core/Spells: implement SPELL_ATTR0_CU_IS_TALENT 2023-08-19 22:39:23 +02:00
Shauren ca034f4dbf Core/Auras: Convert most rules from Aura::CanBeSaved to a custom spell attribute 2023-08-19 22:26:12 +02:00
Ovahlord 96b1933a6c Core/Spells: removed deprecated radius fix for the Lich Kings's Defile ability 2023-08-07 20:32:32 +02:00
Ovahlord e1492bc0e9 Core/Spells: removed unnecessary spell attribute hack from Earth Shield and cleaned up its spell script a bit 2023-08-07 19:29:31 +02:00
Ovahlord be53999f09 Core/Spells: restore a couple spell attribute assignments that went lost in 2bcc645cd3 2023-08-07 17:41:24 +02:00
Ovahlord 2bcc645cd3 Core/Spells: ported radius entry indexing from master branch and dropped several now deprecated spell 'fixes' from spellMgr 2023-08-06 12:54:05 +02:00
Ovahlord 12a3e9e64c Core/Spells: implement generic shop keeper greeting spells and use them for a couple Stormwind Vendors 2023-07-18 00:02:21 +02:00
Ovahlord 1bad2a9d1d Core/Spells: correct range for Cauldron of Battle's flask creation spell 2023-01-22 08:43:36 +01:00
Shauren 265c2fa508 Core/Battlefields: Refactor Battlefield creation to be linked to host map creation instead of having globally accessible objects 2022-12-26 13:24:59 +01:00
Ovahlord cbf43d855b Scripts/ZG: fixed up the Chain Breaking mechanic in Jindo's encounter 2022-11-19 11:39:47 +01:00
Carbenium 0ef220fca0 Battlefields: Move BF scripts out of game
This commit introduces the usual script interface
for battlefields.
2022-10-09 00:35:07 +02:00
Shauren 050300771d Core/Spells: Rename SpellAttr6 to use official attribute names 2022-09-30 10:45:17 +02:00
Shauren 2c78751b5a Core/Spells: Corrected implementation of SPELL_ATTR5_ALLOW_ACTIONS_DURING_CHANNEL - it allows casting other spells while channeling, not allows movement while channeling 2022-09-30 02:00:04 +02:00
Shauren 75906f3d06 Core/Auras: Added support for SPELL_ATTR5_LIMIT_N limit to other number than just 1 2022-09-30 01:57:52 +02:00
Shauren d1700ba5fa Core/Spells: Rename SpellAttr5 to use official attribute names
* Implemented SPELL_ATTR8_HASTE_AFFECTS_DURATION
2022-09-30 01:30:14 +02:00
Shauren a7dc339a6a SHA-1: 8d16a79dea4c0100d36e13b068c42499a3a48154
* Core/Spells: Rename SpellAttr4 to use official attribute names

* Corrected implementation of SPELL_ATTR4_CLASS_TRIGGER_ONLY_ON_TARGET
* Implemented SPELL_ATTR4_NO_HELPFUL_THREAT
* Implemented SPELL_ATTR4_NO_PARTIAL_IMMUNITY
* Implemented SPELL_ATTR4_ALLOW_PROC_WHILE_SITTING
* Implemented SPELL_ATTR4_USE_FACING_FROM_SPELL
* Implemented SPELL_ATTR4_BOUNCY_CHAIN_MISSILES
* Implemented SPELL_ATTR4_AURA_NEVER_BOUNCES
* Implemented SPELL_ATTR4_AURA_BOUNCE_FAILS_SPELL
* Implemented SPELL_ATTR4_AURA_IS_BUFF
* Implemented SPELL_ATTR5_MELEE_CHAIN_TARGETING

* Implemented SpellEffectAttributes::ChainFromInitialTarget
2022-09-30 01:16:39 +02:00
Shauren 946f928ee2 Core/Spells: Rename SpellAttr3 to use official attribute names
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-09-13 15:40:25 +02:00
Shauren ea4bc6c02a Core/Spells: Rename SpellAttr2 to use official attribute names
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-09-13 14:36:32 +02:00
Shauren ca7d36873f Core/Spells: Rename SpellAttr1 to use official attribute names
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-09-12 09:15:31 +02:00
ariel- 3a3e70f2b6 Core/Spells: all bleed effects should ignore armor 2022-09-12 09:15:19 +02:00
ariel- 1fe5563431 Core/Spells: Fix periodic rolling adding bonuses twice
Calculation is now done in CalculateAmount
2022-09-12 09:15:15 +02:00
ariel- b6fac86b71 Core/Spells: rework part 5: GameObject casting 2022-09-12 09:15:14 +02:00
ariel- 4bb8c93df8 Core/Spells: rework part 4: iterate over effects first
Implement far spell queue processing

# Conflicts:
#	src/server/game/Spells/Spell.cpp
2022-09-12 09:15:13 +02:00
ariel- 95bc5dcc40 Core/Spells: rework part 1: Improved positive detection logic
# Conflicts:
#	src/server/game/Spells/SpellInfo.cpp
2022-09-12 09:15:12 +02:00
ariel- c81f48197d Core/Spells: calculate crit chance only for spells that do damage/healing 2022-09-12 09:15:10 +02:00
Shauren d448ea4370 Core/Spells: Rename SpellAttr0 to use official attribute names 2022-09-12 09:15:04 +02:00
Ovahlord 149d9aec8d Core/Spells: allow Rip's periodic effect to crit 2022-07-17 11:47:56 +02:00
Ovahlord 846e89c1fc Core/Spells: allow Combustion's damage over time effect to crit 2022-06-24 23:13:48 +02:00
Ovahlord e5f09705c1 Core/Spells: fixed typos which have been added in 77158594ff 2022-04-01 14:03:45 +02:00
Ovahlord 5f2b1e45e4 Core/Spells: improve integer to float conversions and checks for spell proc entries 2022-03-10 20:43:12 +01:00
Ovahlord 78896a132f Core/Spells: ported proc flag updates from master branch 2022-02-22 21:19:09 +01:00
Ovahlord e83c5955b4 Core/Spells: moved Improved Devouring Plague to spell script and fixed the damage effect 2022-02-22 12:57:29 +01:00
Ovahlord 6e412b16de Core/Spells: correctly implement Elemental Oath 2022-02-21 11:17:41 +01:00
Ovahlord d712a12f1c Core/Spells: use correct macro for tree of life stance requirement 2022-02-21 10:53:32 +01:00
Ovahlord 97a79175fc Core/Spells: added a bunch of default ctors for several spellMgr structs to silence uninitialized member warnings 2022-02-21 10:50:00 +01:00
Ovahlord 06f6987e2a Core/Spells: allow Rupture's damage to scale with combo points as well 2022-02-21 10:21:43 +01:00
Ovahlord f01012aac9 Core/Spells: corrected the finishing move spell attributes for Rupture and Expose Armor 2022-02-21 10:16:30 +01:00
ariel- b8d1bab8de Core/Spells: refactor spell_enchant_proc_data table
- Renamed fields to mimic those in spell_proc
- Added Enchant proc attributes for controlling specific enchant features

Ref #7789

(cherry picked from commit f609e7a08b3b4d2d9642e5ec252e1eedad836f0f)
2022-02-16 04:49:24 +01:00
Ovahlord 0d5a854b49 Core/Spells: corrected the spell range entry for Furious Attack's triggered healing reduction debuff 2022-02-07 16:08:02 +01:00
Ovahlord 2157ab4510 fixed build 2022-02-02 17:49:14 +01:00
Shauren 73bae7c5e5 Core/Spells: Correct implementation of SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC, SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED and rename them (SPELL_ATTR2_ACTIVE_THREAT, SPELL_ATTR3_NOT_A_PROC, SPELL_ATTR3_CAN_PROC_FROM_PROCS) 2022-02-02 17:45:23 +01:00
Ovahlord f63d798ed7 Scripts/Firelands: implement Ragnaros encounter 2022-02-02 17:40:54 +01:00
xinef1 9da4acce08 Core/Spells: Remade trajectory target selection (#19048)
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received

(cherry picked from commit c6060dd0c511ddad3cb1f0423aa9ccf2de7aedec)
2022-01-22 22:29:20 +01:00
Keader 3681f356d6 Core/Spell: Fixed range issues with some quest spells
Closes #17815

(cherry picked from commit 6f7310a25993f06676ae91f4d80071d5ce576978)
2022-01-22 19:04:34 +01:00