Commit Graph
1490 Commits
Author SHA1 Message Date
Dehravor 24ae6a6802 Core/Misc: Remove obsolete C++11 backward compatibility macros
OVERRIDE, FINAL, DELETE_MEMBER
2014-04-29 16:35:11 +02:00
joschiwald 84bff76ba0 Core/Misc: remove some obsolete parameters 2014-04-28 20:05:36 +02:00
Kinzcool c536305e3a Core: Droped faction_H field -- only one faction table is necessary 2014-04-27 18:13:55 -04:00
w1sht0l1v3 c20d0cb77e Scripts/Sholazar Basin: Reconnaissance Flight (12671)
Add workaround for the player/accessory mounting issue.
Some small additions.
Closes: 9443
2014-04-27 02:23:33 +03:00
jackpoz f27057bf24 Core/Misc: Fix build warnings 2014-04-25 21:46:43 +02:00
jackpoz 2585e799f9 Core/Misc: Change how Position struct is retrieved
Update Position::GetPosition() and similar methods signatures to reflect 2a4c9bcaf9 changes by return a Position object instead of accepting a Position parameter by reference.
2014-04-25 21:19:30 +02:00
joschiwald 805a026c6c DB/CreatureText: readd accidentally deleted text 2014-04-22 16:07:27 +02:00
jackpoz fb6365ac68 Core/Misc: Check GetVictim() for NULL before dereferencing it
Add additional NULL checks all around the code before dereferencing GetVictim() result.
Keep in mind UpdateVictim() result has nothing to do with GetVictim() result and the caller shouldn't assume anything about GetVictim() based on UpdateVictim().
2014-04-20 00:38:25 +02:00
jackpoz 8ca6371793 Core/Misc: Ensure GetVictim() returns a valid reference when expected
Add a new method EnsureVictim() which asserts a valid not NULL reference will be returned to the caller. Use this whenever the GetVictim() would be dereferenced .
2014-04-19 21:48:22 +02:00
Warpten d9493d9cc9 Scripts/Ruby Sanctum: Fixed corporeality scaling changes.
Thanks to Unholychick.

P.S.: #9231 if still valid will be fixed soon (tm)
2014-04-19 19:18:51 +02:00
Vincent-Michael 89cc056a50 Fix 2014-04-18 17:02:04 +02:00
joschiwald 8877a87c99 Merge pull request #11614 from MitchesD/kelthuzad
Scripts/Kelthuzad: move spells into spelldifficulty_dbc and cleanup
2014-04-17 02:02:51 +02:00
joschiwald 0a014e1431 Scripts/UtgardeKeep: fixed some issues on Ingvar the Plunderer
Closes #10859
2014-04-17 00:09:43 +02:00
Warpten 335fe8e1b0 Scripts/Ruby Sanctum: Fixed Halion engaging combat outside of his Flame Ring. 2014-04-10 14:28:58 +02:00
Warpten b36e7c0211 Scripts/Ruby Sanctum: Fixed Onyx Flamecallers not aggroing players once pathing ended. 2014-04-09 17:55:54 +02:00
jackpoz 5b1a28076e Scripts/Ulduar: Fix uninitialized values
Fix uninitialized values in Ulduar script reported by Valgrind.
2014-04-05 23:41:01 +02:00
jackpoz 0930482fa4 Core/Misc: Fix uninitialized values
Fix Position members not being always initialized.
Valgrind log:
 at : Position::NormalizeOrientation(float) (Object.h:388)
 by : Position::SetOrientation(float) (Object.h:315)
 by : Position::Relocate(Position const&) (Object.h:310)
 by : spell_ulduar_stone_grip::spell_ulduar_stone_grip_AuraScript::OnRemoveVehicle(AuraEffect const*, AuraEffectHandleModes) (boss_kologarn.cpp:592)
2014-04-02 20:42:46 +02:00
jackpoz 10ba63cf3d Core/Misc: Fix typo in f47962f670 2014-03-31 21:10:29 +02:00
jackpoz f47962f670 Core/Misc: Fix some static analysis issues
Add some asserts and additional NULL checks as sanity checks.
2014-03-31 20:59:33 +02:00
Vincent-Michael 0b615ec159 Scripts/Misc: Small code optimizations 2014-03-29 20:58:49 +01:00
jackpoz 8c44259fae Core/Misc: Fix some static analysis issues
Fix uninitialized values, most of which are false positives, always initialized before being accessed.
Add some asserts and additional NULL checks as sanity checks. Use SpellMgr::EnsureSpellInfo() if the spell id is valid and always supposed to return a valid not-NULL SpellInfo* .
2014-03-27 21:43:59 +01:00
Gacko 46b8bc8882 Fix non-pch build and remove blank line 2014-03-26 18:51:09 +01:00
Gacko 808a1998c6 Quest: The Power of the Elements
Remove hack SAI, use aura script
2014-03-26 18:36:39 +01:00
Shauren 84365f43b4 Scripts/Icecrown Citadel: Fixed Muradin/Saurfang attacking each other during Gunship Battle
Closes #11786
2014-03-25 22:20:45 +01:00
Shauren cd20be2cc9 Scripts/Icecrown Citadel
* Deathbringer Saurfang will now evade if any player stands on the gunship
* Fixed players being stuck in combat after defeating gunship
* Fixed players not sticking to gunships
2014-03-24 00:58:37 +01:00
Shauren e469ff5e88 Fixed build without PCH 2014-03-23 12:54:09 +01:00
Shauren a4d8a26dc7 Scripts/Icecrown Citadel: Icecrown Gunship Battle 2014-03-23 02:01:13 +01:00
Shauren 529cabea68 Core/Map: Save weather, light and music overrides in map to send them to players logging in 2014-03-22 19:40:36 +01:00
jackpoz 6dcd8c8545 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior

Please ensure EventMap is never used with event id set to 0 or those events will never execute.
2014-03-22 14:54:32 +01:00
jackpoz 9e99db035f Core/Misc: Fix some static analysis issues
Add some asserts and additional NULL checks as sanity checks.
2014-03-21 22:47:58 +01:00
Gacko 4bcbcf53d8 Core/Script: Logical fixes 2014-03-19 10:05:02 +01:00
jackpoz f26a028d97 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed.
2014-03-16 14:18:33 +01:00
jackpoz a1aa4547b3 Scripts/Krikthir the Gatewatcher: Fix EVENT_ANUBAR_CHARGE event not being triggered
Fix EVENT_ANUBAR_CHARGE not being triggered due to value 0 being set to the EVENT_ANUBAR_CHARGE enum, even if 0 is a special value for EventMap to specify no event was triggered.
Issue added in a127c0e1a7
2014-03-15 20:08:55 +01:00
jackpoz e30b471f8e Scripts/AhnKahet: Fix some uninitialized values
Initialize all class fields in the constructor, even if they are set in Reset() and they shouldn't be accessed before Reset() is called.
This fixes 2 Coverity reports.
2014-03-15 20:04:59 +01:00
jackpoz ba28b16d2e Scripts/TheStormPeaks: Possible crash fix
Apply safe NULL checks added in 7d881a0739 to similar code in same script
2014-03-09 17:17:12 +01:00
w1sht0l1v3 50d99005a5 Scripts/Ulduar: Fix Algalon the Observer outro phase(fixes kill credit and some achieves). 2014-02-16 02:27:44 +02:00
MitchesD 6907d51b6b Scripts/Kelthuzad: move spells into spelldifficulty_dbc and cleanup 2014-02-15 23:18:54 +01:00
Vincent_Michael a5a6799b4e Scripts: Added missing stuff in 1d1aeda86c 2014-02-09 19:15:17 +01:00
Vincent_Michael 1d1aeda86c Core: Fix build 2014-02-09 19:01:56 +01:00
joschiwald 6688370513 Merge pull request #11457 from MitchesD/krikthir
Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimalization
2014-02-09 18:46:26 +01:00
MitchesD a127c0e1a7 Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimization 2014-02-09 18:41:37 +01:00
jackpoz 856e0933b5 Scripts/HoR: Fix log error
Fix "DoZoneInCombat called for creature that has empty threat list" error caused by DoZoneInCombat() called by IsSummonedBy() in a script before the Creature is allowed to enter combat.
2014-01-30 21:29:37 +01:00
Vincent_Michael 9531073b77 Scripts: Gossip can crash with null instance 2014-01-24 17:08:17 +01:00
Vincent_Michael 46e1b93c2b Scripts: A lots of changes here and there (maybe useless?!?) 2014-01-23 22:54:01 +01:00
joschiwald d6c5307a81 Scripts/Spells: use new hook in some spellscripts 2014-01-23 20:55:47 +01:00
joschiwald f731116766 Scripts/AhnKahet: fix some issues on prince taldaram script 2014-01-23 18:21:17 +01:00
Vincent_Michael 101ac7f511 Misc: Minor cosmetic changes here and there 2014-01-21 20:20:38 +01:00
zengwf 23acf75d3b Core/Movement: Add LOS check for fleeingmovement target point.
Prevents fleeing or feared units from going to upper floor ignoring walls/ceilings with mmaps on(and usually get stucked).

Current implementation just randomly selects a distance and angle against the frighting unit, when in narrow circumstance such as underground caves, such targeting point would be at another floor.

Closes #11300
Ref #9475 (needs fixed confirmation)
2014-01-12 00:33:33 +00:00
Duarte Duarte 65c941b88d Merge pull request #11342 from Carbenium/Svala
Scripting/Utgarde Pinnaccle: Fix visual during Svala's transformation
2014-01-11 16:20:16 -08:00
joschiwald 7378baee49 Scripts/PoS/Garfrost: cleanup saronit blocks after death 2014-01-10 17:37:03 +01:00