Ovahlord
367c120231
Core/Spells: make SpellInfo::CausesInitialThreat respect SPELL_ATTR0_CU_NO_INITIAL_THREAT as well
2022-04-01 12:21:11 +02:00
Ovahlord
fd22ea32e6
Core/Spells: merged master version of checking for cast immunities
2022-03-10 20:41:47 +01:00
ariel-
4c658cf2da
Revert "Core/Spell: don't set scaleAura for some special spells"
...
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e.
Closes #19472
(cherry picked from commit c296d255e25a2d0eb7155f64eea32cc36fed280a)
2022-02-16 04:49:24 +01:00
ariel-
14a95ff976
Core/Spell: don't set scaleAura for some special spells
...
Closes #14541
(cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
2022-02-16 04:49:24 +01:00
Chaouki Dhib
17c4d8f6d9
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] ( #16290 )
...
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.
(cherry picked from commit a1f2f30c145f6ad9c4baeffeff32618e71ff537c)
2022-02-16 04:49:24 +01:00
xinef1
716487fefc
Corrected points per level calculation for some spells ( #19105 )
...
(cherry picked from commit 9142c778dd861eda188ba868433af05038c4e13c)
2022-02-16 04:49:24 +01:00
xinef1
9da4acce08
Core/Spells: Remade trajectory target selection ( #19048 )
...
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received
(cherry picked from commit c6060dd0c511ddad3cb1f0423aa9ccf2de7aedec)
2022-01-22 22:29:20 +01:00
Ovahlord
9892d239a8
Core/Spells: renamed SPELL_ATTR5_INCLUDE_MELEE_RANGE to SPELL_ATTR5_TREAT_AS_AREA_EFFECT and handle the attribute in SpellInfo::IsAffectingArea
2022-01-16 11:44:49 +01:00
Ovahlord
520b53a5e0
Core/Spells: added a helper to determine whenever a periodic aura should roll over its duration on refresh
...
* introduce another custom spell attribute to grant full control over when or when not to roll over ticks
2022-01-14 18:46:03 +01:00
Ovahlord
2dc07876ea
Core/Spells: implement spellpower and attackpower coefficient scaling
2022-01-05 20:19:06 +01:00
Shauren
a322e4eb37
Core/Spells: Implemented target 124 TARGET_UNIT_TARGET_TAP_LIST
2021-12-30 20:16:33 +01:00
Shauren
383e7c1315
Core/Spells: Implemented target 121 TARGET_CORPSE_TARGET_ALLY
2021-12-30 20:14:29 +01:00
Ovahlord
8bb9376aa2
Core/Spells: Rename targets 110 to TARGET_UNIT_CONE_CASTER_TO_DEST_ENTRY
2021-12-30 20:12:02 +01:00
Shauren
84c7434b8b
Core/Spells: Rename targets 108 and 109 to include CASTER_TO_DEST wording
2021-12-30 20:10:09 +01:00
Shauren
5fcf5bdee5
Core/Spells: Implemented target 107 TARGET_DEST_NEARBY_ENTRY_2 (the same as target 46)
2021-12-30 20:08:10 +01:00
Shauren
28f79765ca
Core/Spells: Implemented target 62 TARGET_DEST_CASTER_GROUND (the same as target 125)
2021-12-30 20:00:42 +01:00
Shauren
7ef17f416c
Core/Spells: Rename TARGET_UNIT_CONE_ENEMY_54 to TARGET_UNIT_CONE_180_DEG_ENEMY and add 180 degree fallback for this target type
2021-12-30 19:57:50 +01:00
Shauren
8e657a9b7c
Core/Spells: Implemented target 105 TARGET_UNIT_CASTER_AND_PASSENGERS
2021-12-30 19:55:29 +01:00
Shauren
0ef0498d13
Core/Spells: Rename TARGET_UNIT_CONE_ENEMY_104 to TARGET_UNIT_CONE_CASTER_TO_DEST_ENEMY
2021-12-30 19:46:50 +01:00
Ovahlord
8596cf6be2
Core/Spells: renamed SPELL_ATTR5_CAN_CHANNEL_WHEN_MOVING to SPELL_ATTR5_ALLOW_ACTIONS_DURING_CHANNEL to match its leaked name
2021-12-26 22:09:27 +01:00
Ovahlord
3a2e3452e0
Core/Spells: implement TARGET_UNIT_CASTER_PASSENGERS (105)
...
closes #297
2021-11-17 17:47:18 +01:00
Ovahlord
edbbeba5a2
Core/Movement: ported client control logic updates from 335 branch
2021-11-06 23:41:34 +01:00
Ovahlord
b10f962ba3
Core/Creatures: several cleanups and improvements to spell focusing to reduce edge case issues
2021-10-21 13:18:24 +02:00
Ovahlord
5e677b876b
Core/Spells: restored the old logic when determining when to add additional haste based ticks
2021-09-19 14:36:01 +02:00
Ovahlord
0ef4e66c1d
make CI happy
2021-09-19 10:21:44 +02:00
Ovahlord
6c7e2830c1
Core/Spells: fixed a possible null divider crash for spells with a periodic interval of 0 caused by exceptionally high haste and spell mod values
2021-09-18 23:25:33 +02:00
Ovahlord
9616582b05
Core/Spells: load BonusCoefficient into SpellInfo and use it for Goblin's Rocket Barrage Racial spell damage calculation
2021-08-28 15:01:28 +02:00
Ovahlord
be614ded97
Core/Misc: fixed issues reported by pvs studio
...
closes #281
2021-08-18 21:11:20 +02:00
Ovahlord
6510b2b034
Core/Spells: fixed a cherrypick typo in checking for affecting spellmods
2021-07-06 10:55:05 +02:00
Ovahlord
8011d2de29
Core/Spells: ported resistance and immunity updates from 3.3.5 branch
2021-06-12 14:10:44 +02:00
Ovahlord
95651d9f88
Core/Spells: renamed SPELL_ATTR1_REQ_COMBO_POINTS1 to SPELL_ATTR1_FINISHING_MOVE_DAMAGE and SPELL_ATTR1_REQ_COMBO_POINTS2 to SPELL_ATTR1_FINISHING_MOVE_DURATION and implemented them
2021-05-16 19:19:51 +02:00
Ovahlord
bf28dfcf0c
Core/Spells: corrected a check when retrieving mechanic immunities in cast and channel packets and fixed a typo in SMSG_CHANNEL_START that was overwriting school immunities with mechanic immunities instead
2021-04-27 15:42:50 +02:00
Ovahlord
b82943eab0
Core/Spells: renamed SPELL_ATTR5_HASTE_AFFECT_DURATION to SPELL_ATTR5_SPELL_HASTE_AFFECTS_PERIODIC and renamed SPELL_ATTR8_UNK17 to SPELL_ATTR8_HASTE_AFFECTS_DURATION
2021-04-16 16:12:58 +02:00
Ovahlord
77158594ff
Core/Spells:
...
* renamed SPELL_ATTR3_CANT_TRIGGER_PROC to SPELL_ATTR3_CANT_TRIGGER_CASTER_PROCS and expanded its implementation
* renamed SPELL_ATTR3_NO_INITIAL_AGGRO to SPELL_ATTR3_CANT_TRIGGER_TARGET_PROCS and implement the attribute
* expanded implementation SPELL_ATTR2_NO_INITIAL_THREAT to cover all remaining spots
2021-03-30 17:50:27 +02:00
Ovahlord
f43d8aa804
fixed build
2021-03-29 21:20:49 +02:00
Shauren
a8f0ec3e92
Core/Auras: Corrected logic used to determine if a spellmod should affect another spell, empty family name or class mask should not apply to any spell
2021-03-27 09:49:53 +01:00
Ovahlord
6301a324cd
Core/Spells: added and updated SpellCategoryFlags and implemented SpellCategoryFlags::CooldownInDays
2021-03-25 17:10:51 +01:00
Ovahlord
83298b52a2
Core/Spells: ported SpellInterruptFlags updates from master branch and corrected some own implementations based on these new results
2021-03-25 15:53:26 +01:00
Shauren
fed82c1002
Core/Auras: Defined and implemented many new interrupt flags
2021-03-24 14:53:30 +01:00
Shauren
45df49c826
Core/Spells: Updated spell shapeshift form flags enum
2021-03-24 13:16:17 +01:00
Ovahlord
ffc05d0bf1
Core/Spells: implement helper to filter mechanic immunities in packets to reflect sniff behavior and removed pct heal effects from heal prediction
...
Despite being able to send all mechanic immunities in spell_start and channel_start, sniffs confirm that only relevant immunities are being sent which in most cases are silence and interrupt immunities. Further sniff analysis may reveal even more possible interrupt flags
2021-02-26 11:30:44 +01:00
Ovahlord
7b0e15d149
Core/Spells: fixed calculating additional aura duration for haste based periodic spells
2021-02-20 23:31:43 +01:00
Matan Shukry
abae5e4596
Core/Spells: Implemented summoning a personal gameobject effect ( #25917 )
...
# Conflicts:
# src/server/game/Entities/GameObject/GameObject.cpp
# src/server/game/Entities/GameObject/GameObject.h
# src/server/game/Miscellaneous/SharedDefines.h
# src/server/game/Spells/SpellInfo.cpp
2021-02-19 13:01:10 +01:00
xvwyh
4d95bcc068
Core/Spells: Correct swapped TARGET_UNIT_NEARBY_ALLY and TARGET_UNIT_NEARBY_PARTY
2021-01-15 18:27:22 +01:00
Ovahlord
3a97aad549
Core/Spells: corrected mechanic of target type 126 and renamed it to TARGET_UNIT_AREA_ENEMY
2020-11-25 15:15:03 +01:00
Ovahlord
6dfa793567
Core/Spells: define and enable TARGET_UNIT_SRC_AREA_ENEMY_2
2020-11-25 10:07:36 +01:00
Keader
3b2ef0ec45
Scripts/BT: full instance rewrite
2020-11-05 17:42:33 +01:00
Ovahlord
25c980c390
Core/Units: ported spell crit chance updates from 335 branch
2020-08-28 11:46:07 +02:00
Treeston
942c3a77da
Core: Combat/threat system rewrite (PR #19930 )
...
- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with.
- PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting.
- By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers.
- Threat and combat systems are no longer the same.
- They still have an enforced relationship (threat implies combat - clearing combat clears threat)...
- ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list...
- ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress!
- AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`.
- Vehicle threat is now properly pooled on the main vehicle body (fixes #16542 ).
- Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar).
- Target re-selection is now significantly faster.
- Fixed a ton of other smaller edge case bugs, probably.
Closes #7951 and #19998 .
2020-07-22 16:49:37 +02:00
Ovahlord
e1d74d4dc6
Core/Misc: added more fallthrough attributes and added some missing breaks reported by CI
2020-07-19 12:24:58 +02:00