Commit Graph
26296 Commits
Author SHA1 Message Date
Ovahlord be614ded97 Core/Misc: fixed issues reported by pvs studio
closes #281
2021-08-18 21:11:20 +02:00
Ovahlord 8186f9d450 make CI happy 2021-08-17 15:38:13 +02:00
Ovahlord da5564fa47 Core/Packets: converted SMSG_CLEAR_COOLDOWN and SMSG_CLEAR_COOLDOWNS to packet class 2021-08-16 11:02:22 +02:00
Ovahlord 8ac7e71690 Core/Spells: implement summon properties parameter types based on the leaked enumerated strings values
Summon spells can now be commanded to interpret their basepoints depending on the parameter type that has been assigned to the summon properties dbc record Id

* implemented SummonCreatureExtraArgs to reduce the amount of arguments in Map::SummonCreature
2021-08-15 10:35:02 +02:00
Ovahlord c927ca98ba Core/Spells: allow knockback spell effects to use negative misc values as well for forward knockbacks 2021-08-15 07:07:37 +02:00
Ovahlord 1568798985 Core/Spells: fixed Glyph of Shadow Word: Death 2021-08-15 06:56:32 +02:00
Ovahlord 3e56f75d7c fixed build and a typo in recent sql file 2021-08-02 13:13:50 +02:00
Ovahlord e785b6d386 Scripts/Mulgore: several fixups for Camp Narache
* scripted Captured Brave's behavior when released from their cages
* respawned Armored Quillboars and got rid of duplicate spawns
* scripted Armored Quillboar's visual events, combat ability and behavior when ignited via torch
* added waypoints to Brave Windfeather
* nuked cooler's shitty sai for chief squealer thornmantle and replaced it with a c++ script to handle the death spell cast event
* corrected timers for Chief Hawkwind's ceremony texts
* spawned a missing spellfocus and removed some gameobject spawns which are suposed to be tempoary
* added some emote events to Camp Narache trainers
2021-08-01 15:21:05 +02:00
Ovahlord 280dd50af4 Core/Quests: also check previous quests when checking exclusive groups to allow chaining one quest group into another 2021-08-01 15:13:34 +02:00
jackpoz 1ea6bef697 Core/SOAP: Fix memory leak on shutdown reported by ASan 2021-07-31 21:44:43 +02:00
jackpoz 24d4e6977c Core/SOAP: Fix new/free mismatch reported by ASan 2021-07-31 21:44:38 +02:00
Ovahlord f9fafbab7d Scripts/Deadmines: move entrance faction spawns to instance_spawn_groups and handle them via faction flags instead 2021-07-31 21:42:32 +02:00
ariel- 0792739a98 Core/Scripts: fixed npc immunity flags during Harbinger Skyriss encounter
- Added missing _Reset
- Properly register Skyriss summons in SummonList

Closes #21154

Who ordered up an extra large can of whoop-ass?

(cherry picked from commit f8b148c3346e6d5017bf3b044cc36bce32c0cf45)
2021-07-29 21:41:02 +02:00
Ovahlord e03b2f41bf Core/Guilds: implement weekly bonus money packet field in guild bank queries 2021-07-29 18:45:49 +02:00
jackpoz 5d9b3b59d2 Core/Misc: Remove whitespace 2021-07-29 17:32:15 +02:00
jackpoz d53a176746 Core/MMAPs: Reduce chances of breaking tile connections
Reduce chances of breaking tile connections caused by floating point rounding issues.
2021-07-29 17:32:05 +02:00
Gildor a91f7a3ef3 Core/Quest: When removing an item required for a quest, update every quest in the quest log instead of stopping at the first objective that matches the removed item. (#26760)
Closes #25662
Closes #10586
2021-07-29 17:31:54 +02:00
Gildor 1466176aef Core/Quests: Improve ItemRemovedQuestCheck logic (#26758)
Closes #25603
2021-07-29 17:31:23 +02:00
Ovahlord 8cabdc6c85 Scripts/LCT: fixed Siamat's Achievement 'Headed South' 2021-07-29 17:29:36 +02:00
Ovahlord c58d2752d3 Core/Creatures: fixed build and clamp the damage pct limit instead of blindy relying on arguments 2021-07-26 15:57:29 +02:00
Ovahlord 0dfa919f09 Core/Creatures: optimized sparring checks by handling them via variable instead of map lookups and expose its value to helpers to allow manipulation during runtime 2021-07-26 15:48:16 +02:00
Ovahlord ae13da2159 fixed build 2021-07-25 15:03:43 +02:00
Ovahlord 7648eff6db Core/Quests: check if a player can take the next quest provided by its query data before trying to request its details 2021-07-25 14:57:41 +02:00
funjoker a36e52e587 Core/DB: Use correct Get function 2021-07-24 01:25:07 +02:00
Ovahlord 9c55fc66ac Core/Packets: added some missing bit flushing to trade status packets 2021-07-23 20:32:42 +02:00
Ovahlord 7bd1afe406 Core/Units: corrected check for SPELL_ATTR7_CANT_MISS in Unit::MagicSpellHitResult
thx to @Jildor for the headsup
2021-07-23 19:44:14 +02:00
Ovahlord b236bd39df Core/Movement: updated smartAI waypoint support to use the new smooth transition field as well 2021-07-16 16:56:47 +02:00
Ovahlord b7ab244e79 Core/Packets: converted all remaining trade packets to packet class 2021-07-13 15:56:31 +02:00
funjoker 11e3cfd66d Add missing include 2021-07-13 12:27:15 +02:00
Ovahlord 81098f738f fixed nopch build 2021-07-12 09:01:53 +02:00
Ovahlord 1a5c06b61a Core/Packets: several updates to trading
* converted CMSG_INITIATE_TRADE, SMSG_TRADE_STATUS, SMSG_TRADE_UPDATED and CMSG_ACCEPT_TRADE to packet class
* fixed enchanting items via trade
* handle unknown fields in SMSG_TRADE_UPDATED
2021-07-11 23:48:50 +02:00
funjoker 3480301040 Remove unused variable 2021-07-11 00:25:23 +02:00
funjoker 9abea087e5 Scripts/DB/Westfall: Fixed questline up to "Secrets of the Tower"
- fixed some incorrect rotations from signs
- added missing page text 3633
- added 2 missing spawns
- fixed some scripted events required for quests
2021-07-11 00:19:50 +02:00
Ovahlord c2279d6f60 fixed nopch build 2021-07-10 20:42:04 +02:00
Ovahlord aef0d5c5dc Core/Packets:
* converted CMSG_REQUEST_HONOR_STATS and SMSG_INSPECT_HONOR_STATS to packet class
* enabled and added handlers for CMSG_REQUEST_INSPECT_RATED_BG_STATS and SMSG_INSPECT_RATED_BG_STATS
2021-07-10 19:55:04 +02:00
funjoker 74f451941c Script/Westfall: Add missing breaks 2021-07-08 22:51:51 +02:00
funjoker 585a6e89a2 Scripts/Westfall: Start fixing Sentinel Hill 2021-07-08 22:42:08 +02:00
funjoker c439dd464b Scripts/Westfall: Fix Sentinel Hill Guards not attacking 2021-07-08 12:14:20 +02:00
Ovahlord bd3ca6e98a Core/Movement: fixed waypoint movement ignoring pause timers and interaction pause time 2021-07-08 00:41:54 +02:00
Ovahlord e2237624f6 Core/Movement: no longer store negative delays for smooth transition times and let the waypoint movement generator decide when to transition when allowed via new boolean value 2021-07-07 23:42:51 +02:00
Ovahlord 4c670bce9a Core/Movement: correctly initialize orientation values when loading script waypoints 2021-07-07 09:41:22 +02:00
jackpoz 5a08b65cef Core/Maps: fixed a floating point issue when retrieving minHeight values from GridMap 2021-07-06 20:51:19 +02:00
Ovahlord c926327077 Scripts/BWD: removed some unneeded checks in Omnotron's Lord Victor Nefarius script 2021-07-06 18:27:59 +02:00
Ovahlord dbada5fcb4 fixed build² 2021-07-06 18:14:49 +02:00
Ovahlord 5614db5976 fixed build 2021-07-06 17:59:03 +02:00
Ovahlord e8c7982362 Core/Packets: updated CMSG_UPDATE_MISSILE_TRAJECTORY to packet class and updated structure to 4.3.4
closes #268
2021-07-06 17:49:56 +02:00
Ovahlord 6510b2b034 Core/Spells: fixed a cherrypick typo in checking for affecting spellmods 2021-07-06 10:55:05 +02:00
funjoker af1bb0e227 Fix nopch build 2 2021-06-27 21:02:25 +02:00
funjoker 247257c24d Fix nopch build 2021-06-27 20:58:16 +02:00
funjoker 8cd93a9b01 Fix build after ca25299abf 2021-06-27 20:47:17 +02:00