Commit Graph
1558 Commits
Author SHA1 Message Date
Shauren 5843851559 Core/DBLayer: More prepared statement corrections 2012-03-29 23:22:10 +02:00
Kandera 4a0085ad2c Core/DBLayer: more type fixes 2012-03-29 12:21:38 -04:00
leak 5e58905aa0 Core/DBLayer: More types fixes 2012-03-29 17:43:23 +02:00
Nay 92d3548f0b Core/DBLayer: Even more types fixes... 2012-03-29 15:08:17 +01:00
Gyx 360014856d Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 13:42:04 +08:00
Shocker a08cb234c0 Merge pull request #5918 from GyxTom/master
Core/Misc: Various cleanups
2012-03-28 18:00:42 -07:00
click 6237ddac34 Partially revert a36a0a77ef.
Cleaning databases for old/deprecated and expired quests should never be a
developers choice specifically. This should be done by admins, not developers,
through the use of the already existing paramters found in the worldserver config :
CleanCharacterDB / PersistentCharacterCleanFlags

An adjustment to the respective questloader prepared statement has been done to
accomodate for the earlier change (by not loading such quests into memory at all).

Documentation for how this cleanup-procedures work already exists in the core :
doc/CharacterDBCleanup.txt.
2012-03-28 19:31:06 +02:00
Gyx 1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 20:00:29 +08:00
Gyx 72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 19:11:50 +08:00
Machiavelli 91228d2711 Core/Player: Similarly initialize m_SeasonalQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7C42: Player::_SaveSeasonalQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19375)
==8111==    by 0xFB56BA: Player::SaveToDB(bool) (Player.cpp:18898)
2012-03-28 13:07:37 +03:00
Machiavelli c3db19b80b Core/Player: Initialize m_WeeklyQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7AD2: Player::_SaveWeeklyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19352)
2012-03-28 13:06:02 +03:00
kaelima 820f45c424 Core/Protocol:
- Correct and rename response message from creating/updating a ticket
- Prevent some trailing data in CMSG_GMTICKET_CREATE and add comment on stuff missing from its structure.
- Random cleanup
2012-03-28 03:59:03 +02:00
Shauren 697fda7d27 Core/Players: Fixed copy paste mistake 2012-03-28 00:03:11 +02:00
Nay ead019b061 Core/DBLayer: Correct few more wrong read types (No. 3)
DB/World: Some consistency in the ints "length" field (not really a length)

From A to G world tables verified; missing all the others
2012-03-27 19:26:58 +01:00
Shauren 38deaa5dba Core/Players: Fixed saving glyphs to database
Closes #5909
2012-03-27 19:00:41 +02:00
click 13757731b7 Merge pull request #5811 from Elron103/pull-requests3
Core/Units: Fix issues with threat management on phase changes
This is the cleaner version of the two suggested on pull-requests, and handles the threatlist correctly as well.
2012-03-27 07:08:03 -07:00
Nay a92820b51c Core/DBLayer: Correct few more wrong read types (No. 1)
DB/World: Some consistency in the ints "length" field (not really a length)

From A to D world tables verified; missing all the others

int(11) -> int32
unsigned int(10) -> uint32
mediumint(8) -> int32
unsigned mediumint(8) -> uint32
smallint(6) -> int16
unsigned smallint(5) -> uint16
tinyint(4) -> int8
unsigned tinyint(3) -> uint8
2012-03-27 00:43:56 +01:00
leak 89f31f3cba Core/DBLayer: Typo from prev. commit 2012-03-26 19:05:51 +02:00
leak 830a7fb08b Core/DBLayer: Restore pet loading
closes #5878
2012-03-26 18:58:24 +02:00
Kandera da540d5584 Core/Spells: Fix Necrotic Touch proc closes #538 2012-03-26 12:05:27 -04:00
Kandera 7b357a5028 Core/Spells: Fix Misdirection (thx to elron) closes #5869, #4343 2012-03-26 11:37:03 -04:00
leak b1ca1ee5ec Core/DBLayer: Convert PAppend() queries to prepared statements No.4 NOTE:
Most of the cores queries have been converted to prepared statements now. If your code contains queries, please either use the exiting or implement new statements.
The only exclusions are one-time queries (e.g. for core startup) and queries that can't be prepared due to limitations.
2012-03-26 15:47:37 +02:00
kaelima 786c226b74 Core/CombatLog:
- Send more proper hitinfo values in SMSG_ATTACKERSTATEUPDATE (still lot of research todo)
- Some renaming and commenting

- Minor cleanup in Player::UpdateZone
2012-03-26 02:16:19 +02:00
Shocker 48dc9313b9 Core/Misc: Fix logic for owner check in Unit::RemoveGameObject 2012-03-26 02:50:08 +03:00
Shauren 9ec61089be Core/Player: Fixed accessing possibly deallocated memory 2012-03-25 22:24:11 +02:00
Subv 04099402cd Core/Players: Use correct size in variables 2012-03-25 13:05:13 -05:00
Subv 19747fb95e Core/DBLayer: Use correct Get method in some DB fields 2012-03-25 12:59:18 -05:00
leak 71c02fb54d Core/DBLayer: Convert PAppend() queries to prepared statements No.2 2012-03-25 18:32:26 +02:00
leak c6cbe4c77c Core/DBLayer: Convert PAppend() queries to prepared statements No.1 2012-03-25 16:25:06 +02:00
Subv 56fac5e1af Memory: Get rid of some memory leaks, converted FormationMgr back to singleton 2012-03-25 09:25:28 -05:00
leak e37a4e5fe2 Merge pull request #5870 from Elron103/pull-requests5
Core: Fix warnings
2012-03-24 16:14:21 -07:00
Elron103 7daf69f20c Core: Fix warnings 2012-03-24 18:25:24 +01:00
click bdbc1312c3 Core: Remove some silly pramga-section warnings 2012-03-24 15:05:23 +01:00
leak 12e55a04bb Core/DBLayer: Convert PQuery() queries to prepared statements 2012-03-24 01:25:08 +01:00
Shauren 479c0976ab Core/Creatures: Properly initialize m_zoneScript when it depends on zone id (OutdoorPvP/Battlefield) and fixed z offset for hovering creatures at creation 2012-03-23 00:48:32 +01:00
Elron103 6d9dbefe94 Core/Units: Fix issues with threat management on phase changes 2012-03-20 22:15:11 +01:00
Shauren 568e524c45 Core/Spells: Implemented CREATURE_TYPEFLAGS_PARTY_MEMBER, creature with this type_flag set can be targeted by spells that require target to be in caster's party/raid 2012-03-19 20:44:30 +01:00
Kaelima eff48a42d1 Core/Spell: Fix crash for Glyph of Divinity 2012-03-18 19:57:03 +01:00
Machiavelli 5acbd35411 Core/Movement: Update MOVEMENTFLAG_MASK_MOVING, thanks to idostyle 2012-03-18 13:22:36 +01:00
Machiavelli 48799f3376 Core/Units: Fix movementflag apply for flying/hovering creatures on respawn 2012-03-18 11:35:33 +01:00
Subv 9fc7fe6b28 Merge pull request #5748 from MrSmite/Pet_1
Pet - Fix focus regen gets stuck due to lag/high diffs
closes #5153
2012-03-17 15:27:17 -07:00
Subv 21ccfb8e2e Collision/GameObjects: Fixed LoS for all doors (open and closed). Looks like data0 for type 0 is in fact startClosed instead of startOpen
closes #5660
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-03-17 15:58:47 -05:00
Machiavelli 41cc704bf8 Core/Movement:
- Don't abort relocation if movementflag restrictions were violated. There might be lag between client and server and even different parts of the core that made this approach improper.
- MOVEMENTFLAG_ROOT cannot be used in conjunction with MOVEMENTFLAG_MASK_MOVING, but it's a valid flag to receive from client.
- Fix falling to ground when unapplying fly/waterwalk aura. NOTE: This is a client-side initiated fall, in the future this should be initiated and updated by the server. (Working on it)
- Rename MOVEMENTFLAG_FALLING to MOVEMENTFLAG_FALLING_FAR
- Rename MOVEMENTFLAG_JUMPING to MOVEMENTFLAG_FALLING

Closes #5751
2012-03-17 20:36:12 +01:00
Machiavelli 57a71c8dff Merge pull request #5763 from w1sht0l1v3/master
Core/Unit: Disable spline movement on death. 

Fixe respawning after ForceDespawn is called.

Closes #4518
2012-03-17 09:33:29 -07:00
w1sht0l1v3 b76c2c144d Core/Unit: Fix respawning after ForceDespawn is called. 2012-03-17 18:26:22 +02:00
Gyx 1e94ab8d51 Core/Game: Code style and remove unused core.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-17 20:13:37 +08:00
MrSmite b61759c9ea Pet - Fix focus regen gets stuck due to lag/high diffs
closes #5153
2012-03-16 19:34:04 -04:00
kaelima 23c5ce0e0a Core/Unit: Fix some movement issues when leaving vehicles introduced in dce0a7d184
Sorry about that.
2012-03-16 22:52:20 +01:00
Machiavelli 65453620e8 Core/Movement: Do not process server side relocation if reading movementinfo from client resulted in violations (= hacking). 2012-03-16 18:15:08 +01:00
Machiavelli f8c04b1bc5 Core/Movement: Fix players still able to fly on SPELL_AURA_FLY and SPELL_AURA_MOD_INCREASE_MOUNTED_FLIGHT_SPEED unapply.
Closes #5731
2012-03-16 17:10:01 +01:00