Commit Graph
2144 Commits
Author SHA1 Message Date
Ovahlord 7648eff6db Core/Quests: check if a player can take the next quest provided by its query data before trying to request its details 2021-07-25 14:57:41 +02:00
Ovahlord 1a5c06b61a Core/Packets: several updates to trading
* converted CMSG_INITIATE_TRADE, SMSG_TRADE_STATUS, SMSG_TRADE_UPDATED and CMSG_ACCEPT_TRADE to packet class
* fixed enchanting items via trade
* handle unknown fields in SMSG_TRADE_UPDATED
2021-07-11 23:48:50 +02:00
funjoker b64983d753 Fix build after cherry-pick 2021-06-26 01:07:04 +02:00
AlιAѕѕaѕѕιN 338c1e28ae [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

* Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

(cherry picked from commit 92d83c3c2eaba3f5b58dc98472318872f3a54706)
2021-06-26 00:58:18 +02:00
funjoker a7b20bc156 Revert "Core/Misc: Fix zonewide spell_area not being updated on quest update"
This reverts commit 107fbf5aa2.
2021-06-26 00:54:25 +02:00
funjoker 107fbf5aa2 Core/Misc: Fix zonewide spell_area not being updated on quest update 2021-06-26 00:47:02 +02:00
Ovahlord 5fd77a3b28 Core/World: implement database support for default map and realm wide world states 2021-06-13 16:07:38 +02:00
Ovahlord be239e4458 Core/Maps: implement map based world states and implemented support for required world states in achievement criterias
*converted Erduax' conditional achievement to world state based handling as example
2021-06-13 10:48:41 +02:00
Ovahlord 4430863a1e Core/Spells: Implement spell queue
As of patch 4.1 spell casts can now be queued up 400ms before a ongoing cast finishes or the global cooldown expires to deliver a smooth transitions between casts though emulators do not really benefit from it.

closes #224
2021-05-24 17:14:55 +02:00
Ovahlord 6446541738 Core/Skills: ported master branch handling for learning skills on levelup 2021-05-14 14:52:52 +02:00
Ovahlord b5994ec6c5 Core/Units: improved logic for determining when a power update shall happen 2021-04-30 16:48:26 +02:00
Ovahlord c764cce4a3 Core/Player: fixed an exploit that was causing seasonal currency counter to increase from refunding currency based items 2021-04-30 13:17:18 +02:00
Ovahlord 0ae695908c Core/Loot: converted SMSG_LOOT_RESPONSE to packet class and properly incorporate currency loot into loot generation 2021-04-30 12:50:14 +02:00
Ovahlord 9ff4bbd085 Core/Spells: ported implementations of SPELL_AURA_DISABLE_CASTING_EXCEPT_ABILITIES and SPELL_AURA_DISABLE_ATTACKING_EXCEPT_ABILITIES from master branch
closes #93
2021-04-21 18:51:34 +02:00
Roc13x abb5164f55 Core/Channel: Implement use of CHANNEL_DBC_FLAG_INITIAL (#256)
Reduces differences with TC
2021-04-20 16:06:10 +02:00
Roc13x 57b4f7e51b Core/Items: Prevent broken items from applying reforge effects (#257) 2021-04-20 16:05:39 +02:00
Ovahlord 1a6f62d660 Core/Packets: converted SMSG_GUILD_NEWS, SMSG_GUILD_EVENT_LOG_QUERY_RESULTS and SMSG_GUILD_BANK_LOG_QUERY_RESULTS to packet class 2021-04-19 14:49:48 +02:00
Ovahlord 974f3163bc Core/Packets: converted SMSG_CORPSE_RECLAIM_DELAY to packet class 2021-04-16 18:09:08 +02:00
Ovahlord c77c435363 Core/Spells: check enchantment and item procs for SPELL_ATTR3_CANT_TRIGGER_CASTER_PROCS as well to fix potential endless loops such as Rune of Razorice which can proc themselves over and over again 2021-04-09 14:37:04 +02:00
Shauren 0f02c6a699 Core/Spells: Implemented SUMMON_PROP_FLAG_PERSONAL_GROUP_SPAWN 2021-03-29 20:56:00 +02:00
Ovahlord 4f23fb3d29 Core/Quests: make the player questgiver handling a bit more flexible to allow popup quest accepting at more places in the future 2021-03-28 14:44:16 +02:00
Ovahlord 83298b52a2 Core/Spells: ported SpellInterruptFlags updates from master branch and corrected some own implementations based on these new results 2021-03-25 15:53:26 +01:00
Shauren fed82c1002 Core/Auras: Defined and implemented many new interrupt flags 2021-03-24 14:53:30 +01:00
Ovahlord f68076a9ec Core/Misc: fixed static analysis issues 2021-03-11 19:37:39 +01:00
Ovahlord fe7816bb71 Core/Spells: fixed sending cooldown data in SMSG_SEND_KNOWN_SPELLS 2021-03-08 21:59:55 +01:00
Ovahlord 0299fa4fe1 Core/Misc: replace boost::optional with std::optional 2021-02-19 14:07:43 +01:00
Ovahlord 928aeccd59 Core/Items: ported random enchantment updates from master branch 2021-01-24 14:36:07 +01:00
Ovahlord 4420d35bfe Core/Players: correct packet content of SMSG_RESYNC_RUNES and send converted runes that have been converted previously since the effect handler for SPELL_AURA_CONVERT_RUNE only sends it when converting an unconverted rune
closes #214
2021-01-15 12:10:49 +01:00
Ovahlord 18cfca291b Core/Packets: converted SMSG_REQUEST_CEMETERY_LIST_RESPONSE and SMSG_RAID_GROUP_ONLY to packet class 2021-01-10 17:09:16 +01:00
Ovahlord f9f69bb0fe Core/Packets: converted SMSG_RAID_INSTANCE_MESSAGE, SMSG_PENDING_RAID_LOCK, SMSG_INSTANCE_SAVE_CREATED and SMSG_TRANSFER_ABORTED to packet class 2021-01-10 11:55:10 +01:00
Ovahlord 45d5f647b5 Core/Packets: converted SMSG_UPDATE_LAST_INSTANCE, SMSG_UPDATE_INSTANCE_OWNERSHIP and SMSG_INSTANCE_INFO to packet class 2021-01-10 09:40:17 +01:00
Ovahlord c3831d30e5 Core/Packets: converted SMSG_PARTY_MEMBER_STATE and SMSG_PARTY_MEMBER_FULL_STATE to packet class
* handle GROUP_UPDATE_FLAG_PHASE when changing phases
* define and implement GROUP_UPDATE_FLAG_WMO_GROUP_ID
2021-01-09 16:42:53 +01:00
Ovahlord 455e74d3c5 Core/Players: fixed a warning 2021-01-06 15:51:15 +01:00
Ovahlord 287a505c1b Core/Packets: converted SMSG_PVP_CREDIT, SMSG_DEATH_RELEASE_LOC and SMSG_BINDER_CONFIRM to packet class 2021-01-05 11:35:57 +01:00
Ovahlord e2d6a2f0cd Core/Players:
* converted SMSG_SET_PROFICIENCY to packet class and corrected initial sending for it
* removed death rune hack and replaced it with the correct packet instead
* corrected sending order for a few login packets
2020-11-21 14:45:36 +01:00
Ovahlord 754c138f89 Core/Spells: ported CastSpell unclusterfucking from 3.3.5 branch 2020-11-04 22:37:11 +01:00
Ovahlord 251f147efb Core/Players: fixed sending correct weekly cap for rated BG conquest points 2020-11-02 20:09:09 +01:00
Ovahlord 4c8fe1c08e Core/Packets: converted SMSG_BATTLEFIELD_LIST to packet class and handle remaining fields 2020-11-02 02:33:29 +01:00
Shauren d6aa5e333e Core/DBLayer: Fixed memory leaks with existing SQLQueryHolder uses and eliminated the possibilty of adding more in future (replaced manual memory management with smart pointers) 2020-10-26 18:03:54 +01:00
Ovahlord ac8741e3bc Core/Packets: converted more packets to class 2020-10-23 12:30:45 +02:00
Ovahlord f8c35be20c Core/Players: fixed a possible crash when trying to send spell cooldowns for spells without a category entry 2020-10-22 21:37:31 +02:00
Ovahlord a311740d3b Core/Players: PCT spell mods are now additive as well (this got changed in 6.x) 2020-10-22 18:58:13 +02:00
Ovahlord 72d7819c2e Core/Misc: converted more packets to packet class and implement some new fields for them 2020-10-22 08:47:24 +02:00
Shauren 0f60c4d820 Core/Players: Corrected logic determining contested/friendly/hostile area types 2020-10-02 18:53:07 +02:00
Ovahlord 941194018d Core/Players: reduce excessive casting of spell_area spells by casting them only when zone and area ids actually change 2020-09-26 19:38:49 +02:00
Shauren 64bc20bf35 Core/Players: Directly store PlayerSpell in m_spells, not as pointer 2020-09-07 21:36:13 +02:00
Ovahlord afba1ba347 Core/Quests: launch gossips on rewarding quests only when the corresponding quest flag is present 2020-08-27 23:22:28 +02:00
Ovahlord 30e787d5a4 Core/Player: update agility dodge coefficients 2020-08-27 21:41:21 +02:00
Roc13x 110f178527 Core/Player: HasItemCount and DestroyItemCount now count bank bags 2020-08-24 23:49:47 +02:00
Roc13x c8d6fc99c0 Core/Player: Fix equipment sets not saving correctly
New sets were always saved to _equipmentSets[0], overwriting eachother
2020-08-24 23:49:47 +02:00