Commit Graph
17603 Commits
Author SHA1 Message Date
Naios 0778cc3332 Core/DBUpdater: Use correct formatter for size_t
* thanks @DDuarte pointing this out.

(cherry picked from commit b2b8de5786364d81fbce643e8f00bcc0129ed760)
2015-03-24 22:02:08 +01:00
Naios 4201ca021b Core/DBUpdater: Add the possibility to limit the remove of orphaned entries.
* This will save you from loosing your update history if you use a repository in bad state (revision or branch) by mistake.
* Also turned 1 error message into a warning

(cherry picked from commit 966282fbed24a0d0cf8cb3e05b1849c3e6a0d1d6)
(cherry picked from commit 3ad7776d5061308d3e2b4ff9e3cbf67d48bffdd6)
2015-03-24 13:03:55 +01:00
tkrokli d1221e3433 [Core/Quest] Update quest Objective status Client side
by @untaught; closes #12172

AreaExploredOrEventHappens does not update client side, only server side.
Before adding this fix, it is necessary to complete the required number of kills
to receive the "discovery" Quest Objective Credit in player's Quest Log and on screen.
2015-03-22 06:32:18 +01:00
Naios 4fd51ab3b9 Core/DBUpdater: Use correct uint64 to store timestamps.
* Thanks @Shauren for pointing out.
* Also removes an invalid argument thanks @jackpoz for noticing.

(cherry picked from commit 8e48ef7863c5018aa185913ce6a616e46ef5b17e)
2015-03-22 01:33:58 +01:00
Shauren 8bdd94f849 Core/DBUpdater: Fixed compile errors with boost 1.55 and VS 2013
(cherry picked from commit 495af75b7e21a2a84231b0540a6f2b9ed349ea58)
2015-03-22 00:35:05 +01:00
Naios 93457ac9d8 Core/Database: Fix some warnings on gcc
* warning: when initialized here [-Wreorder]
* thanks to @Vincent-Michael

(cherry picked from commit cff3910ec82b9f5ebc462a756ce39cc062120cfa)
2015-03-22 00:34:07 +01:00
jackpoz d888e4c7ad Scripts/Ulduar: Fix some Flame Leviathan issues
Fix some Flame Leviathan issues:
- Fix boss evading all the time due to bad Doors check
- Opened "Lightning Door" to other bosses only after boss dies
- Eject players from the vehicles when boss dies, make them untargetable and despawn them after 5 minutes (adjust the time to the blizzlike time of choice)
2015-03-21 23:57:49 +01:00
Naios 2bd1c8541d Core/Updates: Add an automatic database update system. Automatically detects new and edited sql updates through file lists and hashing. Detects renames, deletes and is able to create and auto import full databases. * cleanups in main.cpp of world & bnetserver * refactoring in DatabaseWorkerPool.h & MySQLConnection.cpp
Make sure you re-run cmake, because boost::iostreams was added as dependency.
Maybe you need to install libboost-iostreams1.55-dev on unix as well.

Import every update manual until (included) those INSERT IGNORE updates for each database.

Thanks DDuarte and Shauren for your amazing ideas, help and advises.

In hope that nobody gets a "Your database structure is not up to date..." anymore ,-)

(cherry picked from commit 352012e53173372ebc82898e1b6854c983b01b25)
(cherry picked from commit 1f7f9feafc3f5017d617634ae993d2cdf4430920)

For 3.3.5:
* Synchronized ConfigureBoost.cmake with 6.x, libboost-filesystem1.55-dev also added as dependency!

Signed-off-by: Naios <naios-dev@live.de>
Signed-off-by: Nayd <dnpd.dd@gmail.com>
2015-03-21 20:54:54 +00:00
MitchesD 3af363308a Scripts: remove whitespaces 2015-03-20 13:11:59 +01:00
MitchesD 7d3668b0b9 Merge pull request #14388 from Rushor/Spell
Scripts/Spells: Hand of Reins - Questsupport for 'Mounting Up'
2015-03-20 12:39:47 +01:00
Nyeriah ea78bce592 Scripts/ToC: The Lich King event should only be started by the announcer 2015-03-19 19:07:32 -03:00
ariel- 461daadcaf Split up LANG_MAP_POSITION to fix a crash when issuing .gps command 2015-03-19 06:08:27 -03:00
Nayd 2ac40775a2 Core/Spells: Implement HasAttribute() helper for SpellInfo for easier readability
Original code by @Shocker (6.x branch)
2015-03-18 23:16:39 +00:00
Naios e96676aedd Core/Misc: Fix some issues detected by static analysis
* Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
  -> This argument is passed by value, it makes no sence so set it to null here.

* Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor.

(cherry picked from commit 433bc289c2c82b7377ad0189e415a3ca070d220f)
2015-03-18 20:23:47 +01:00
Naios dfe5e1e561 Core/RemoteAccess: Remove an unused define in RASession
* probably fixes gcc compile after adding cppformat

(cherry picked from commit a610dea85c77da9ce6c2be5b10f8259e3f315227)
2015-03-18 16:38:38 +01:00
Naios fc665b14dc Core/Log: Readd include of <stdarg.h> to fix compile issues under gcc
(cherry picked from commit d64e6ffade392be32f634b32658a6e0353f369c1)
2015-03-18 15:37:43 +01:00
Rushor 588b92ee05 Scripts/Spells: Hand of Reins - Questsupport for 'Mounting Up'
by @untaught closes #3977
2015-03-18 13:11:09 +01:00
Shauren bba8555a29 Build fix 2015-03-18 11:47:30 +01:00
Carbenium 6757ef2217 Core/Authserver: Include cppformat 2015-03-18 03:01:39 +01:00
Carbenium 03176662d1 Merge pull request #14317 from Naios/typesafelog
Type safe logging
(cherry picked from commit cc0c9add5a3f3a17e19029ddcaa7e711040f4fc5)

Conflicts:
	src/server/bnetserver/CMakeLists.txt
	src/server/game/Server/WorldSocketMgr.cpp
	src/server/shared/Logging/AppenderDB.cpp
	src/server/worldserver/CMakeLists.txt
2015-03-18 02:59:40 +01:00
Naios 301ec0be56 Core/Game: Fix some issues detected by static analysis.
* Possible inefficient checking for 'list' emptiness.

* Variable '_scheduledScripts' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Variable 'Text' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Possible inefficient checking for 'm_loadedScripts' emptiness.

(cherry picked from commit 9a61049f88835fd6bdb75905f042583d038d0667)

Conflicts:
	src/server/game/Server/Packets/TicketPackets.cpp
2015-03-18 01:13:47 +00:00
Naios a38945a3b3 Core/Log: Fix some issues detected by static analysis.
* Either inefficient or wrong usage of string::find(). string::compare() will
  be faster if string::find's result is compared with 0, because it will not scan the whole string.
  If your intention is to check that there are no findings in the string,
  you should compare with std::string::npos.

* C-style pointer casting detected. C++ offers four different kinds of casts as replacements:
  static_cast, const_cast, dynamic_cast and reinterpret_cast.

(cherry picked from commit 8882a6ca78e90d2980a3cd8d53acea9d2137f8b8)
2015-03-18 01:13:46 +00:00
Nyeriah a76722ccef Scripts/Undercity: Update Lady Sylvanas' script and also implement few missing things to Journey to Undercity's quest end event
Closes https://github.com/TrinityCore/TrinityCore/pull/14094
Thans to @Killyana @Rushor @jaredjones and all others who helped with this
2015-03-17 20:18:09 -03:00
Duarte Duarte 769acfbd02 Merge pull request #14370 from Kittnz/realm_achievement
Core/Condition: Realm Achievement condition
2015-03-17 12:42:35 +00:00
Rushor f723b18164 Scripts/Borean Tundra: Enable Texts for 'Nesingwary Trapper'
by @Killyana + @danlapps
closes #10234
2015-03-17 00:05:06 +01:00
Kittnz e50489c010 Core/Condition: Added Realm Achievement condition
- Partly Fixes https://github.com/TrinityCore/TrinityCore/issues/5754
@DRJ has SQL examples
2015-03-16 20:03:49 +01:00
joschiwald d3ad87b1cf Core: silence broadcasttext startup errors 2015-03-16 14:18:31 +01:00
click cf14e9051d Merge pull request #14371 from Kittnz/movecirclepath_003
Core: Move FillCirclePath function to MotionMaster
Closes #14371
2015-03-15 21:32:35 +01:00
click 7c8f7f6f8f Core/AHBot: Remove a lingering warning that annoyed me for all too long 2015-03-15 21:04:51 +01:00
Nayd 0ebc15e6f4 Core/DBLayer: Remove references to table character_currency (6.x only)
Ref 170bc318b3
2015-03-15 15:50:05 +00:00
Rushor eee10edb56 Merge pull request #13997 from Rushor/malfurion
Scripts/SunkenTemple: Add Eventsupport for NPC: Malfurion Stormrage
2015-03-15 15:41:27 +01:00
Nayd dbcfa3b120 SpellAuras.cpp: typo fix 2015-03-15 14:09:00 +00:00
joschiwald 170bc318b3 Core/Player: fixed some leftovers in db after player delete
* character_arena_stats
* character_battleground_random
* character_cuf_profiles
* character_currency
* character_stats
* character_void_storage

(cherry picked from commit 2955a1f595be8ba510260e5a84b53663f2300fff)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/shared/Database/Implementation/CharacterDatabase.cpp
	src/server/shared/Database/Implementation/CharacterDatabase.h
2015-03-15 13:06:49 +00:00
Shauren a23ad2b33c Core/Auras: Fixed possible crash in Aura::RefreshDuration - Aura::GetCaster can return NULL
(cherry picked from commit 8cd1c9514f336da3d3d9436be554fc80edb6e761)

Conflicts:
	src/server/game/Spells/Auras/SpellAuras.cpp
2015-03-15 12:57:08 +00:00
Kittnz 61557ee7c6 Core: Move FillCirclePath function to MotionMaster 2015-03-14 23:25:19 +01:00
jackpoz f1ae2c7b73 Revert "*Do not allow players to use vehicles to go further than 1st boss in Ulduar."
This reverts commit a009e53049.
Remove hackfix for Ulduar vehicles, it should be handled in Ulduar script
2015-03-13 21:48:42 +01:00
jackpoz 9948e633ab Revert "Core/Server: Catch exceptions in int main()"
This reverts commit 958999ff5c.

Closes #14329
2015-03-11 20:59:21 +01:00
jackpoz 22403121fe Core/Dungeon Finder: Fix Vote Kick breaking LFG queue
Fix Vote Kick started with party in queue breaking the whole LFG queue. The status of Vote Kick is now storing in a bool variable in LfgGroupData, separated from LfgState of the group/members.
If a Vote Kick started with party in queue, the members were not removed from queue correctly and would cause LFG matching system to match these "broken" players but not allowing to start a dungeon.

Closes #10191
2015-03-10 21:11:54 +01:00
leak 147a959f51 CMake: Remove unused source reference 2015-03-09 14:53:23 +01:00
click f3101d20a9 Core: Change a few 'stupid' log-messages down to DEBUG-level 2015-03-08 12:01:33 +01:00
click 356f3b6bc5 Core: INFO->ERROR level adjustment in ObjectMgr.cpp
Suggest everyone attempt to remember this:
 TC_LOG_TRACE  = extreme debugging (debuginfo with packetstructures/data)
 TC_LOG_DEBUG  = debugging (detailed activity of functions and activites inside core)
 TC_LOG_INFO   = normal runstate (regular info like logins/logouts/levelups/passwordchanges etc)
 TC_LOG_WARN   = possible issue with config/data etc - things that are not how they should be)
 TC_LOG_ERROR  = actual error that has been either caought or must be fixed at some point
 TC_LOG_FATAL  = crash or data corruption imminent
Using the right logmech also helps distinguishing between 'regular runtime info' and stuff that might lead to a pissy situation later on... :)
2015-03-08 07:47:17 +01:00
click 0c7c25d6ed Core/Script: INFO->DEBUG notification changes in ToC 2015-03-08 06:35:15 +01:00
click a8a5fae4f9 Core/Scripts: INFO-DEBUG changes in scripts (gawd) 2015-03-08 06:34:49 +01:00
click ad7b33a47f Core: INFO->DEBUG level changes - forgot one in Map.cpp 2015-03-08 06:34:19 +01:00
click 781edbe46a Core: More INFO -> DEBUG changes 2015-03-08 06:33:57 +01:00
click d5718f3372 Core: WARN instead of INFO - this is actually something we'd want to be informed of... 2015-03-08 06:17:32 +01:00
click 6f961ba138 Core: And yet more INFO->DEBUG logging 2015-03-08 06:16:46 +01:00
click a31bc08e44 Core: Pet.cpp - INFO -> DEBUG level notifications... 2015-03-08 06:12:01 +01:00
click 64584e9e7a Core: More INFO -> DEBUG (Unit.cpp this time) 2015-03-08 06:11:12 +01:00
click 6e509cf7c1 Core: INFO->DEBUG cleanups in Player.cpp 2015-03-08 06:06:03 +01:00