Commit Graph
68 Commits
Author SHA1 Message Date
Nay b30aeb8d51 Core/Objects: Method to get nearest GO of type X, FindNearestGameObjectOfType
Thanks Subv for the idea
2012-09-08 23:16:35 +01:00
Shauren e0997874f5 Core/SpellScripts: Changed OnUnitTargetSelect hook to OnObjectAreaTargetSelect, it will now work with WorldObject instead of only Units and call it even for empty target lists 2012-06-29 21:53:35 +02:00
Kandera 648321e121 Core/Spelld: fix target selection for ground based aoe spells. use the center of the cast (dynamic object) instead of the caster for checking los 2012-05-15 13:26:15 -04:00
Kandera 6c15bee884 Core/AI: fix the call to help handler to use distance from the npc and not the victim of the npc. (thx shauren) 2012-05-08 09:17:04 -04:00
Shauren 4818c70dcb Core/Spells: Removed unneeded phase check from spell casts, its already done in canSeeOrDetect for spells that need it. Probably more phase checks are not needed either 2012-04-18 22:27:40 +02:00
kaelima 49e24e2dfb Core/Cleanup:
Mostly if(.. -> if (.. and for(.. -> for (..
but also some miscellaneous cleanup
2012-04-08 23:59:52 +02:00
Shauren ae0511a2a4 Core/Spells: Fix DynamicObject AoE effects for invisible targets e.g Flare. Original patch by Elron
Closes #5898
2012-03-28 01:13:58 +02:00
Shauren 568e524c45 Core/Spells: Implemented CREATURE_TYPEFLAGS_PARTY_MEMBER, creature with this type_flag set can be targeted by spells that require target to be in caster's party/raid 2012-03-19 20:44:30 +01:00
thomas33 cae662d191 cleanup 2012-03-13 15:48:18 +01:00
thomas33 0532afed90 more cleanup 2012-03-13 14:53:36 +01:00
kaelima 6217583627 Core/Map:
- Remove mysterious restriction in visibilityhelper for gameobjects
- Some cleanup in CheckAreaExploreAndOutdoor() and GridDefines.h
- Set nocreate for cells visited in Map::VisitNearbyCellsOf
2012-03-12 04:33:24 +01:00
Spp 1e246cb66c Fix build (gcc) and fix warnings 2012-02-22 09:15:57 +01:00
QAston f09b5a6bea Core/Db/Conditions:
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required

Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
Kandera c517806a23 Scripts/Spells: Convert code from Spell::EffectDummy to spell scripts. 2012-02-18 12:12:49 +01:00
Shauren 65d269f6de Core/Spells: Allow dead players as valid objects for RaiseDeadObjectCheck (enables Raise Dead on players that have not yet released spirit)
TODO: Allow all corpses
2012-02-15 00:46:08 +01:00
Shocker 08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
kiper 8299627ed9 Update headers for 2012. HAPPY NEW YEAR!!! 2012-01-01 00:32:13 +01:00
QAston 15bd8f3cd5 Core/Spells: Fix logic in AnyDeadUnitSpellTargetInRangeCheck - spells using this should now correctly check target requirements. This is an alternative fix to #4112. 2011-12-24 08:40:30 +01:00
Bootz d1334624da Core: Codestyle clean-up
"pl"->"player"

 Note: codestyle methods needs maintained, Player* player.
still to do properly clean-up chat.cpp.
2011-11-07 11:18:00 -06:00
Bootz f75ec5ba2b Core: Codestyle clean-up
"plr"->player

Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
kaelima f2000f3fb5 Core/Misc: Some minor cleanups
Fixed SQL added in prev commit.
2011-10-24 23:33:17 +01:00
megamage c29ff41001 Rename some classes in grid system.
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
megamage f9fc12650b Merge pull request #3259 from Souler/pull
Traps and Basic Campfire ignoring unattackable flags.
2011-10-08 13:36:05 -07:00
Bootz 5b4c7783c2 REPO: Code-style clean-ups
* Fixed pMap->map
* Fixed pInstance->instance
* Fixed pInsta->instance
* Fixed pQuest->quest
* Fixed pWho->who
* Fixed pTarget->target
* Fixed pGo->go

~DEVNOTES: Handlers/QuestHandler.cpp still needs to be cleaned...
2011-10-07 19:45:43 -05:00
Bootz 81c0a3a847 REPO: code-style clean-up
* Fixed pPlayer->player
* Fixed pCreature->creature

~DevNote: codestyle for Player should be (*player), not *plr or *p...
same goes for Creatures (*creature)... more cleaning needed.
We've way too many codestyles happening here.
2011-10-07 11:08:09 -05:00
Bootz f1ccb83dc0 REPO: Code-style change
* Fixed pUnit-unit
2011-10-07 10:48:56 -05:00
Nay 0f7d9e4837 Core/SAI: Fix an issue where SAI was ignoring civilian and passive unit flags
Closes #2526
Disclaimer: This was not thoroughly tested; report any issue caused by this change.
2011-10-01 16:29:23 +01:00
Souler 0f9fc672d5 Core/Grids: Traps shouldn't target unattackable units.
Hunter traps and Basic Campfire will no longer activate unattackable creatures.
2011-09-29 10:53:27 +02:00
Shauren 63b62d4ad0 Core/Grids: Added GameObjectWorker 2011-09-17 13:18:42 +02:00
QAston fe25ce4fa3 Core/AI: Replace many Unit::IsHostileTo with Unit::IsValidAttackTarget or Creature::canCreatureAttack. 2011-09-17 00:56:59 +02:00
QAston c0b1823524 Core/Entities: Replace Unit::canAttack usage with more accurate Unit::IsValidAttackTarget 2011-09-16 23:49:31 +02:00
Spp af05915b9e [Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions) 2011-09-15 14:12:57 +02:00
Spp- 3fac9914be Core: Code cleanup (here and there) 2011-09-05 14:01:50 +02:00
QAston 71b9e0d8de Core/Spells: Make mind sear aoe no longet target unit at which caster is channeling the spell. 2011-09-01 09:07:14 +02:00
QAston e2d8faea09 Core/Spells: move Cannibalize and Carrion Feeder cast checks to SpellScripts. 2011-08-20 00:30:38 +02:00
Spp- acd0fc79f6 Core: Pass by const reference for simple objects replaced with pass by value 2011-08-01 14:23:27 +02:00
Shauren a80b36c2f3 Core/Spells: Limited SPELL_ATTR3_PLAYERS_ONLY attribute to only allow players, not pets and totems. This fixes many boss area spells incorrectly selecting pets and totems as their targets. 2011-08-01 11:17:34 +02:00
Machiavelli 0711746b57 Core/Visibility: Send object destroy packets to dead players. Fixes persistent visuals of no longer existing entities while dead.
Closes #2458
2011-07-31 21:58:28 +02:00
Spp- f37a2030c0 Core: Minor optimization in AnyUnfriendlyAttackableVisibleUnitInObjectRangeCheck 2011-07-12 13:30:33 +02:00
Lopin a233e7b9d8 Core/Misc: Add new function for selection nearest player in given distance 2011-07-11 16:17:21 +02:00
kaelima 9a67aaa8b8 DB/Creature:
- Nuke the hacky column DeathState.
- Removed some hacks from Kologarn script, including some cleanup.
- Removed set deathstate command.

BIG thanks to Malcrom for replacing all creatures that had deathstate with proper dynamicflags/auras.
2011-06-27 20:22:53 +02:00
Shocker e05f608919 Core/Spells: Don't allow Killing Spree to hit unattackable targets 2011-06-26 16:06:23 +03:00
Shocker 6b0b21fea7 Core/Spells: Don't allow Killing Spree to hit critters (by correcting AnyUnfriendlyVisibleUnitInObjectRangeCheck, this notifier may be used in the future for similar expected results) 2011-06-26 15:54:19 +03:00
Shocker ee717ad1ee Core/Misc: Don't allow non-combat pets to trigger hunter traps 2011-06-15 23:56:47 +03:00
click 158966dc79 Core: Codestyle cleanup 2011-06-11 22:35:29 +02:00
leak 1003f30448 Add spaces after commas 2011-04-29 20:47:02 +02:00
leak e2e9431ca3 Core/ObjectMgr: Refactor sGOStorage 2011-04-28 22:54:30 +02:00
tobmaps 05ef35c355 Core/Auras/Totems: Fixed incorrect visibility checks in target searchers 2011-04-22 22:23:20 +02:00
Shauren 2f79b0f266 Core: Removed all double (and more) empty lines 2011-03-21 10:52:14 +01:00
Machiavelli 957c69de83 Update copyright note for 2011.
Happy new year.
2011-01-01 15:01:13 +01:00