Commit Graph
620 Commits
Author SHA1 Message Date
ariel- c9101f6707 Core/Spells: workaround stealth interaction with Death and Decay and GameObject casts 2017-05-04 01:16:00 +01:00
ariel- d1c915e4e1 Core/Spells: require phaseMask set for trap activation procs 2017-05-04 01:11:16 +01:00
ariel- 44a779ad38 Core/SpellMgr: some changes in default proc generation. Fix an issue of stealth breaking with positive and/or healing spells 2017-05-04 00:57:39 +01:00
roc13x d30237fb1e Core/Globals: compute aura diminishing return info at startup and cache it 2017-05-04 00:57:24 +01:00
ariel- e0c8a379c8 Core/Spell: do not automatically set proc Family Name if no Family Flags present
Closes #18075
2017-05-04 00:21:36 +01:00
ariel- a47ee2ac5a Core/Spells: fix auto repeat spells triggering auras
Auto repeat spells are casted as triggered and didn't register procs properly if the aura can't proc with triggered
2017-05-04 00:21:13 +01:00
roc13x 0b2e5adeb1 Core/Globals: cache SpellSpecific and AuraState information instead of computing them each time they're needed 2017-05-04 00:12:11 +01:00
ariel- 51f26dfe51 Core/Spells: Implementation of QAston proc system 2017-05-03 20:08:08 +01:00
ariel- a3538f4dbe Core/Auras: don't skip stack rule check whenever spells have same ID
- The auras might not have the same amounts due to spellmods

Closes #1626
2017-04-16 11:46:11 +02:00
Keader 5387b34f3c Core/Spells: Fixed Chilled to the Bone
Closes #19417
thanks ariel-
2017-04-09 18:16:29 +02:00
Aokromes 9c5e580c17 Core/Scripts: minor fixes in boss_the_lich_king 2017-03-26 06:13:21 +02:00
ariel- d1382c5f23 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle
Closes #17234
2017-03-20 16:55:01 +01:00
ariel- 5f7ac85dca Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319
2017-03-20 16:53:13 +01:00
ariel- 936ddbff9b Core/Spell: disable proc for magnet auras, they're handled differently
Closes #19208
2017-03-03 01:33:07 +01:00
ariel- 891b8369e6 Core/Scripts: Thrusting Hodir's Spear
- Everything is sniffed, enjoy this hell of a quest!

Closes #12808
2017-03-03 01:26:12 +01:00
Keader 3bbec873f7 Core/Spell: Fixed Val'kyr Target Search exploit
Closes #16347
by ariel-
2017-01-20 15:12:40 +01:00
Keader 7787c97513 Core/Scripts: Illidari Council Rewrite
Thanks to Sirikfoll, Krudor and Offl for all help
2017-01-02 07:47:26 +01:00
Aokromes 719a317a67 Update copyright note for 2017 2017-01-02 07:26:38 +01:00
Keader 5f2fa73f7a Core/Scripts: Fixed Suppresser behavior in Valithria Dreamwalker encounter
Closes #18530
* Fixed range issue
* Fixed weave spawn when Summon Timmer Suppresser(70912) is casted
* Fixed spawn count
2016-12-28 16:04:38 +01:00
Keader 21cc1fd280 Core/Scripts: Rewrite Magtheridons Lair 2016-12-16 19:15:24 +01:00
Aokromes 66b91e07fa Core/Misc: Compile fix try 2016-11-19 07:19:38 +01:00
Aokromes 8a4bda8c9f Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default 2016-11-05 02:29:56 +01:00
Aokromes 5157c87198 Core/Spell: fix range for Ancestral Healing (shaman) and Grace (priest) 2016-11-02 03:22:59 +01:00
ariel- b70a713311 Core/SpellMgr: fix Abolish Disease/Poison targets
Spells were failing due to "out of range"
2016-11-02 03:18:07 +01:00
Aokromes 0be1e9c4d5 Core/SpellMgr: overwrite DBC RangeEntry for Safeguard 2016-11-02 02:54:50 +01:00
SnapperRy 5497eebe29 Script/Quest: Stop the Ascension! 2016-10-24 13:02:50 +02:00
Aokromes 57d0a5d16d Revert "Core/Spells: Implementation of QAston proc system"
This reverts commit a70e4e26b3.
2016-10-21 07:27:04 +02:00
Aokromes f8f2f64cd3 Revert "typo fix"
This reverts commit 5a9ae7eae6.
2016-10-21 07:26:34 +02:00
Aokromes 5a9ae7eae6 typo fix 2016-10-09 15:23:59 +02:00
Aokromes a70e4e26b3 Core/Spells: Implementation of QAston proc system
- Move checks from Unit::IsTriggeredAtSpellProcEvent (old system) to Aura::IsProcTriggeredOnEvent (new system)
- Templatize SpellModOp param of Player::ApplySpellMod, also killed charge counter from SpellModifier and Player system for handling charges... no point in having 3 different systems doing the same thing
- Automatically add default entries to spellProcMap, based on spellinfo (else auras won't proc without an entry) Based on old Unit::ProcDamageAndSpellFor
- Old Unit::ProcDamageAndSpellFor renamed to Unit::ProcSkillsAndReactives and made private, will no longer handle auras.
- Start making use of HealInfo::AbsorbHeal in unit calculations, add effective healing info to HealInfo struct
- Changes in spell reflection system, emulates old behaviour, delaying aura drop
- Removed old charge count hacks in SpellMgr::LoadSpellInfoCorrections
- Removed bogus error log when procChance is 0: Some auras have initial 0 procChance but modified by SPELLMOD_CHANCE_OF_SUCCESS
- Fixed TriggerAurasProcOnEvent logic that tried to trigger twice from actor.
- Allow non damaging spells with DamageClass Melee or Ranged to proc character enchants. Ref issue #17034:

  * http://web.archive.org/web/20110309092008/http://elitistjerks.com/f47/t49865-paladin_retribution_pve/
  * When an auto-attack lands (does not dodge/parry/miss) that can proc a seal the of the following things happen independently of each other (see 2 roll system).

  * 1) A "hidden strike" which uses melee combat mechanics occurs. If it lands it refreshes/stacks SoV DoT. Only white swings can trigger a refresh or stack. (This hidden strike mechanic can also proc things like berserking..)
  * 2) A weapon damage based proc will occur if you used a special (CS/DS/judge) or if you have a 5 stack (from auto attacks). This attack can not be avoided.

  * Holy Vengeance is the "hidden strike" it has an apply aura effect and damage class melee.
- Fixed Blood Tap interaction with Death Runes (btw, don't know what was going on with those MiscValueB, spell 45529 doesn't have any MiscValueB in SPELL_EFFECT_ACTIVATE_RUNE)
- Ported some AuraEffect checks from old Unit.cpp function. added new AuraScript hook to check procs of an specific effect
- Allow only AuraEffects that passed the check to proc, this won't block whole aura from proccing (and lose charges) if at least one of the effects procs, though
- Changes in spell mod system (for SPELLMOD_CASTING_TIME). fixes #17558.
- Added an exception for SPELLMOD_CRITICAL_CHANCE too, fixes #15193
2016-10-05 13:19:51 +02:00
ariel- 919a3c631e Core/Spell: Add Dual Wield skill dependency to Dual Wield effect, should remove the skill properly when unlearning spell.
Closes #17196
2016-10-03 14:53:59 +02:00
Aokromes a99ac65b80 fix build 2016-09-27 13:23:16 +02:00
Treeston 69e4236146 Scripts/AzjolNerub: Full rewrite 2016-09-27 13:01:58 +02:00
SnapperRy fc00c66433 Script/Quest: improvements for Let Them Eat Crow. (#17948) 2016-09-24 07:00:37 +02:00
ariel- 01ebe31fa8 Core/Spell: Workaround cobra strikes into a charged aura instead of stacked.
Fixes #754
2016-09-01 15:20:11 +02:00
SnapperRy c2f65d822b Core/SpellArea: only check against spell_area entries for the current quest when updating quest status
Closes #17804
2016-08-20 18:26:31 +02:00
ariel- 88bb891a71 Core/Misc: fix issues reported by static analysis 2016-07-26 03:15:20 -03:00
ariel- 4b24e404e7 Core/Spell: fix Wrecking crew
Closes #77
2016-07-23 16:52:00 -03:00
ariel- ba734a5be1 Core/Spells: update f35df037b6 for 4.3 spells 2016-07-23 16:15:37 -03:00
Aokromes f0c90fe8ca partialy revert previous commit 2016-07-20 19:29:16 +02:00
SnapperRy 2e02320302 Event/Midsummer: improve pole ribbon functionality (#17464)
Event/Midsummer: improve pole ribbon functionality:

- Bunny creature should hover, which puts it in the intended position.
- Use correct visual and internal spells to handle cosmetics and timers.
2016-07-20 18:37:26 +02:00
Aokromes 2102f40f4b Script/Quest: Improvements for quest Corrosion Prevention (27347): (#…
…17385)

- Energized! spell should target only the caster and any player around.
- Prevent trigger from gaining threat from beneficial spell casts, getting stuck in a "gaining threat but cannot attack, reset" situation.
- The Power Core Fragment near the zeppelin crash should always be active.
2016-07-20 18:09:14 +02:00
Aokromes f35df037b6 Core/Spells: Implement SPELL_ATTR7_INTERRUPT_ONLY_NONPLAYER 2016-07-20 18:03:54 +02:00
Shauren a4498c7cab Core/Auras: Renamed fields of SpellProcEntry structure and change types to more appropriate ones 2016-07-20 10:25:03 +02:00
Aokromes bbaf1216df Core/Spells: Fixed all cases of spells that crash the client when pressing ESC after being cast 2016-07-18 22:06:16 +02:00
SnapperRy 55fc90fbc3 Event/Midsummer: improve pole ribbon functionality (#17464)
Event/Midsummer: improve pole ribbon functionality:

- Bunny creature should hover, which puts it in the intended position.
- Use correct visual and internal spells to handle cosmetics and timers.
2016-07-17 16:32:52 +02:00
Gustavo 58aaccb8af Core/Scripts Corrections on Halion's Encounter (#16725)
Core/Scripts: Updates to Halion

* Fixed Combustion and Consumption.
* Fixed Living Embers and Blazing Auras.
* Timer changes.
2016-07-17 16:25:39 +02:00
Aokromes fa5965fdfb Core/Battlefield: Tol Barad
By Mihapro
2016-07-15 15:02:09 +02:00
Aokromes f58a2441aa Scripts/Firelands: Baleroc Encounter
By  Krudor
2016-07-03 14:21:02 +02:00
Aokromes dc11f9fdd5 Scripts/Instance: The Vortex Pinnacle
By Mihapro
2016-07-02 16:06:29 +02:00