Commit Graph
10112 Commits
Author SHA1 Message Date
Aokromes dbd4fc3eca Core/Spell: Compile fix try 2016-11-19 06:35:33 +01:00
Aokromes b1d4f802ef Core/Spell: move attribute helpers to spellInfo
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
2016-11-19 06:23:06 +01:00
Aokromes e4dd97765e Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)
2016-11-19 06:10:14 +01:00
ariel- b6f8ecbefc Core/GameObject: use a friendly trigger for positive spells.
Fixes an issue with Skadi Harpoons.

Note to self: should actually implement GameObject casting already :/
2016-11-15 05:48:22 +01:00
ariel- ad927acae4 Core/Spell: do not fail triggered Charge effects in case a root is present.
Fixes Master's call when pet is rooted
2016-11-15 05:47:59 +01:00
ariel- 66fb271921 Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect.
Closes #15388
2016-11-15 05:46:42 +01:00
ariel- 1fcb8e0b4e Core/Unit: consider creatures with same faction to be on the same party/raid for the purposes of spell/aura targets
Ref #18233
2016-11-15 05:46:05 +01:00
ariel- 760bef2453 Core/SpellScript: allow optional parameters to be passed to FinishCast
followup of 50a3ce5703bdaa4fe16e2e773eabafa9a4818083
2016-11-15 05:45:56 +01:00
ariel- 0037363f3a Core/Battleground: Fix issue reported by static analysis 2016-11-15 05:45:08 +01:00
Shauren 5ddf50bdee Core/Auras: Fixed removing auras triggered by aurastates
Closes #17868

(cherry picked from commit f94e6cee38241e10daed711247a18b8706cb8924)
2016-11-15 05:43:30 +01:00
ariel- 03c3279395 Core/Gameobject: remove immune flags from trigger used to cast GO spells
Spells were failing flags check in Unit::_IsValidAttackTarget

Closes #18206
2016-11-10 23:42:29 +01:00
Aokromes 8a4bda8c9f Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default 2016-11-05 02:29:56 +01:00
Richard b66a4f8dcb [3.3.5] Core/Loot: Fix conditional Master Loot (#17943)
* Core/Loot: Fix master looting of conditional items

follow_loot_rules was a flag intended to force certain quest items to be
master looted. It should not be used for the
NonQuestNonFFAConditionalLoot.

The flag was originally introduced in 869ea349
"Core/Loot: fix the way quest items are handled. so far ive only found 3
quest items that should be able to be masterlooted. added a new flag to
item_template.flagsCustom to allow for making a quest item always follow
loot rules. a bonus may be the fix of the handlelootmasteropcode crash!"

* Core/Loot: Rename QuestItem to NotNormalItem

QuestItem struct was being used for quest items, ffa items, and
conditional items. Renaming it to avoid confusion when working with ffa
and conditional items

* Core/Loot: Use existing AddAllowedLooter rather than reaching into allowedGUIDs directly

* Core/Loot: Rename NotNormalItem to NotNormalLootItem
2016-11-04 12:26:09 +01:00
treeston c91f195554 Core/Creature: Correctly reset pathfinding capability on respawn. Prevents evade chains on some bosses. Closes #18188. 2016-11-03 16:14:09 +01:00
Aokromes 0fe4e3e73e Core/Misc: Fix dynamic build 2016-11-02 09:06:57 +01:00
Aokromes 94ca5c157a Core/Gameobject: Build fix 2016-11-02 07:26:46 +01:00
Aokromes c9dd490372 Core/Misc: copy&paste enrrage is bad 2016-11-02 06:28:28 +01:00
Aokromes cdccb459bd Core/Gameobject: Revert bad delete 2016-11-02 06:21:20 +01:00
Aokromes 8b5acac9fa Core/Misc: Trow some consts and nullptr 2016-11-02 06:15:49 +01:00
Aokromes bf67979789 Core/Misc: missing part 2016-11-02 05:53:50 +01:00
Aokromes 6d49df2635 Core/GameObject: added possibilty for gameobjects to contain money loot 2016-11-02 05:47:52 +01:00
Aokromes de6b2eeca1 Revert "Core/Unit: send original caster in heal packet log"
This reverts commit 7290ff87e7.
2016-11-02 04:44:36 +01:00
Aokromes 1659ea03cf Core/GameObject: spawn linked traps at gameobject creation instead of…
… using DB spawns.
2016-11-02 04:01:09 +01:00
ariel- 1ec9685547 Core/Auras: fix elixir aura saving 2016-11-02 03:48:24 +01:00
Shauren a618a6b121 Core/Transports: Fixed crash added in b88cecb656c62cd3bcc3ae2a171b173eb64a28c9 2016-11-02 03:47:20 +01:00
Shauren bf19fe3e26 Core/Transports: Added extra transport position update just when it stops moving
Closes #17952
2016-11-02 03:46:52 +01:00
Aokromes fa05752893 Core/Quest: Only delete all quest bound items from inventory on turn …
…in if the quest is not repeatable
2016-11-02 03:46:16 +01:00
Aokromes a81a44174b Core/Auras: don't save auras casted by items
- Drop useless field from DB (itemGuid was being saved, but never used, see Prepared Statements)
- This type of auras (like Water Bucket, Precious Ribbon, etc) will be recasted on login anyways.
2016-11-02 03:36:16 +01:00
Aokromes 065b6fdc2c Core/GameObjects: Handle despawning and respawning of nearby linked t…
…raps on gameobject despawn and respawn
2016-11-02 03:27:25 +01:00
Shauren 93fd8f2511 Core/GameObjects: Fixed Frozen Trap target selection
Closes #14238
Closes #17517
2016-11-02 03:23:23 +01:00
Aokromes 5157c87198 Core/Spell: fix range for Ancestral Healing (shaman) and Grace (priest) 2016-11-02 03:22:59 +01:00
ariel- b70a713311 Core/SpellMgr: fix Abolish Disease/Poison targets
Spells were failing due to "out of range"
2016-11-02 03:18:07 +01:00
Aokromes 7290ff87e7 Core/Unit: send original caster in heal packet log 2016-11-02 03:16:18 +01:00
SnapperRy 477ba4e439 Core/SAI: reset event phase when calling SMART_ACTION_CALL_SCRIPT_RESET.
Now it really does what it says on the tin.
2016-11-02 03:14:26 +01:00
ariel- b6f3457458 Core/Auras: only apply shapeshift aura passives when changing forms
Closes #14845
Closes #17617
2016-11-02 03:12:38 +01:00
ariel- 4e61ff8c9c Core/Unit: consistency fix 2016-11-02 03:12:25 +01:00
ariel- 469870a141 Core/Player: cleanup single target auras on spec switch
Closes #806
2016-11-02 03:12:09 +01:00
ariel- 7a0647ec46 Core/Unit: fix warning reported by VS2015
C4146: unary minus operator applied to unsigned type, result still unsigned
2016-11-02 03:01:30 +01:00
Aokromes 6e191748ab Core/Conditions: merge CONDITION_SOURCE_TYPE_QUEST_SHOW_MARK with CONDITION_SOURCE_TYPE_QUEST_ACCEPT 2016-11-02 03:01:05 +01:00
ariel- c0ef2ba55c Core/Unit: fix logic error in DamageInfo::ModifyDamage.
Previous code did not protect against m_damage underflow, rather only allow up to duplicate damage.
It now should work as intended.

Closes #18154
2016-11-02 02:56:40 +01:00
Aokromes 0be1e9c4d5 Core/SpellMgr: overwrite DBC RangeEntry for Safeguard 2016-11-02 02:54:50 +01:00
SnapperRy fe4da7ede8 Core/SAI: remove wrong DB errors.
It is normal to have events applicable only to certain instance difficulties.

Closes #18082.
2016-11-02 02:50:57 +01:00
ariel- 00b7cabd80 Core/Globals: abort server startup if there are wrong factions in DB
Closes #18127
2016-11-02 02:46:39 +01:00
Aokromes f88d3935fc Core/Unit: fix chain cc's not being diminished properly 2016-11-02 02:45:27 +01:00
Aokromes 1f1defedc0 Core/Chat: Fix crash when creating a new character
By ariel-
2016-10-27 18:25:50 +02:00
Aokromes 59053a099b Compile fix 2016-10-24 19:28:03 +02:00
Aokromes 16c340fdb6 more compile fix try 2016-10-24 17:05:32 +02:00
Aokromes c5d2bc544f And another compile fix try 2016-10-24 16:59:27 +02:00
Aokromes 4ad4326c53 another compile try fix 2016-10-24 16:53:19 +02:00
Aokromes 4b541233da More compile fix try 2016-10-24 16:49:33 +02:00