Shauren
dc8bf301bb
Core/Auras: Fixed saving auras with same spell id but different item source
2022-09-12 09:15:21 +02:00
ariel-
ae23b5d45a
Core/Auras: fix nopch
2022-09-12 09:15:17 +02:00
ariel-
ee99e76fa9
Core/Auras: fix auras apply on player when loading. Fixes Ghost aura flags and player deathstate
2022-09-12 09:15:17 +02:00
ariel-
55577ad85b
Core/Spells: Fix some issues with channeled spells and aura duration mods
2022-09-12 09:15:16 +02:00
ariel-
b6fac86b71
Core/Spells: rework part 5: GameObject casting
2022-09-12 09:15:14 +02:00
ariel-
3fbbea61bd
Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
...
# Conflicts:
# src/server/game/Spells/Auras/SpellAuras.h
2022-09-12 09:15:13 +02:00
ariel-
2baddd4393
Core/Auras: remove too strict checks in area auras, since a few aren't owned by its caster
2022-09-12 09:15:12 +02:00
ariel-
6640641cce
Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load
2022-09-12 09:15:12 +02:00
ariel-
e23f4e38cf
Core/Auras: skip target map update for one world tick if owner is not yet in world
2022-09-12 09:15:11 +02:00
ariel-
9f9f3fa24f
Core/Auras: make area and dynauras condition compliant by using the spellarea searcher instead of script searchers
2022-09-12 09:15:11 +02:00
ariel-
c81f48197d
Core/Spells: calculate crit chance only for spells that do damage/healing
2022-09-12 09:15:10 +02:00
ariel-
a804af7219
Core/Spell: SpellValueOverrides encapsulation
...
- No sense to let scripts use SpellValueOverrides, we already have modifiers in CastSpellExtraArgs struct
2022-09-12 09:15:04 +02:00
ariel-
1d3fbff332
Core/Auras: removed caster dependency from core
...
- Decoupled Unit logic: split of spell critical chance into done (caster bonuses) and taken (target bonuses), this allows to precalculate caster bonuses on aura apply and then check victim's auras on damage/healing calc
- Made static a bunch of methods (they no longer have this pointer because they are now called from periodic handlers which may or may not have an active caster in world)
- Simplified all AuraEffect bonuses into AuraEffect::_amount, no more duplicated code
- Critical chance and whether or not caster is player owned unit (for resilience calcs) is now saved one level upper, on Aura itself (it's impossible as of 3.3.5 to have different effects with different critical chances)
- Minor cleanup of SPELL_DAMAGE_CLASS_NONE and Arcane Potency (#18813 ) crit handling
2022-09-12 09:15:04 +02:00
Ovahlord
e83c5955b4
Core/Spells: moved Improved Devouring Plague to spell script and fixed the damage effect
2022-02-22 12:57:29 +01:00
Shauren
73bae7c5e5
Core/Spells: Correct implementation of SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC, SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED and rename them (SPELL_ATTR2_ACTIVE_THREAT, SPELL_ATTR3_NOT_A_PROC, SPELL_ATTR3_CAN_PROC_FROM_PROCS)
2022-02-02 17:45:23 +01:00
Gildor
ffb22996b1
Revert "Core/Spells: Force Invisibility (mage) to leave combat." ( #27701 )
...
This reverts commit 4b0acb7432 .
Co-authored-by: kaelima <kaelima@live.se >
# Conflicts:
# src/server/game/Spells/Auras/SpellAuras.cpp
2022-02-02 17:42:52 +01:00
Ovahlord
520b53a5e0
Core/Spells: added a helper to determine whenever a periodic aura should roll over its duration on refresh
...
* introduce another custom spell attribute to grant full control over when or when not to roll over ticks
2022-01-14 18:46:03 +01:00
Ovahlord
0aa9129c3b
Core/Spells: let all periodic effects roll over their timers on refresh
...
* renamed SPELL_ATTR0_CU_DONT_RESET_PERIODIC to SPELL_ATTR0_CU_RESET_PERIODIC_TIMER and changed functionality to prevent described behavior from happening
2022-01-12 18:51:21 +01:00
Ovahlord
9085526f9a
Core/Spells: define and implement SPELL_ATTR8_PERIODIC_CAN_CRIT
...
* SPELL_ATTR8_DONT_RESET_PERIODIC_TIMER has been moved to a custom attribute (SPELL_ATTR0_CU_DONT_RESET_PERIODIC)
2022-01-12 17:33:34 +01:00
Krudor
732f5623f3
Core/Spells: Removed a faulty aura handler
2021-12-02 13:46:33 +01:00
Ovahlord
df38c26f92
Core/Units: re-added a few capability fixups that got removed in 0a7dfc15e2 and allow auras to send their amount values when changing amount via RecalculateAmount
2021-11-10 13:16:25 +01:00
Ovahlord
23e08a69ba
fixed build
2021-04-16 17:00:21 +02:00
Ovahlord
e93a66d287
Core/Spells: defined and implemented SPELL_ATTR5_DONT_TARGET_PLAYERS
2021-03-30 10:26:15 +02:00
Shauren
db683078a7
Core/Auras: Improve PROC_ATTR_USE_STACKS_FOR_CHARGES implementation to give stacks priority over charges if both are present in spell data
2021-02-24 23:09:57 +01:00
Shauren
bb450b82ef
Core/Auras: Implemented new spell proc attribute PROC_ATTR_USE_STACKS_FOR_CHARGES to drop stacks instead of charges
2021-02-19 12:51:56 +01:00
Shauren
69fb775c2d
Core/Spells: Defined new spell attributes
2021-01-15 18:23:09 +01:00
Ovahlord
754c138f89
Core/Spells: ported CastSpell unclusterfucking from 3.3.5 branch
2020-11-04 22:37:11 +01:00
Ovahlord
a51d331e9a
Core/Spells: do not save Priest's T11 Chakra Flow bonus to database to fix an exploit that was causing it to permanently last on the player
2020-09-13 22:24:02 +02:00
Keader
2159703022
Core/Spells: Implemented PROC_ATTR_CANT_PROC_FROM_ITEM_CAST
2020-09-08 20:58:11 +02:00
Shauren
fb11c148c8
Core/Spells: Removed PROC_ATTR_DISABLE_EFF_* attributes and store that in a separate column
2020-09-08 20:56:11 +02:00
Warpten
2b2fc5fb8a
Core/Spells: remove PrepareSpellScript and PrepareAuraScript macros and make Hooklist use emplace behaivior ( #174 )
2020-08-28 15:40:26 +02:00
Peter Keresztes Schmidt
a06e5d7d40
Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs
2020-07-18 22:43:24 +02:00
Ovahlord
2a8fe49a73
Core/Packets: changed amount storage for aura update packets from vector to array to improve performance
2020-07-16 17:42:08 +02:00
Ovahlord
961144d82d
Core/Packets: converted SMSG_AURA_UPDATE and SMSG_AURA_UPDATE_ALL to packet class
2020-07-16 17:28:49 +02:00
Warpten
0af44ccc01
Core/Spells: implement DoT clipping
...
* Core/Spells: Implementation of DoT clipping.
* Core/Utilities: Backport "EnumFlags v3.0" from master.
* Core/Spells: Switch AURA_REMOVE_MODE to a flag set.
2020-06-04 18:16:03 +02:00
Ovahlord
b770d2e4d0
Core/Spells: renamed Amplitude and ValueMultiplier to match DBC field names
2020-04-16 14:40:30 +02:00
Ovahlord
fc12e97cfe
Core/Spells: implement SPELL_EFFECT_APPLY_AURA_2 and TARGET_DEST_CASTER_FLOOR
2020-03-14 21:14:07 +01:00
jackpoz
183789053e
Core/Misc: Fix GCC 8 warnings
2020-01-31 21:19:25 +01:00
funjoker
590ad14856
Core/Spells: Allow skipping automatic removal of auras from spell_area when condition is no longer met (mostly used for cosmetic cutscenes after quest completion)
2020-01-11 03:38:28 +01:00
jackpoz
131986d1c2
Core/Misc: Replace time(nullptr) with GameTime::GetGameTime()
2020-01-11 03:30:41 +01:00
Aokromes
d6d3f06f06
New year
2020-01-04 18:32:38 +01:00
funjoker
6c56916b29
Misc: Update copyright information
...
Happy new year
2020-01-01 18:47:28 +01:00
Ovahlord
abb62cc76f
Core/Spells: reverted proc behaivior for pets and fixed applying spell mods for hunter pets and minions
2019-12-09 16:10:54 +01:00
Ovahlord
7ec720ef22
Core/Spells: spells of controlled units will now trigger their owner's proc auras as well and benefit from their proc chance modifiers
2019-12-08 23:05:41 +01:00
Ovahlord
3ec0f92fc7
Core/Spells: fixed sending reduced cooldowns of cooldown modded spells
2019-09-25 21:23:22 +02:00
Ovahlord
c074c3a9c6
Revert "Core/Misc: Replace time(NULL) with GameTime::GetGameTime()"
...
This reverts commit 5fe3a1f7f9 .
2019-07-08 15:56:29 +02:00
Ovahlord
5fe3a1f7f9
Core/Misc: Replace time(NULL) with GameTime::GetGameTime()
...
(ported commit: 12701cb0c6c45eb105ad449eb9a56e76d84d691e)
2019-07-08 12:19:19 +02:00
Wyrserth
2848c4f536
Core/Spell: do not allow auras from dynamic objects to stack if they come from the same spell cast by the same caster.
2019-07-08 09:35:24 +02:00
Wyrserth
2c5dc57d22
Core/Spell: don't send duration for auras caused by dynobjects.
2019-07-08 09:34:53 +02:00
Ovahlord
1323ae116c
Core/Vehicles: fixed a crash caused when changing vehicle seats via spell
...
*cleaned up some code for aura target limits
2019-05-27 14:56:46 +02:00