Commit Graph
10574 Commits
Author SHA1 Message Date
Aokromes dff1518ac2 Scripts/Command: implement .debug play music command 2017-05-30 09:55:45 +02:00
Treeston 16e60ba408 Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)
2017-05-30 09:21:38 +02:00
ariel- e778c4c628 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit 2017-05-30 09:21:03 +02:00
Treeston e80602f048 Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.
2017-05-30 09:20:49 +02:00
Aokromes 6021c8d29c typo fix on previous commit 2017-05-29 19:20:32 +02:00
Ryan 79661eeb39 Fix build 2017-05-28 20:19:48 +01:00
Ryan e054036742 Fix SMSG_POWER_UPDATE 2017-05-28 20:19:33 +01:00
Ryan a289acff81 Core/Spells: Fix SPELL_AURA_FIXATE 2017-05-28 20:14:31 +01:00
Ryan cc9c363b00 Core/Instance: Reset FAIL to NOT_STARTED on load 2017-05-28 20:13:42 +01:00
Ryan b1de58c7f8 Core/Phases: Fix area phase handling
Now honors the zone id as well as area id
2017-05-28 20:01:36 +01:00
Ryan f29874d7ad Core/Player: Add missing return 2017-05-28 19:58:44 +01:00
Ryan be1ca945c7 Core/Player: Fixed gem activation requirements
Not sure if the structure is totally correct, but it can now properly read all the data we actually use
2017-05-28 19:55:25 +01:00
Ryan 1442984686 Merge branch '4.3.4' of https://gitlab.com/trinitycore/TrinityCore_434 into 4.3.4 2017-05-28 19:10:00 +01:00
Ryan 5e50bb9481 Fix warning and whitespace 2017-05-28 18:39:41 +01:00
ariel- 3d5584fb86 Core/Pools: fix VS dynamic linking 2017-05-28 03:18:59 +02:00
ariel- da65d89129 Core/Misc: fix some clang 5 warnings 2017-05-28 03:18:50 +02:00
treeston e361682377 Quickfix a bug introduced by 2f19d97 which prevented GTAoE from being cast. 2017-05-28 03:18:35 +02:00
ariel- 8082b3165e Core/Spell: abort channeling if no valid targets are found after searching
Closes #17624
2017-05-28 03:11:57 +02:00
Aokromes f3c30eabbe missing part 2017-05-26 18:43:02 +02:00
Aokromes 975e487cf9 Core/PlayerDump: general revamping 2017-05-26 18:32:37 +02:00
Shauren d8b9d2a9da Core/Misc: Prefix all preprocessor defines from CompilerDefs with TRINITY_ to avoid conflicts (PLATFORM_WINDOWS is used/defined by CascLib)
(cherry picked from commit b8db320bf14e327bcd12279871b914d8635ef122)
2017-05-26 14:49:55 +02:00
Aokromes 06168fb412 Implement real time statistic visualization 2017-05-26 14:47:59 +02:00
ariel- 70f3879c32 Core/Player: update interaction checks, some info taken from client 2017-05-26 14:26:43 +02:00
DoctorKraft 225b6ede81 Core/Hotswap: Fix Reload on Linux
* Closes #19465
2017-05-26 14:25:08 +02:00
Shauren aa864d57f7 Core/Hotswap: Replace #ifdef conditions with comparisons of values defined in CompilerDefs.h
(cherry picked from commit 43510a258c83215efcf5e70a253523e8a4199502)
2017-05-26 14:24:42 +02:00
Aokromes f0e36b0863 Core/Defines: define faction templates and replace magic numbers from scripts 2017-05-23 14:37:54 +02:00
Ryan 20726edec2 Merge branch '4.3.4' of https://gitlab.com/trinitycore/TrinityCore_434 into 4.3.4 2017-05-19 23:49:46 +01:00
ariel- ddb787482c Core/Unit: don't clear low health aura states on death
- Confirmed with sniffs, healthless states aren't cleared
- Prevents some procs from happening

Closes #19754
2017-05-16 06:50:39 +02:00
Aokromes a20788a8a8 Core/Misc: Fix dynamic linkin
By Krudor
2017-05-14 17:03:00 +02:00
Aokromes 7c0f5add07 Core/Logs: Reword some logs 2017-05-12 10:03:46 +02:00
Aokromes d9f72fdb88 Core/Globals: fix array out of bounds crash on loading npc_text_locale 2017-05-07 10:35:16 +02:00
ariel- 4eaa6b50b6 Core/Entities: allow guardian pets to inherit spellmods 2017-05-07 06:06:34 +02:00
Aokromes 6a7f15ecf4 Scripts/Commands: Update reload commands names 2017-05-07 06:05:53 +02:00
Aokromes fc20b6934b build fix 2017-05-06 02:38:01 +02:00
Aokromes 0fbcdca05e Core/Collision: Replaced phasemask with proper phases in GameObject c…
…ollision calculation
2017-05-06 01:55:17 +02:00
xinef1 b88200cd58 Core/Misc: Various crash fixes 2017-05-05 01:59:34 +01:00
roc13x 02e174d7e9 Cleanup 2017-05-05 00:10:25 +01:00
roc13x 7d6884dcb5 Core/Spells: Fix SPELL_AURA_PROC_ON_POWER_AMOUNT
Will re-implement the eclipse handling in spellscripts later
2017-05-04 21:16:50 +01:00
Aokromes a16f3b9e0f Missing change 2017-05-04 18:09:12 +02:00
Aokromes 9bdf7bc7f0 Core/Misc: Update locales_gossip_menu_option to simple system 2017-05-04 17:57:22 +02:00
Aokromes 46d73126dd Core/Misc: Update locales_npc_text to simple system 2017-05-04 17:21:32 +02:00
Chazy Chaz 5158cca124 Core/Misc: Update locales_creature_text to simple system 2017-05-04 17:02:32 +02:00
roc13x c2fd775e5d Add missing changes
Core compiles now
2017-05-04 05:24:21 +01:00
ariel- 07a182f1d3 Core/Spell: register spell mod owner properly on spell cast
- This fixes pets and totems getting mods from owner
2017-05-04 05:04:19 +01:00
ariel- 2ed7602af2 Core/Spell: fix broken Unit::GetHighestExclusiveSameEffectSpellGroupValue
- Affects 3 aura effects currently, should be rewritten with GetTotalAuraModifier maybe?
2017-05-04 05:03:08 +01:00
ariel- d2d7a2cb14 Core/Spell: fix nopch build 2017-05-04 05:02:36 +01:00
ariel- eee81e3748 Core/Spell: fix nopch build x2 2017-05-04 05:02:26 +01:00
ariel- 9dbbe92875 Core/Spell: build fix 2017-05-04 05:02:05 +01:00
ariel- 76349ea8ce Core/Spell: fixed SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT to actually check effects
- This commit enables stack rule 3 to be properly used to fix auras that should be active but only one providing effects, even if the spell has multiple auras

Closes #19454
2017-05-04 05:01:47 +01:00
ariel- 091100f795 Core/Spell: check aura positivity per effect on spell hit
- Fixes applying DR to positive effects, and changing duration of whole aura

Closes #19447
2017-05-04 05:01:17 +01:00