jackpoz
0930482fa4
Core/Misc: Fix uninitialized values
...
Fix Position members not being always initialized.
Valgrind log:
at : Position::NormalizeOrientation(float) (Object.h:388)
by : Position::SetOrientation(float) (Object.h:315)
by : Position::Relocate(Position const&) (Object.h:310)
by : spell_ulduar_stone_grip::spell_ulduar_stone_grip_AuraScript::OnRemoveVehicle(AuraEffect const*, AuraEffectHandleModes) (boss_kologarn.cpp:592)
2014-04-02 20:42:46 +02:00
jackpoz
6dcd8c8545
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior
Please ensure EventMap is never used with event id set to 0 or those events will never execute.
2014-03-22 14:54:32 +01:00
Vincent_Michael
20004050bc
Update copyright note for 2014.
...
Happy new year.
2014-01-01 00:07:53 +01:00
jackpoz
64b42c75d2
Scripts/Misc: Code cleanup
...
Remove some NULL checks not needed anymore after 3744c14184 .
Fix an invalid Creature to TempSummon cast.
2013-12-30 23:36:49 +01:00
jackpoz
3744c14184
Scripts/Misc: Ensure Creatures are in instances when required
...
Create ScriptedAIs that require a InstanceScript reference only if the InstanceScript exists, so if these Creatures are in an instance. ScriptedAIs that don't require a InstanceScript reference have not been modified.
This fixes many possible NULL dereference crashes happening when spawning a scripted Creature outside of an instance.
Fixed a GetOwner() and a ToPlayer() NULL dereference crashes too.
2013-12-29 01:19:52 +01:00
joschiwald
0790138d73
Core. fix build and some codestyle changes
2013-11-13 23:32:38 +01:00
Ascathor
2607738990
Core/Code: Unify codestyle for brackets: {} to { }.
...
Also added missing copyright to some files.
2013-10-27 23:46:02 +01:00
Vincent_Michael
9802c7b891
Scripts/Misc: Coding Style unification? (by Aokromes)
2013-10-22 20:24:05 +02:00
Vincent-Michael
8acefbff8c
Scripted: Use now override for instance scripts
2013-08-10 17:42:12 +02:00
Vincent-Michael
e464d2bd2c
Scripted: Some cleanups + ninja changes
2013-07-08 21:15:23 +02:00
Nay
3561ab98ba
Misc: Use override and final C++11 keywords in a few places (mostly scripts)
...
OVERRIDE and FINAL are TC macros (expand to nothing if compiler does not support C++11)
2013-07-06 20:21:45 +01:00
Vincent-Michael
6079f369af
Scripted/Misc: Some cleanup
2013-07-06 01:00:05 +02:00
Vincent-Michael
b4d4e04f53
Scripts/Misc: Rename creatures with mob_ / mobs_ in npc_
...
Note: Have fun :P
2013-07-04 22:11:47 +02:00
Vincent-Michael
e6185c92fc
Scripts: Convert DoCast(me->GetVictim(), SPELL_XXXXX); in DoCastVictim(SPELL_XXX);
2013-06-22 16:53:13 +02:00
Malcrom
66978cfc3b
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
Shauren
8633452f8d
Scripts/Misc: Fixed many scripts not executing one of their actions because of an event with id = 0
2013-05-19 10:52:39 +02:00
Nefarion
49fd11ab5a
First step of comment style refactoring to doxygen-style.
2013-03-08 21:55:37 +01:00
Shauren
5b414bb813
Core/Scripts: Removed useless const modifier on method parameters accepting primitive types passed by value
2013-02-19 17:35:27 +01:00
Spp
802657250c
Core/Misc: Apply codestyle to multiple files
2013-01-14 09:50:59 +01:00
Vincent_Michael
abe4b656c8
Scripts/Mechanar:
...
* cleanup for door system
* Convert mechano lord capacitus in c++
2013-01-13 01:07:11 +01:00
Malcrom
df2e54f587
Core/Scripting: More cleanup to Mechanar scripts. Added missing doors and handling to instance.
2013-01-12 19:35:14 -03:30
Vincent_Michael
bf7f58365f
Scripts/Misc: Some cleanups
2013-01-12 19:35:32 +01:00
Vincent_Michael
a02fa868a8
Core: Fix build
2013-01-12 19:01:49 +01:00
Malcrom
1993544103
Core/Scripting: More updates to Mechanar
2013-01-12 14:04:25 -03:30
Malcrom
0b6997b8af
Core/Scripting: Move Boss_Gatewatcher_Gyrokill to c++ scripting. Additional cleanup in Mechanar.
2013-01-12 00:14:12 -03:30
Vincent_Michael
cc65aba789
Update copyright note for 2013.
...
Happy new year.
2013-01-01 00:41:01 +01:00
Gacko
8fbec4156b
Core/DB: Creature text for 22 script files
2012-12-07 10:04:40 +01:00
Spp
81606e5d1e
Core/Misc: Define some methods const
2012-11-20 09:29:52 +01:00
Spp
b99c347747
Core: Remove Player.h dependency from all the possible headers
2012-11-17 05:18:37 +01:00
Vincent-Michael
634b3645d5
Core/Misc: Use proper headers to optimize compile
2012-07-30 05:38:40 +02:00
Shauren
e0997874f5
Core/SpellScripts: Changed OnUnitTargetSelect hook to OnObjectAreaTargetSelect, it will now work with WorldObject instead of only Units and call it even for empty target lists
2012-06-29 21:53:35 +02:00
Gyx
d9088c083c
Core/Script: Code style and some rewriting.
...
JustDied(Unit* Killer) -> JustDied(Unit* killer)
JustDied(Unit* /*Killer*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* /*unit*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* /*slayer*/)) -> JustDied(Unit* /*killer*/)
JustDied(Unit* /*victim*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* victim) -> JustDied(Unit* killer)
JustDied(Unit* /*who*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* who) -> JustDied(Unit* killer)
JustDied(Unit*) -> JustDied(Unit* /*killer*/)
Signed-off-by: Gyx <2359980687@qq.com >
2012-03-31 18:56:37 +08:00
Gyx
bef1b0c402
Core/Script: Code style.
...
Signed-off-by: Gyx <2359980687@qq.com >
2012-03-16 19:40:57 +08:00
Kandera
c517806a23
Scripts/Spells: Convert code from Spell::EffectDummy to spell scripts.
2012-02-18 12:12:49 +01:00
click
e6d5b21778
Core: Fix non-PCH build and remove a few warnings.
2012-01-24 00:24:39 +01:00
kaelima
233d891952
Scripts/Achievements:
...
- Move achievement Shocking! to appropriate boss script instead of instance script.
- Split the polarity spellscript into two and move to proper boss file
- Fixed a typo in Loatheb's spore achievement.
2012-01-11 17:21:03 +01:00
kiper
8299627ed9
Update headers for 2012. HAPPY NEW YEAR!!!
2012-01-01 00:32:13 +01:00
Spp
3792b470e0
Core/Scripts: Replace rand with urand in most cases (using regexp)
...
Used: perl -pi -e 's/([0-9]+) \+ rand\(\)\%([0-9]+)/"urand(".$1.", ".($1+$2).")"/ge'
2011-12-28 10:51:16 +01:00
Bootz
5b4c7783c2
REPO: Code-style clean-ups
...
* Fixed pMap->map
* Fixed pInstance->instance
* Fixed pInsta->instance
* Fixed pQuest->quest
* Fixed pWho->who
* Fixed pTarget->target
* Fixed pGo->go
~DEVNOTES: Handlers/QuestHandler.cpp still needs to be cleaned...
2011-10-07 19:45:43 -05:00
Spp
b16d2245bb
Cosmetic: Multiple cosmetic changes
...
- Added missing space to 'if', 'for', 'while' and 'switch' when it's followed by '('
- Added missing space after a comma and remove space before comma (with some exceptions)
- Remove trailing spaces
- Convert tab to spaces
Note: Only affects files with extension "cpp" and "h" under /src/server
2011-09-29 12:43:05 +02:00
Spp
af05915b9e
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:12:57 +02:00
click
70115f52f7
Core: Cleaning up hungarian notation - Phase3: pTarget -> target
2011-07-02 23:16:45 +02:00
click
f91ee24184
Core: Start cleaning up hungarian notation - Phase1: pCreature -> creature
2011-07-02 22:18:03 +02:00
Spp-
6fd41ae50e
Scripts: Reorder file names in Commands/CMakeList file and cosmetic changes in all scripts
2011-06-30 14:24:56 +02:00
click
158966dc79
Core: Codestyle cleanup
2011-06-11 22:35:29 +02:00
leak
1003f30448
Add spaces after commas
2011-04-29 20:47:02 +02:00
Shauren
3fcb49c685
Core/Scripts: Removed double calls to InstanceScript's Initialize methods
2011-04-03 21:24:22 +02:00
Shauren
2f79b0f266
Core: Removed all double (and more) empty lines
2011-03-21 10:52:14 +01:00
Shauren
c2c40a4750
Scripts: Removed duplicate target selection function (SelectUnit), there is only SelectTarget now
2011-03-09 21:32:04 +01:00
Machiavelli
957c69de83
Update copyright note for 2011.
...
Happy new year.
2011-01-01 15:01:13 +01:00