Commit Graph
899 Commits
Author SHA1 Message Date
Shauren ea4bc6c02a Core/Spells: Rename SpellAttr2 to use official attribute names
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-09-13 14:36:32 +02:00
Shauren ca7d36873f Core/Spells: Rename SpellAttr1 to use official attribute names
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-09-12 09:15:31 +02:00
ariel- 3a3e70f2b6 Core/Spells: all bleed effects should ignore armor 2022-09-12 09:15:19 +02:00
ariel- 1fe5563431 Core/Spells: Fix periodic rolling adding bonuses twice
Calculation is now done in CalculateAmount
2022-09-12 09:15:15 +02:00
ariel- b6fac86b71 Core/Spells: rework part 5: GameObject casting 2022-09-12 09:15:14 +02:00
ariel- 4bb8c93df8 Core/Spells: rework part 4: iterate over effects first
Implement far spell queue processing

# Conflicts:
#	src/server/game/Spells/Spell.cpp
2022-09-12 09:15:13 +02:00
ariel- 95bc5dcc40 Core/Spells: rework part 1: Improved positive detection logic
# Conflicts:
#	src/server/game/Spells/SpellInfo.cpp
2022-09-12 09:15:12 +02:00
ariel- c81f48197d Core/Spells: calculate crit chance only for spells that do damage/healing 2022-09-12 09:15:10 +02:00
Shauren d448ea4370 Core/Spells: Rename SpellAttr0 to use official attribute names 2022-09-12 09:15:04 +02:00
Ovahlord 149d9aec8d Core/Spells: allow Rip's periodic effect to crit 2022-07-17 11:47:56 +02:00
Ovahlord 846e89c1fc Core/Spells: allow Combustion's damage over time effect to crit 2022-06-24 23:13:48 +02:00
Ovahlord e5f09705c1 Core/Spells: fixed typos which have been added in 77158594ff 2022-04-01 14:03:45 +02:00
Ovahlord 5f2b1e45e4 Core/Spells: improve integer to float conversions and checks for spell proc entries 2022-03-10 20:43:12 +01:00
Ovahlord 78896a132f Core/Spells: ported proc flag updates from master branch 2022-02-22 21:19:09 +01:00
Ovahlord e83c5955b4 Core/Spells: moved Improved Devouring Plague to spell script and fixed the damage effect 2022-02-22 12:57:29 +01:00
Ovahlord 6e412b16de Core/Spells: correctly implement Elemental Oath 2022-02-21 11:17:41 +01:00
Ovahlord d712a12f1c Core/Spells: use correct macro for tree of life stance requirement 2022-02-21 10:53:32 +01:00
Ovahlord 97a79175fc Core/Spells: added a bunch of default ctors for several spellMgr structs to silence uninitialized member warnings 2022-02-21 10:50:00 +01:00
Ovahlord 06f6987e2a Core/Spells: allow Rupture's damage to scale with combo points as well 2022-02-21 10:21:43 +01:00
Ovahlord f01012aac9 Core/Spells: corrected the finishing move spell attributes for Rupture and Expose Armor 2022-02-21 10:16:30 +01:00
ariel- b8d1bab8de Core/Spells: refactor spell_enchant_proc_data table
- Renamed fields to mimic those in spell_proc
- Added Enchant proc attributes for controlling specific enchant features

Ref #7789

(cherry picked from commit f609e7a08b3b4d2d9642e5ec252e1eedad836f0f)
2022-02-16 04:49:24 +01:00
Ovahlord 0d5a854b49 Core/Spells: corrected the spell range entry for Furious Attack's triggered healing reduction debuff 2022-02-07 16:08:02 +01:00
Ovahlord 2157ab4510 fixed build 2022-02-02 17:49:14 +01:00
Shauren 73bae7c5e5 Core/Spells: Correct implementation of SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC, SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED and rename them (SPELL_ATTR2_ACTIVE_THREAT, SPELL_ATTR3_NOT_A_PROC, SPELL_ATTR3_CAN_PROC_FROM_PROCS) 2022-02-02 17:45:23 +01:00
Ovahlord f63d798ed7 Scripts/Firelands: implement Ragnaros encounter 2022-02-02 17:40:54 +01:00
xinef1 9da4acce08 Core/Spells: Remade trajectory target selection (#19048)
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received

(cherry picked from commit c6060dd0c511ddad3cb1f0423aa9ccf2de7aedec)
2022-01-22 22:29:20 +01:00
Keader 3681f356d6 Core/Spell: Fixed range issues with some quest spells
Closes #17815

(cherry picked from commit 6f7310a25993f06676ae91f4d80071d5ce576978)
2022-01-22 19:04:34 +01:00
Ovahlord 67b19e741d Core/Misc: fixed several warnings that have been exposed by the new warnings 2022-01-21 14:22:06 +01:00
Ovahlord 0aa9129c3b Core/Spells: let all periodic effects roll over their timers on refresh
* renamed SPELL_ATTR0_CU_DONT_RESET_PERIODIC to SPELL_ATTR0_CU_RESET_PERIODIC_TIMER and changed functionality to prevent described behavior from happening
2022-01-12 18:51:21 +01:00
Ovahlord 9085526f9a Core/Spells: define and implement SPELL_ATTR8_PERIODIC_CAN_CRIT
* SPELL_ATTR8_DONT_RESET_PERIODIC_TIMER has been moved to a custom attribute (SPELL_ATTR0_CU_DONT_RESET_PERIODIC)
2022-01-12 17:33:34 +01:00
Ovahlord 3ff8840fe2 Core/Items: ported several enchantment flag implementations from master branch 2022-01-09 18:15:38 +01:00
Ovahlord 39da927196 Scripts/Misc: resolved cherrypick issues and regressions 2021-12-31 15:53:53 +01:00
Ovahlord c7892087fe Core/Spells: fixed Serpent Spread talent 2021-12-27 13:46:05 +01:00
Ovahlord abdada99a4 Core/Spells: add missing attribute to Soul Fragment to allow High Prophet Barim's soul fragments to move towards the Harbinger of Darkness 2021-12-27 00:01:34 +01:00
Ovahlord 8596cf6be2 Core/Spells: renamed SPELL_ATTR5_CAN_CHANNEL_WHEN_MOVING to SPELL_ATTR5_ALLOW_ACTIONS_DURING_CHANNEL to match its leaked name 2021-12-26 22:09:27 +01:00
Ovahlord c709290888 Scripts/Firelands: implement Lord Rhyolith encounter 2021-10-30 16:16:34 +02:00
Ovahlord b10f962ba3 Core/Creatures: several cleanups and improvements to spell focusing to reduce edge case issues 2021-10-21 13:18:24 +02:00
AlιAѕѕaѕѕιN 338c1e28ae [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

* Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

(cherry picked from commit 92d83c3c2eaba3f5b58dc98472318872f3a54706)
2021-06-26 00:58:18 +02:00
Ovahlord 3301b87dba fixed a warning 2021-06-12 15:31:40 +02:00
Ovahlord ab405f6935 Core/Spells: Gouge will now have a chance of not being canceled by bleeding effects when having learned Sanguinary Vein
closes #263
2021-06-12 14:42:15 +02:00
Ovahlord 8011d2de29 Core/Spells: ported resistance and immunity updates from 3.3.5 branch 2021-06-12 14:10:44 +02:00
Ovahlord 1064209eaf Scripts/HoO:
* Temple Guardian Anhuur's Divine Reckoning will now prefer non-tank targets above tanks
* Added missing attribute to Anhuur's heroic version of Reverberating Hymn that was causing the periodic timer to reset on each stacking
2021-05-26 22:16:01 +02:00
Ovahlord 6052573c87 Core/Spells: defined and implemented SPELL_ATTR7_CANT_DODGE, SPELL_ATTR7_CANT_PARRY, SPELL_ATTR7_CANT_MISS, SPELL_ATTR8_CANT_BLOCK, SPELL_ATTR10_ALLOW_DEFENSE_WHILE_CASTING and SPELL_ATTR10_ALLOW_DEFENSE_WHILE_CHANNELING 2021-04-07 12:17:48 +02:00
Ovahlord 77158594ff Core/Spells:
* renamed SPELL_ATTR3_CANT_TRIGGER_PROC to SPELL_ATTR3_CANT_TRIGGER_CASTER_PROCS and expanded its implementation
* renamed SPELL_ATTR3_NO_INITIAL_AGGRO to SPELL_ATTR3_CANT_TRIGGER_TARGET_PROCS and implement the attribute
* expanded implementation SPELL_ATTR2_NO_INITIAL_THREAT to cover all remaining spots
2021-03-30 17:50:27 +02:00
Shauren fed82c1002 Core/Auras: Defined and implemented many new interrupt flags 2021-03-24 14:53:30 +01:00
Ovahlord e020c3ac5e Scripts/Deepholm: scripted Xariona world boss 2021-03-13 18:12:14 +01:00
Ovahlord d818a7030c Scripts/BoT: scripted trash npcs in the Bastion Antechamber 2021-02-25 16:32:07 +01:00
Ovahlord 3d20971d01 Core/Spells: Seal of Insight will no longer proc on AOE attacks and updated proc data for Cataclysm instead of MoP 2021-02-19 17:51:07 +01:00
Ovahlord 1e1ebf16bd Scripts/HoO: scripted Sun-Touched Servants 2021-01-29 21:27:31 +01:00
Ovahlord 0bb7e3a385 Scripts/LCT: reworked Siamat encounter
* Modernized code all across the board
* Wailing Winds are now much closer to retail behavior
* Minions of Siamat are no longer chasing players and properly transform into clouds when possible instead of abruptly interrupting all actions
* Fixed an edge in which Siamat absorbed clouds but did not get his Gathered Storms effect
* Dropped all hacks
2021-01-26 23:19:02 +01:00