Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 18 Packages Projects Releases Wiki Activity
36,213 Commits 2 Branches 1 Tag
ed6a4a4bcd8422e6dcf157a490c4f371e3d8a00d
Commit Graph
6694 Commits
Author SHA1 Message Date
Treeston ed6a4a4bcd Scripts/Auchindoun: Blackheart the Inciter fully fixed now. I had way too much fun with this one. 
Two points of note:
1) Spawning 5 invisible triggers with 5 distinct factions which then MC one target each? Biggest. Hack. Ever. Best part? It's blizzlike.
2) For over ten years, I thought it was spelled "Auchinodoun". It's not. It's spelled "Auchindoun". TIL.

# Conflicts:
#	sql/old/4.3.4/world/19_2017_06_18/2017_07_21_01_world.sql
 2020-07-22 14:44:03 +02:00
Treeston af9bc15a42 nopch fix 2 2020-07-22 14:43:29 +02:00
Treeston 6de2a6e928 nopch fix 2020-07-22 14:43:25 +02:00
Treeston 365a473e56 Scripts/Auchindoun: Replace the Blackheart the Inciter hack-filled script with a slightly less hack-filled script that actually mostly works. This should at least make the boss encounter possible to complete. No claims to correctness, of course. 
# Conflicts:
#	sql/old/4.3.4/world/19_2017_06_18/2017_07_21_00_world.sql
#	src/server/scripts/Outland/Auchindoun/ShadowLabyrinth/boss_blackheart_the_inciter.cpp
 2020-07-22 14:42:21 +02:00
treeston 45e05b947b Some more script adjustments ported from #19930. 2020-07-22 14:38:29 +02:00
Ovahlord 96f8af56cb Scripts/ScarletEnclave: 74af880217fc567c9949d7557408718af889402f followup 2020-07-22 14:38:02 +02:00
treeston a09db6b4ba Hi, I'm Treeston, and welcome to Combat PR Prep Refactors. 
Today, we're moving UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC to higher-level abstraction so combat manager can react to it.
New methods on Unit:
- void SetImmuneTo<All/PC/NPC>(apply, keepCombat = false);
- bool IsImmuneTo<All/PC/NPC>() const;

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedEscortAI.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Spells/SpellEffects.cpp
#	src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/boss_tomb_of_seven.cpp
#	src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp
#	src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp
#	src/server/scripts/EasternKingdoms/ShadowfangKeep/instance_shadowfang_keep.cpp
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp
#	src/server/scripts/EasternKingdoms/zone_tirisfal_glades.cpp
#	src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/culling_of_stratholme.cpp
#	src/server/scripts/Kalimdor/WailingCaverns/wailing_caverns.cpp
#	src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp
#	src/server/scripts/Kalimdor/zone_stonetalon_mountains.cpp
#	src/server/scripts/Kalimdor/zone_tanaris.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp
#	src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp
#	src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
#	src/server/scripts/Outland/TempestKeep/arcatraz/boss_harbinger_skyriss.cpp
 2020-07-22 14:35:53 +02:00
treeston f2592116ae Some more refactoring prep for combat/threat (#19930). 
# Conflicts:
#	src/server/game/Combat/ThreatManager.h
#	src/server/scripts/Kalimdor/RuinsOfAhnQiraj/boss_moam.cpp
#	src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp
 2020-07-22 13:48:18 +02:00
Shauren 6da0e00747 Nopch fix 5 and should be last 2020-07-22 13:46:32 +02:00
Shauren 73e7270673 typo fix 2020-07-22 13:46:28 +02:00
Shauren cc1df2659e Nopch fix 4 2020-07-22 13:46:24 +02:00
treeston 3645c382d9 nopch fix episode 3: revenge of that one boss in slabs that is borked anyway 2020-07-22 13:46:20 +02:00
Treeston ec04d3b2cd [3.3.5] Combat/Threat rewrite - prep & refactor (#19966) 
* Combat/Threat rewrite (PR #19930) prep work. Mostly refactors, and a compatibility layer on ThreatManager/HostileReference that allows scripts to be changed already.
 2020-07-22 13:43:23 +02:00
Ovahlord bd444eb6e1 Scripts/Items: fixed a warning reported by gcc 2020-07-19 14:36:37 +02:00
Ovahlord e1d74d4dc6 Core/Misc: added more fallthrough attributes and added some missing breaks reported by CI 2020-07-19 12:24:58 +02:00
Peter Keresztes Schmidt cbd6fb2315 Build: Enable -Wimplicit-fallthrough on clang (#25056) 
* Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs

Related: #25006

* Misc: Add some missing breaks (no-ops) to satisfy clang

Related: #25006
Closes #25055

* Build: Enable -Wimplicit-fallthrough on clang

Closes #25006
# Conflicts:
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Spells/SpellInfo.cpp
#	src/server/scripts/Battlefield/BattlefieldWG.cpp
#	src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockSpire/instance_blackrock_spire.cpp
#	src/server/scripts/EasternKingdoms/ScarletMonastery/boss_high_inquisitor_fairbanks.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/boss_rotface.cpp
#	src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp
#	src/server/shared/DataStores/DBCDatabaseLoader.cpp
 2020-07-18 22:47:52 +02:00
Giacomo Pozzoni cbb0fe41de Core/Misc: Replace boost::shared_mutex with std::shared_mutex (#24328) 
* Core/Misc: Replace boost::shared_mutex with std::shared_mutex

* Remove std forward declarations
# Conflicts:
#	src/server/game/Loot/LootItemStorage.h
 2020-07-18 22:38:50 +02:00
Ovahlord 405569dbff Core/Spells: 
* fixed Kill Command
* fixed Improved Kill Command crit chance bonus
* fixed Frenzy not triggering Focus Fire's visual effect correctly

closes #78
 2020-07-17 16:21:37 +02:00
Ovahlord 00a94593cd Scripts/BWD: scripted Dwarven spirits 2020-07-15 16:03:45 +02:00
Ovahlord 79dffad47f Scripts/TotT: fixed a typo and build 2020-07-14 16:50:07 +02:00
Ovahlord 66069bcef1 Scripts/Misc: fixed instance teleporter for Throne of the Tides, The Stonecore and Blackrock Caverns 2020-07-14 16:42:30 +02:00
Ovahlord f8091d6aac Core/Movement: made SetDisableGravity and SetHover virtual and handle anim tiers in their new override inside of the Creature class. 
* no longer set anim tiers when the target is rooted
 2020-07-13 14:07:59 +02:00
Ovahlord fac96b99b5 Scripts/TotFW: removed far visible and setActive calls as the new aoi types now handle this 2020-07-13 12:09:00 +02:00
Ovahlord d46fb93657 Core/Pools: ported pooling updates from 335 branch 2020-07-13 11:17:19 +02:00
Ovahlord 404d8d6eaa Scripts/BoT: scripted Twilight Phase Twister orbs 2020-07-12 18:04:20 +02:00
Ovahlord eedb17447a Core/Spells: Combustion will no longer pick up other Combustion effects and the eligible aura effects will now have their amount devided 2020-07-11 20:35:40 +02:00
Ovahlord 2ad3201067 Core/Spells: fixed Improved Blood Presence benefits not having any effect 2020-07-11 14:06:38 +02:00
Ovahlord 580e12e5a6 Scripts/BWD: scripted Drakonoid Chainwielder and Drakonoid Drudge trash npcs and scripted Magmaw's emote visual while chained 2020-07-10 22:20:48 +02:00
Ovahlord 31a54e41bf Scripts/BWD: scripted Lord Victor Nefarius' taunts after defeating bosses on normal difficulty 2020-07-10 00:39:46 +02:00
Ovahlord d7a4a6dad1 Core/Movement: do no predict follow destinations when the follower is faster than its target outside of catchup and formation mechanics 2020-07-09 22:02:42 +02:00
Shauren 1dd44ab9b9 Core/Spells: Don't select corpses for spell targets that expect to hit units 
Closes #24980

# Conflicts:
#	src/server/game/Spells/Spell.cpp
 2020-07-09 19:14:24 +02:00
Ovahlord 0ce8d44288 Scripts/LCT: reworked General Husam encounter 
* corrected timer layout
* corrected timers for Bad Intention hurls and Shockwave damage
* corrected movement speed and distance values for the Shockwave dummy npcs
* dropped unneeded creature scripts
* moved encounter related creatures that were scripted in SAI to C++ for consistency
* updated all scripts to modern model
 2020-07-09 19:08:26 +02:00
Ovahlord 14f3143f76 Scripts/HoO: simplified GetHallsOfOriginationAI helper to support multiple object types in one method 2020-07-09 14:53:38 +02:00
Ovahlord e093715c4d Scripts/ICC: fixed the crash for real this time 2020-07-09 14:21:47 +02:00
Ovahlord 3f4749fd22 Scripts/ICC: fixed a crash in the Lich King encounter when the Jump script effect targets corpses instead of units 2020-07-09 13:59:36 +02:00
Ovahlord c0eae1322b Scripts/DS: removed a debug output from Madness of Deathwing script 2020-07-07 14:28:54 +02:00
Ovahlord b30f90cfb0 Scripts/Commands: fixed a typo 2020-07-07 02:39:07 +02:00
Ovahlord d077c92011 Core/Datastores: ported locale related datastore updates in order to load storage locales properly when set in config 2020-07-07 02:39:07 +02:00
Ovahlord 2f176528fc Scripts/BWD: Maloriak will now launch his Magma Jets into the direction of random players instead of his victim only. 2020-07-06 01:09:58 +02:00
Ovahlord 7121946bee Scripts/TotT: Lady Nazjar can no longer be oneshot killed and needs her two phases to be completed before being able to kill her 2020-07-05 21:59:52 +02:00
Ovah b09d6e2330 Core/Movement: reimplement follow movement (#124) 2020-06-26 21:22:21 +02:00
Ovahlord 120a4cc983 Core/Spells: Fire Nova will no longer consume Flame Shock from its targets and will no longer deal damage to its explicit cast target 2020-06-22 20:32:06 +02:00
Ovahlord 0debb33df0 Scripts: fixed nopch build 2020-06-14 00:58:10 +02:00
Ovahlord 893b80d0c4 Scripts/ScarletEnclave: ported several fixes from 335 2020-06-14 00:40:59 +02:00
funjoker adf9e6a004 Core/Misc: Make Clang 10 happier 2020-06-11 21:55:01 +02:00
funjoker 187d537fba Core/Misc: (try) Make Clang 10 happy 2020-06-11 21:12:34 +02:00
Giacomo Pozzoni 9fdf598792 Cherry-pick some cmake commits (#24720) 
* Build system: Support  new in cmake 3.17 Ninja Multi-Config generator

(cherry picked from commit 369b618d4f160816818681ed7e41063e2d9ba5b5)

* Build system: Fixed PCH with MSVC & Ninja generator

(cherry picked from commit d669f46b6d5190dabc686a35656e8b03f5ec325b)

* Core: Fix clang 10 warnings

(cherry picked from commit 7272508cb4b51ec5591b6f0e542ea29091db7546)

* Build system: Set -Wno-deprecated-copy only for clang 10

(cherry picked from commit 7fdeb259ba398d5d9343a5dcd1a89562dfcbe981)

* Core/Misc: GCC build and warning fixes

(cherry picked from commit 4d69cc1c567180b408ddbadb9edf26859cf4c006)

* Build system: Print found git version when warning about it being too old

(cherry picked from commit 1ae72db201189877c1b863fac140eb4b0a45c5bb)

* Build system: Removed hard requirement on BOOST_ROOT being set as environment variable, it can now be also passed as command line argument to cmake and fix compile warning with boost 1.73

(cherry picked from commit 161944b7643c62f9e7705c64e42d42e5d07f1959)

* Remove some code that was already removed from 335 and then cherry-picked into master

Co-authored-by: Shauren <shauren.trinity@gmail.com>
(cherry picked from commit 8c09b6e58b0e4f33b7a8e376a28709e693cf2914)
 2020-06-11 20:24:00 +02:00
Shauren 40f80fc0ed Core/Maps: Improvements to terrain swap handling 
* Fixed memory leak when unloading grids
* Handle child maps being entered
* Allow chaining more child maps (Draenor -> Tanaan Jungle -> Tanaan Jungle - No Hubs Phase)
 2020-06-11 01:35:27 +02:00
Ovahlord 8a7d723e11 Scripts: fixed nopch build 2020-06-08 08:29:59 +02:00
Ovahlord dae1dab09d Scripts/BH: rewrite Alizabal encounter 2020-06-08 08:24:11 +02:00