joschiwald
ef9b4aea5e
Core/InstanceScript: refactored load and save methods
2014-09-07 00:42:14 +02:00
jackpoz
6df2ff5efa
Core/Misc: Refactor scripts to fix static analysis warnings
...
Third batch of fixes targeting 100 issues reported by Coverity
2014-09-05 22:44:24 +02:00
joschiwald
bc42c48d97
DB/Spells: added a few spells to spelldifficulty_dbc
2014-08-26 04:35:37 +02:00
jackpoz
7fa49c8d62
Scripts/Ruby Sanctum: Fix Halion event ai not being updated
...
Fix Halion event ai not being updated due to private member hiding base class member.
Fixes #12835
2014-08-24 20:35:44 +02:00
Shauren
7532864264
Buildsystem/MSVC: Warning fixes
...
C4800 'type' : forcing value to bool 'true' or 'false' (performance warning)
C4127 conditional expression is constant
2014-07-17 15:42:57 +02:00
Trisjdc
f27821486b
DB/SpellGroups: Completely review of WotLK Stack Rules
...
Closes https://github.com/TrinityCore/TrinityCore/issues/4313 , https://github.com/TrinityCore/TrinityCore/issues/1626 , https://github.com/TrinityCore/TrinityCore/issues/5173 , https://github.com/TrinityCore/TrinityCore/issues/5822 , https://github.com/TrinityCore/TrinityCore/issues/12212 , https://github.com/TrinityCore/TrinityCore/issues/3814 , and probably others
2014-06-15 23:22:53 +01:00
jackpoz
1083dbb993
Core/Misc: Remove Unit::Get* wrappers for ObjectAccessor::Get*
2014-05-20 21:21:33 +02:00
Shauren
f9c7bb4171
Partially revert f296095191 "Fix various warnings. The core, the scripts and the tools now compile without warnings with -Wall -Wextra -pedantic."
...
Visual studio does not support constexpr
Made semicolon after "Prepare*Script" mandatory - workaround for dumb IDEs inserting extra indentation level after newline
2014-05-18 12:50:10 +02:00
Praetonus
f296095191
Fix various warnings. The core, the scripts and the tools now compile without warnings with -Wall -Wextra -pedantic.
...
-Fix warnings from -Woverflow on implicit constant conversion.
-Fix warnings from -pedantic.
-Fix warnings from -pedantic.
-Fix warnings from -Wformat.
Two minor changes in addition :
-Replace a defined value equal to 2^31 - 1 by std::numeric_limits<int>::max().
-Remove useless null-check on pointer returned by new. New doesn't returns nullptr on failure, it throws std::bad_alloc.
2014-05-15 21:32:47 +02:00
Dehravor
24ae6a6802
Core/Misc: Remove obsolete C++11 backward compatibility macros
...
OVERRIDE, FINAL, DELETE_MEMBER
2014-04-29 16:35:11 +02:00
jackpoz
2585e799f9
Core/Misc: Change how Position struct is retrieved
...
Update Position::GetPosition() and similar methods signatures to reflect 2a4c9bcaf9 changes by return a Position object instead of accepting a Position parameter by reference.
2014-04-25 21:19:30 +02:00
Warpten
d9493d9cc9
Scripts/Ruby Sanctum: Fixed corporeality scaling changes.
...
Thanks to Unholychick.
P.S.: #9231 if still valid will be fixed soon (tm)
2014-04-19 19:18:51 +02:00
Warpten
335fe8e1b0
Scripts/Ruby Sanctum: Fixed Halion engaging combat outside of his Flame Ring.
2014-04-10 14:28:58 +02:00
Warpten
b36e7c0211
Scripts/Ruby Sanctum: Fixed Onyx Flamecallers not aggroing players once pathing ended.
2014-04-09 17:55:54 +02:00
Gacko
4bcbcf53d8
Core/Script: Logical fixes
2014-03-19 10:05:02 +01:00
Vincent_Michael
46e1b93c2b
Scripts: A lots of changes here and there (maybe useless?!?)
2014-01-23 22:54:01 +01:00
joschiwald
d6c5307a81
Scripts/Spells: use new hook in some spellscripts
2014-01-23 20:55:47 +01:00
zengwf
23acf75d3b
Core/Movement: Add LOS check for fleeingmovement target point.
...
Prevents fleeing or feared units from going to upper floor ignoring walls/ceilings with mmaps on(and usually get stucked).
Current implementation just randomly selects a distance and angle against the frighting unit, when in narrow circumstance such as underground caves, such targeting point would be at another floor.
Closes #11300
Ref #9475 (needs fixed confirmation)
2014-01-12 00:33:33 +00:00
Vincent_Michael
20004050bc
Update copyright note for 2014.
...
Happy new year.
2014-01-01 00:07:53 +01:00
jackpoz
64b42c75d2
Scripts/Misc: Code cleanup
...
Remove some NULL checks not needed anymore after 3744c14184 .
Fix an invalid Creature to TempSummon cast.
2013-12-30 23:36:49 +01:00
Malcrom
fe95371d9a
Core/Scripting: Replace casted with cast as casted is not a word.
2013-12-25 14:16:55 -03:30
joschiwald
fd6167cf66
Scripts:
...
- cleanup obsidian sanctum script
- prevent yelling texts if non player died in some scripts
2013-12-23 23:55:15 +01:00
Shauren
107af52853
Core/Chat: Refactored building chat packets
...
* Moved everything into one specialized method instead of being scattered all over the place
* Allow localizing creature names in chat messages (when using $N)
* Send SMSG_GM_MESSAGECHAT for gm messages
2013-12-23 14:23:49 +01:00
Malcrom
d741335a02
DB/Creature_text: Updated more text from sniff.
2013-12-22 20:18:07 -03:30
Vincent_Michael
fb26e18523
Core: Fix warnings
2013-12-11 20:30:15 +01:00
Malcrom
fc7e335d3b
Scripting/Obsidian Sanctum: Updated scripts to use Events.
2013-12-11 01:13:23 -03:30
Ascathor
2607738990
Core/Code: Unify codestyle for brackets: {} to { }.
...
Also added missing copyright to some files.
2013-10-27 23:46:02 +01:00
Vincent_Michael
9802c7b891
Scripts/Misc: Coding Style unification? (by Aokromes)
2013-10-22 20:24:05 +02:00
joschiwald
77f90c1c67
Scripts/Halion: refixed Twilight Cutter
...
Scripts/Garfrost: fixed forge jump
2013-09-11 17:07:29 +02:00
Sebastian Valle
5b95301de5
Core/Misc: Solved some issues found by static code analysis.
2013-09-03 13:38:50 -05:00
Nay
78786c7b54
Core&Scripts: Fix clang compiler warnings
2013-08-27 23:47:03 +01:00
Nay
2050a36b58
SAI & Scripts: Fix unitialized values found by Valgrind
...
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19B3031: boss_skarvald_the_constructor::boss_skarvald_the_constructorAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:217)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19B3948: boss_dalronn_the_controller::boss_dalronn_the_controllerAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:388)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x15E2FCC: SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:144)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191D242: npc_shadron::npc_shadronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1122)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19AE913: boss_ymiron::boss_ymironAI::UpdateAI(unsigned int) (boss_ymiron.cpp:215)
==3064== Use of uninitialised value of size 8
...
==3064== by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)
==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064== by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191CE88: npc_tenebron::npc_tenebronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1027)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191D5B8: npc_vesperon::npc_vesperonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1220)
==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064== by 0x1868F59: boss_lady_vashj::boss_lady_vashjAI::Reset() (boss_lady_vashj.cpp:206)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191C14C: dummy_dragonAI::MovementInform(unsigned int, unsigned int) (boss_sartharion.cpp:802)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x1046986: Position::NormalizeOrientation(float) (Object.h:388)
...
==3064== by 0x17D9463: boss_malchezaar::boss_malchezaarAI::SummonInfernal(unsigned int) (boss_prince_malchezaar.cpp:373)
2013-08-26 16:13:26 +01:00
Nay
8eaf763235
Core&Tools: Fix multiple issues found by a static code coverage tool
2013-08-26 02:00:18 +01:00
Vincent-Michael
8acefbff8c
Scripted: Use now override for instance scripts
2013-08-10 17:42:12 +02:00
Nay
3561ab98ba
Misc: Use override and final C++11 keywords in a few places (mostly scripts)
...
OVERRIDE and FINAL are TC macros (expand to nothing if compiler does not support C++11)
2013-07-06 20:21:45 +01:00
Vincent-Michael
6079f369af
Scripted/Misc: Some cleanup
2013-07-06 01:00:05 +02:00
Vincent-Michael
b4d4e04f53
Scripts/Misc: Rename creatures with mob_ / mobs_ in npc_
...
Note: Have fun :P
2013-07-04 22:11:47 +02:00
Vincent-Michael
e6185c92fc
Scripts: Convert DoCast(me->GetVictim(), SPELL_XXXXX); in DoCastVictim(SPELL_XXX);
2013-06-22 16:53:13 +02:00
Shauren
b6aadc6698
Scripts/Misc: Use new movement flag setting methods in scripts
2013-06-18 16:48:46 +02:00
Malcrom
ec474a62e5
Core: More Function Renaming.
2013-06-11 21:25:12 -02:30
Malcrom
66978cfc3b
Core: Some function renaming.
2013-06-11 19:54:27 -02:30
Spp
1a6a23ec96
Core/Misc: Minor optimizations (+code changes to reduce differences with 4.3.4 branch)
...
Core/Logging: Create new logger type "Cheat". Will be used to log all cheat attempts
2013-03-25 13:26:48 +01:00
Nefarion
49fd11ab5a
First step of comment style refactoring to doxygen-style.
2013-03-08 21:55:37 +01:00
Shauren
5b414bb813
Core/Scripts: Removed useless const modifier on method parameters accepting primitive types passed by value
2013-02-19 17:35:27 +01:00
click
75994b3dd3
Core: Clean up whitespace, and remove a silly warning in boss_lurker_below.cpp
2013-02-07 00:19:19 +01:00
m7nu3l
f9654d52e0
Core/AI: Removed Scripted_NoMovementAI which has become obsolete. Use ScriptedAI::SetCombatMovement(false); to get the same functionality.
2013-02-04 19:18:48 -03:00
Gacko
dbecf05e39
Core: Logical fixes and improvements in EventMap
2013-01-30 18:39:34 +01:00
Vincent_Michael
ed44eea699
Core: Fix warnings
2013-01-19 20:28:29 +01:00
kaelima
557fde86e4
Script/Ruby Sanctum: Miss in a05e78bb18 Thanks joschiwald
2013-01-14 04:38:05 +01:00
kaelima
a05e78bb18
Script/Ruby Sanctum: Some cleanup and minor fixes
...
Solves #8573
Closes #8490
2013-01-14 02:40:24 +01:00